Skip to contentSkip to conversation

net: dsa: loop: Add module soft dependency

PATCH Applied Florian Fainelli 2 participants 2 messages May 9, 2020 – May 10, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: dsa: loop: Add module soft dependency

There is a soft dependency against dsa_loop_bdinfo.ko which sets up the MDIO device registration, since there are no symbols referenced by dsa_loop.ko, there is no automatic loading of dsa_loop_bdinfo.ko which is needed.

Fixes 98cd1552ea27 ("net: dsa: Mock-up driver")
---
 drivers/net/dsa/dsa_loop.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/dsa/dsa_loop.c +1 -0
index fdcb70b9f0e4..400207c5c7de 100644
@@ -360,6 +360,7 @@ static void __exit dsa_loop_exit(void)
 }
 module_exit(dsa_loop_exit);
 
+MODULE_SOFTDEP("pre: dsa_loop_bdinfo");
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Florian Fainelli");
 MODULE_DESCRIPTION("DSA loopback driver");
Signature · 1 line
2.17.1
maintainer Applied
#1 lore raw
Quoted 7 lines · On Sat, 9 May 2020 16:45:44 -0700 Florian Fainelli wrote:

There is a soft dependency against dsa_loop_bdinfo.ko which sets up the MDIO device registration, since there are no symbols referenced by dsa_loop.ko, there is no automatic loading of dsa_loop_bdinfo.ko which is needed.

Fixes 98cd1552ea27 ("net: dsa: Mock-up driver")

Applied, thank you!