Skip to contentSkip to conversation

net/ice/base: fix pppoe-ipv6 dummy packet error

PATCH Applied Wei Zhao 4 participants 4 messages May 7, 2020 – May 11, 2020 Network drivers

lore
Share & tools
lore

Wei Zhao

author
#0 lore raw

PATCH 1/1 net/ice/base: fix pppoe-ipv6 dummy packet error

The dummy packet for pppoe-ipv6 has an error, we should use 0x3b for next header in ipv6 header in the dummy packet, or some case can not be download, such as:

"eth / pppoes seid is 3 / pppoe_proto_id is 0x0057 / end actions vf id 1 / end"

Fixes 55d61fb27a5e ("net/ice/base: add PPPoE IPv6 dummy packet")
---
 drivers/net/ice/base/ice_switch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ice/base/ice_switch.c +1 -1
index 957142a10..a07ceea70 100644
@@ -577,7 +577,7 @@ static const u8 dummy_pppoe_ipv6_packet[] = {
 	0x00, 0x57,		/* PPP Link Layer 24 */
 
 	0x60, 0x00, 0x00, 0x00, /* ICE_IPV6_OFOS 26 */
-	0x00, 0x00, 0x00, 0x00,
+	0x00, 0x00, 0x3b, 0x00,
 	0x00, 0x00, 0x00, 0x00,
 	0x00, 0x00, 0x00, 0x00,
 	0x00, 0x00, 0x00, 0x00,
Signature · 1 line
2.19.1
Tested-by on v1 1/1
#1 lore raw

-----Original Message-----
From: Zhao1, Wei
Sent: Thursday, May 7, 2020 9:16 AM
To: [email protected]
Cc: Zhang, Qi Z <[email protected]>; Lu, Nannan <[email protected]>; Zhao1, Wei <[email protected]>
Subject: [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error

The dummy packet for pppoe-ipv6 has an error, we should use 0x3b for next header in ipv6 header in the dummy packet, or some case can not be download, such as:

"eth / pppoes seid is 3 / pppoe_proto_id is 0x0057 / end actions vf id 1 / end"

Fixes 55d61fb27a5e ("net/ice/base: add PPPoE IPv6 dummy packet")
---
 drivers/net/ice/base/ice_switch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ice/base/ice_switch.c +1 -1
index 957142a10..a07ceea70 100644
@@ -577,7 +577,7 @@ static const u8 dummy_pppoe_ipv6_packet[] = {
 	0x00, 0x57,		/* PPP Link Layer 24 */
 
 	0x60, 0x00, 0x00, 0x00, /* ICE_IPV6_OFOS 26 */
-	0x00, 0x00, 0x00, 0x00,
+	0x00, 0x00, 0x3b, 0x00,
 	0x00, 0x00, 0x00, 0x00,
 	0x00, 0x00, 0x00, 0x00,
 	0x00, 0x00, 0x00, 0x00,

--
2.19.1

Acked-by
#2 lore raw
Quoted 23 lines

-----Original Message-----
From: Lu, Nannan <[email protected]>
Sent: Thursday, May 7, 2020 9:52 AM
To: Zhao1, Wei <[email protected]>; [email protected]
Cc: Zhang, Qi Z <[email protected]>
Subject: RE: [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error

-----Original Message-----
From: Zhao1, Wei
Sent: Thursday, May 7, 2020 9:16 AM
To: [email protected]
Cc: Zhang, Qi Z <[email protected]>; Lu, Nannan <[email protected]>; Zhao1, Wei <[email protected]>
Subject: [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error

The dummy packet for pppoe-ipv6 has an error, we should use 0x3b for next header in ipv6 header in the dummy packet, or some case can not be download, such as:

Quoted 5 lines

"eth / pppoes seid is 3 / pppoe_proto_id is 0x0057 / end actions vf id 1 / end"

Fixes 55d61fb27a5e ("net/ice/base: add PPPoE IPv6 dummy packet")
Applied
#3 lore raw
In reply to Wei Zhao
Quoted 30 lines · Wei Zhao

The dummy packet for pppoe-ipv6 has an error, we should use 0x3b for next header in ipv6 header in the dummy packet, or some case can not be download, such as:

"eth / pppoes seid is 3 / pppoe_proto_id is 0x0057 / end actions vf id 1 / end"

Fixes 55d61fb27a5e ("net/ice/base: add PPPoE IPv6 dummy packet")

---
drivers/net/ice/base/ice_switch.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ice/base/ice_switch.c +1 -1
index 957142a10..a07ceea70 100644
@@ -577,7 +577,7 @@ static const u8 dummy_pppoe_ipv6_packet[] = {
 	0x00, 0x57,		/* PPP Link Layer 24 */
 
 	0x60, 0x00, 0x00, 0x00, /* ICE_IPV6_OFOS 26 */
-	0x00, 0x00, 0x00, 0x00,
+	0x00, 0x00, 0x3b, 0x00,
 	0x00, 0x00, 0x00, 0x00,
 	0x00, 0x00, 0x00, 0x00,
 	0x00, 0x00, 0x00, 0x00,
Signature · 1 line
2.19.1

Applied to dpdk-next-net-intel, Thanks.