Skip to contentSkip to conversation

xen/pvcalls-back: test for errors when calling backend_connect()

PATCH In review Juergen Gross 2 participants 3 messages May 11, 2020 – May 12, 2020

Subsystems (2)
lore
Share & tools
lore

Juergen Gross

author maintainer
#0 lore raw

PATCH 1/1 xen/pvcalls-back: test for errors when calling backend_connect()

backend_connect() can fail, so switch the device to connected only if no error occurred.

Fixes 0a9c75c2c7258f2 ("xen/pvcalls: xenbus state handling")
---
 drivers/xen/pvcalls-back.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/xen/pvcalls-back.c +2 -1
index cf4ce3e9358d..41a18ece029a 100644
@@ -1088,7 +1088,8 @@ static void set_backend_state(struct xenbus_device *dev,
 		case XenbusStateInitialised:
 			switch (state) {
 			case XenbusStateConnected:
-				backend_connect(dev);
+				if (backend_connect(dev))
+					return;
 				xenbus_switch_state(dev, XenbusStateConnected);
 				break;
 			case XenbusStateClosing:
Signature · 1 line
2.26.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Juergen Gross

backend_connect() can fail, so switch the device to connected only if no error occurred.

Fixes 0a9c75c2c7258f2 ("xen/pvcalls: xenbus state handling")
Quoted 9 lines
---
 drivers/xen/pvcalls-back.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/xen/pvcalls-back.c +0 -0
index cf4ce3e9358d..41a18ece029a 100644

drivers/xen/pvcalls-back.c static void set_backend_state(struct xenbus_device *dev, · line 1092

Quoted 6 lines
drivers/xen/pvcalls-back.c +2 -1
@@ -1088,7 +1088,8 @@ static void set_backend_state(struct xenbus_device *dev,
 		case XenbusStateInitialised:
 			switch (state) {
 			case XenbusStateConnected:
-				backend_connect(dev);
+				if (backend_connect(dev))
+					return;

Do you think it would make sense to WARN?

Quoted 6 lines
drivers/xen/pvcalls-back.c +0 -0
 				xenbus_switch_state(dev, XenbusStateConnected);
 				break;
 			case XenbusStateClosing:
Signature · 1 line
2.26.1
author maintainer
#2 lore raw
Quoted 15 lines · Stefano Stabellini
Quoted 6 lines · Juergen Gross

backend_connect() can fail, so switch the device to connected only if no error occurred.

Fixes 0a9c75c2c7258f2 ("xen/pvcalls: xenbus state handling")
Quoted 4 lines
---
  drivers/xen/pvcalls-back.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 13 lines

drivers/xen/pvcalls-back.c static void set_backend_state(struct xenbus_device *dev, · line 1092

Quoted 11 lines
drivers/xen/pvcalls-back.c +2 -1
index cf4ce3e9358d..41a18ece029a 100644
@@ -1088,7 +1088,8 @@ static void set_backend_state(struct xenbus_device *dev,
  		case XenbusStateInitialised:
  			switch (state) {
  			case XenbusStateConnected:
-				backend_connect(dev);
+				if (backend_connect(dev))
+					return;

Do you think it would make sense to WARN?

There already should be an error message (either due to a failed grant mapping or a failed memory allocation).

Juergen