xen/pvcalls-back: test for errors when calling backend_connect()
Subsystems (2)
Juergen Gross
maintainerPATCH 1/1 xen/pvcalls-back: test for errors when calling backend_connect()
backend_connect() can fail, so switch the device to connected only if no error occurred.
Fixes 0a9c75c2c7258f2 ("xen/pvcalls: xenbus state handling")
Signed-off-by Juergen Gross <[email protected]>
--- drivers/xen/pvcalls-back.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/xen/pvcalls-back.c +2 -1
@@ -1088,7 +1088,8 @@ static void set_backend_state(struct xenbus_device *dev,case XenbusStateInitialised:switch (state) {case XenbusStateConnected: -backend_connect (dev); +if (backend_connect (dev)) +return ;xenbus_switch_state (dev, XenbusStateConnected);break ;case XenbusStateClosing:
Signature · 1 line
2.26.1
Quoted 6 lines · Juergen Gross
backend_connect()can fail, so switch the device to connected only if no error occurred.Fixes 0a9c75c2c7258f2 ("xen/pvcalls: xenbus state handling")Signed-off-by Juergen Gross <[email protected]>
Reviewed-by Stefano Stabellini <[email protected]>
Quoted 9 lines
--- drivers/xen/pvcalls-back.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/xen/pvcalls-back.c +0
-0
drivers/xen/pvcalls-back.c static void set_backend_state(struct xenbus_device *dev, · line 1092
Quoted 6 lines
drivers/xen/pvcalls-back.c +2
-1@@ -1088,7 +1088,8 @@ static void set_backend_state(struct xenbus_device *dev,case XenbusStateInitialised:switch (state) {case XenbusStateConnected: -backend_connect (dev); +if (backend_connect (dev)) +return ;
Do you think it would make sense to WARN?
Quoted 6 lines
drivers/xen/pvcalls-back.c +0
-0xenbus_switch_state (dev, XenbusStateConnected);break ;case XenbusStateClosing:Signature · 1 line
2.26.1
Jürgen Groß
maintainerQuoted 15 lines · Stefano Stabellini
Quoted 6 lines · Juergen Gross
backend_connect()can fail, so switch the device to connected only if no error occurred.Fixes 0a9c75c2c7258f2 ("xen/pvcalls: xenbus state handling")Signed-off-by Juergen Gross <[email protected]>Reviewed-by Stefano Stabellini <[email protected]>Quoted 4 lines
--- drivers/xen/pvcalls-back.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 13 lines
drivers/xen/pvcalls-back.c static void set_backend_state(struct xenbus_device *dev, · line 1092
Quoted 11 lines
drivers/xen/pvcalls-back.c +2
-1@@ -1088,7 +1088,8 @@ static void set_backend_state(struct xenbus_device *dev,case XenbusStateInitialised:switch (state) {case XenbusStateConnected: -backend_connect (dev); +if (backend_connect (dev)) +return ;Do you think it would make sense to WARN?
There already should be an error message (either due to a failed grant mapping or a failed memory allocation).
Juergen