Novena laptop panel
Subsystems (4)
cover Novena laptop panel
From: Richard Marko <[email protected]>
Contains updated patches I've received from Marek with the following changes:
- yaml docs migration
- fixed Fabios email
- panel commit split into two according to checkpatch request
- added connector for panel
Last review also requested more details for panel like timings and bus format but these are marked as TBD (timings) in panel datasheet and the bridge datasheet is not helpful either.
Tested on a Kosagi Novena laptop with imx6 display controller.
Based on v5.7-rc2, applies to drm-misc-next 5e6ed29d72d2
Sean Cross (2):
dt-bindings: n133hse-ea1: Add Innolux N133HSE panel drm/panel: simple: Add Innolux N133HSE panel support
.../bindings/display/panel/panel-simple.yaml | 2 ++ drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++ 2 files changed, 29 insertions(+)
base-commit: ae83d0b416db002fe95601e7f97f64b59514d936
Signature · 1 line
2.25.1
PATCH 1/2 dt-bindings: n133hse-ea1: Add Innolux N133HSE panel
From: Sean Cross <[email protected]>
The Innolux N133HSE panel is a 13.3" 1920x1080 panel that contains an integrated backlight, and connects via eDP.
It is used in the Kosagi Novena.
--- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/display/panel/panel-simple.yaml +2 -0
@@ -139,6 +139,8 @@ properties: - innolux,g121i1-l01 # Innolux Corporation 12.1" G121X1-L03 XGA (1024x768) TFT LCD panel - innolux,g121x1-l03 + # Innolux Corporation 13.3" FHD (1920x1080) TFT LCD panel + - innolux,n133hse-ea1 # Innolux Corporation 11.6" WXGA (1366x768) TFT LCD panel - innolux,n116bge # InnoLux 15.6" WXGA TFT LCD panel
Signature · 1 line
2.25.1
Rob Herring
maintainerRe: [PATCH 1/2] dt-bindings: n133hse-ea1: Add Innolux N133HSE panel
Quoted 22 lines · On Sat, May 09, 2020 at 01:18:33PM +0200, [email protected] wrote:
From: Sean Cross <[email protected]>
The Innolux N133HSE panel is a 13.3" 1920x1080 panel that contains an integrated backlight, and connects via eDP.
It is used in the Kosagi Novena.
Signed-off-by Sean Cross <[email protected]>Signed-off-by Richard Marko <[email protected]>Cc Shawn Guo <[email protected]>Cc Fabio Estevam <[email protected]>Cc Thierry Reding <[email protected]>--- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+)Documentation/devicetree/bindings/display/panel/panel-simple.yaml +0
-0
Documentation/devicetree/bindings/display/panel/panel-simple.yaml properties: · line 145
Quoted 7 lines
Documentation/devicetree/bindings/display/panel/panel-simple.yaml +2
-0@@ -139,6 +139,8 @@ properties: - innolux,g121i1-l01 # Innolux Corporation 12.1" G121X1-L03 XGA (1024x768) TFT LCD panel - innolux,g121x1-l03 + # Innolux Corporation 13.3" FHD (1920x1080) TFT LCD panel + - innolux,n133hse-ea1 # Innolux Corporation 11.6" WXGA (1366x768) TFT LCD panel - innolux,n116bge
Alpha-numeric order please.
Quoted 4 lines
Documentation/devicetree/bindings/display/panel/panel-simple.yaml +0
-0# InnoLux 15.6" WXGA TFT LCD panelSignature · 1 line
2.25.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 2/2 drm/panel: simple: Add Innolux N133HSE panel support
In reply to [email protected]From: Sean Cross <[email protected]>
The Innolux N133HSE panel is a 13.3" 1920x1080 panel that contains an integrated backlight, and connects via eDP.
It is used in the Kosagi Novena.
--- drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +27 -0
@@ -1906,6 +1906,30 @@ static const struct panel_desc innolux_n116bge = { }, }; +static const struct drm_display_mode innolux_n133hse_ea1_mode = { + .clock =138500 , + .hdisplay =1920 , + .hsync_start =1920 +46 , + .hsync_end =1920 +46 +30 , + .htotal =1920 +46 +30 +84 , + .vdisplay =1080 , + .vsync_start =1080 +2 , + .vsync_end =1080 +2 +4 , + .vtotal =1080 +2 +4 +26 , + .vrefresh =60 , +}; + +static const struct panel_desc innolux_n133hse_ea1 = { + .modes = &innolux_n133hse_ea1_mode, + .num_modes =1 , + .bpc =8 , + .size = { + .width =293 , + .height =165 , + }, + .connector_type = DRM_MODE_CONNECTOR_eDP, +}; +static const struct drm_display_mode innolux_n156bge_l21_mode = { .clock =69300 , .hdisplay =1366 ,
@@ -3577,6 +3601,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "innolux,n116bge", .data = &innolux_n116bge, + }, { + .compatible = "innolux,n133hse-ea1", + .data = &innolux_n133hse_ea1, }, { .compatible = "innolux,n156bge-l21", .data = &innolux_n156bge_l21,
Signature · 1 line
2.25.1
Re: [PATCH 2/2] drm/panel: simple: Add Innolux N133HSE panel support
Hi Richard.
Quoted 6 lines · On Sat, May 09, 2020 at 01:18:34PM +0200, [email protected] wrote:
From: Sean Cross <[email protected]>
The Innolux N133HSE panel is a 13.3" 1920x1080 panel that contains an integrated backlight, and connects via eDP.
It is used in the Kosagi Novena.
Thanks for the patch.
Quoted 31 lines
Signed-off-by Sean Cross <[email protected]>Signed-off-by Richard Marko <[email protected]>Cc Shawn Guo <[email protected]>Cc Fabio Estevam <[email protected]>Cc Thierry Reding <[email protected]>--- drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)drivers/gpu/drm/panel/panel-simple.c +12
-0@@ -1906,6 +1906,30 @@ static const struct panel_desc innolux_n116bge = { }, }; +static const struct drm_display_mode innolux_n133hse_ea1_mode = { + .clock =138500 , + .hdisplay =1920 , + .hsync_start =1920 +46 , + .hsync_end =1920 +46 +30 , + .htotal =1920 +46 +30 +84 , + .vdisplay =1080 , + .vsync_start =1080 +2 , + .vsync_end =1080 +2 +4 , + .vtotal =1080 +2 +4 +26 , + .vrefresh =60 , +};
drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc innolux_n116bge = { · line 1930
Quoted 10 lines
drivers/gpu/drm/panel/panel-simple.c +10
-0+ +static const struct panel_desc innolux_n133hse_ea1 = { + .modes = &innolux_n133hse_ea1_mode, + .num_modes =1 , + .bpc =8 , + .size = { + .width =293 , + .height =165 , + }, + .connector_type = DRM_MODE_CONNECTOR_eDP,
Please include .bus_format and .bus_flags info too.
We are relying more and more on this type of info so we need it to be present.
Sam
Quoted 22 lines
drivers/gpu/drm/panel/panel-simple.c +5
-0+}; +static const struct drm_display_mode innolux_n156bge_l21_mode = { .clock =69300 , .hdisplay =1366 ,@@ -3577,6 +3601,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "innolux,n116bge", .data = &innolux_n116bge, + }, { + .compatible = "innolux,n133hse-ea1", + .data = &innolux_n133hse_ea1, }, { .compatible = "innolux,n156bge-l21", .data = &innolux_n156bge_l21,Signature · 6 lines
2.25.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 2/2] drm/panel: simple: Add Innolux N133HSE panel support
Quoted 56 lines · Sam Ravnborg
Hi Richard.
Quoted 6 lines · On Sat, May 09, 2020 at 01:18:34PM +0200, [email protected] wrote:
From: Sean Cross <[email protected]>
The Innolux N133HSE panel is a 13.3" 1920x1080 panel that contains an integrated backlight, and connects via eDP.
It is used in the Kosagi Novena.
Thanks for the patch.
Quoted 31 lines
Signed-off-by Sean Cross <[email protected]>Signed-off-by Richard Marko <[email protected]>Cc Shawn Guo <[email protected]>Cc Fabio Estevam <[email protected]>Cc Thierry Reding <[email protected]>--- drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)drivers/gpu/drm/panel/panel-simple.c +12
-0@@ -1906,6 +1906,30 @@ static const struct panel_desc innolux_n116bge = { }, }; +static const struct drm_display_mode innolux_n133hse_ea1_mode = { + .clock =138500 , + .hdisplay =1920 , + .hsync_start =1920 +46 , + .hsync_end =1920 +46 +30 , + .htotal =1920 +46 +30 +84 , + .vdisplay =1080 , + .vsync_start =1080 +2 , + .vsync_end =1080 +2 +4 , + .vtotal =1080 +2 +4 +26 , + .vrefresh =60 , +};drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc innolux_n116bge = { · line 1930
Quoted 10 lines
drivers/gpu/drm/panel/panel-simple.c +10
-0+ +static const struct panel_desc innolux_n133hse_ea1 = { + .modes = &innolux_n133hse_ea1_mode, + .num_modes =1 , + .bpc =8 , + .size = { + .width =293 , + .height =165 , + }, + .connector_type = DRM_MODE_CONNECTOR_eDP,Please include .bus_format and .bus_flags info too.
Quoted 2 lines
We are relying more and more on this type of info so we need it to be present.
I am wondering which of the flags make sense for eDP and how the bus format should be described?
Some eDP panels seems [1] to specify DRM_BUS_FLAG_DATA_MSB_TO_LSB and DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE, but I am not sure what sense they make for packet data with embedded clock that eDP uses? (Unless, of course, my understanding of eDP is entirely missing the point.)
This panel uses RGB888 data over two differential pairs. Would format = MEDIA_BUS_FMT_RGB888_1X24 be appropriate?
[1] N133HSE-EA1 Datasheet
http://www.vslcd.com/specification/N133HSE-EA1.pdf
Quoted 1 line
Sam
Thank you,
Lubo