Skip to contentSkip to conversation

NFS: Don't use RPC_TASK_CRED_NOREF with delegreturn

PATCH New [email protected] 1 participant 1 message May 11, 2020

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/1 NFS: Don't use RPC_TASK_CRED_NOREF with delegreturn

From: Trond Myklebust <[email protected]>

We are not guaranteed that the credential will remain pinned.

Fixes 612965072020 ("NFSv4: Avoid referencing the cred unnecessarily during NFSv4 I/O")
---
 fs/nfs/nfs4proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfs/nfs4proc.c +1 -1
index a0c1e653a935..9056f3dd380e 100644
@@ -6347,7 +6347,7 @@ static int _nfs4_proc_delegreturn(struct inode *inode, const struct cred *cred,
 		.rpc_client = server->client,
 		.rpc_message = &msg,
 		.callback_ops = &nfs4_delegreturn_ops,
-		.flags = RPC_TASK_ASYNC | RPC_TASK_CRED_NOREF | RPC_TASK_TIMEOUT,
+		.flags = RPC_TASK_ASYNC | RPC_TASK_TIMEOUT,
 	};
 	int status = 0;
 
Signature · 1 line
2.26.2