Skip to contentSkip to conversation

telemetry: fix error log output

PATCH In review David Marchand 2 participants 3 messages May 11, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 telemetry: fix error log output

Caught while running testpmd:
No telemetry legacy support- No legacy callbacks, legacy socket not createdInteractive-mode selected

Add missing \n.

Fixes 6dd571fd07c3 ("telemetry: introduce new functionality")
---
 lib/librte_telemetry/telemetry.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
lib/librte_telemetry/telemetry.c +4 -4
index 9a1e945455..56a2fed3f5 100644
@@ -275,8 +275,8 @@ socket_listener(void *socket)
 		int s_accepted = accept(s->sock, NULL, NULL);
 		if (s_accepted < 0) {
 			snprintf(telemetry_log_error,
-					sizeof(telemetry_log_error),
-					"Error with accept, telemetry thread quitting\n");
+				sizeof(telemetry_log_error),
+				"Error with accept, telemetry thread quitting");
 			return NULL;
 		}
 		pthread_create(&th, NULL, s->fn, (void *)(uintptr_t)s_accepted);
@@ -400,12 +400,12 @@ rte_telemetry_init(const char *runtime_dir, const char **err_str)
 {
 	if (telemetry_v2_init(runtime_dir) != 0) {
 		*err_str = telemetry_log_error;
-		printf("Error initialising telemetry - %s", *err_str);
+		printf("Error initialising telemetry - %s\n", *err_str);
 		return -1;
 	}
 	if (telemetry_legacy_init(runtime_dir) != 0) {
 		*err_str = telemetry_log_error;
-		printf("No telemetry legacy support- %s", *err_str);
+		printf("No telemetry legacy support - %s\n", *err_str);
 	}
 	return 0;
 }
Signature · 1 line
2.23.0
author Applied
#2 lore raw
Quoted 5 lines · Bruce Richardson
Quoted 3 lines · David Marchand

Caught while running testpmd:
No telemetry legacy support- No legacy callbacks, legacy socket not createdInteractive-mode selected

Quoted 8 lines
Quoted 6 lines

Add missing \n.

Fixes 6dd571fd07c3 ("telemetry: introduce new functionality")

---

Applied, thanks.

Signature · 1 line
David Marchand