nfsd4: remove "client testing stateid" log spam
Subsystems (2)
PATCH 1/1 nfsd4: remove "client testing stateid" log spam
From: "J. Bruce Fields" <[email protected]>
I try not to log even buggy client behavior by default, as I'd rather not give malicious clients a way to spam the logs.
But this condition isn't even a sign of a buggy client--in recovery cases it's normal to test stateid's from a no-longer-active clientid.
I'd be open to dprintk's or tracing here if people think it's necessary. For now, just remove this.
Signed-off-by J. Bruce Fields <[email protected]>
--- fs/nfsd/nfs4state.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)
fs/nfsd/nfs4state.c +1 -8
@@ -5521,15 +5521,8 @@ static __be32 nfsd4_validate_stateid(struct nfs4_client *cl, stateid_t *stateid)if (ZERO_STATEID (stateid) ||ONE_STATEID (stateid) ||CLOSE_STATEID (stateid))return status; -/* Client debugging aid. */ -if (!same_clid (&stateid->si_opaque.so_clid, &cl->cl_clientid)) { -char addr_str[INET6_ADDRSTRLEN ]; -rpc_ntop ((struct sockaddr *)&cl->cl_addr, addr_str, -sizeof (addr_str)); -pr_warn_ratelimited ("NFSD: client %s testing state ID " -"with incorrect client ID\n" , addr_str); +if (!same_clid (&stateid->si_opaque.so_clid, &cl->cl_clientid))return status; - }spin_lock (&cl->cl_lock); s =find_stateid_locked (cl, stateid);if (!s)
Signature · 1 line
2.26.2