include: dt-bindings: rockchip: mark RK_GPIO defines as deprecated
Subsystems (3)
PATCH 1/1 include: dt-bindings: rockchip: mark RK_GPIO defines as deprecated
The defines RK_GPIO0, RK_GPIO1, RK_GPIO2, RK_GPIO3, RK_GPIO4 and RK_GPIO6 are no longer used. Mark them as "deprecated" to prevent that someone start using them again.
--- include/dt-bindings/pinctrl/rockchip.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
include/dt-bindings/pinctrl/rockchip.h +6 -6
@@ -9,12 +9,12 @@#ifndef __DT_BINDINGS_ROCKCHIP_PINCTRL_H__#define __DT_BINDINGS_ROCKCHIP_PINCTRL_H__ -#define RK_GPIO0 0 -#define RK_GPIO1 1 -#define RK_GPIO2 2 -#define RK_GPIO3 3 -#define RK_GPIO4 4 -#define RK_GPIO6 6 +#define RK_GPIO0 0/* deprecated */ +#define RK_GPIO1 1/* deprecated */ +#define RK_GPIO2 2/* deprecated */ +#define RK_GPIO3 3/* deprecated */ +#define RK_GPIO4 4/* deprecated */ +#define RK_GPIO6 6/* deprecated */ #define RK_PA0 0#define RK_PA1 1
Signature · 1 line
2.11.0
Rob Herring
maintainerQuoted 3 lines · Johan Jonker
The defines
RK_GPIO0,RK_GPIO1,RK_GPIO2,RK_GPIO3,RK_GPIO4andRK_GPIO6are no longer used. Mark them as "deprecated" to prevent that someone start using them again.
What changed exactly? The binding changed, or just using raw 0-6 instead of the defines?
If there's not anything using these in tree, just delete them.
It is still used in the binding doc.
Rob
Heiko Stübner
maintainerAm Montag, 11. Mai 2020, 23:36:05 CEST schrieb Rob Herring:
Quoted 7 lines · Johan Jonker
Quoted 3 lines
The defines
RK_GPIO0,RK_GPIO1,RK_GPIO2,RK_GPIO3,RK_GPIO4andRK_GPIO6are no longer used. Mark them as "deprecated" to prevent that someone start using them again.What changed exactly? The binding changed, or just using raw 0-6 instead of the defines?
This ... they are just dumb mappings of RK_GPIOx -> x so we switched over to just using the raw numbers, as the constants do not provide any additional information.
Quoted 1 line
If there's not anything using these in tree, just delete them.
Ok, good to know that we can just delete them if noone is using them anymore.
Quoted 1 line
It is still used in the binding doc.
I think Johan will provide a v2 with that.
Heiko