Skip to contentSkip to conversation

Solve a few issues with intel_pmic_chtdc_ti.c

PATCH In review Mauro Carvalho Chehab 5 participants 9 messages May 12, 2020 – May 18, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Solve a few issues with intel_pmic_chtdc_ti.c

While doing some tests with a device that I'm using to work with the atomisp driver (an Asus T101HA), I noticed some warnings produced by the i915 driver.

The first one is that building intel_pmic_chtdc_ti as a module is too late, as fbcon driver (and i915) will need it earlier.

The second one is that the thermal I2C OpRegion needed by the i915 is not registered.

Those patches address the issues I detected.

Mauro Carvalho Chehab (2):
ACPI / PMIC: Add i2c address for thermal control
mfd: Kconfig: change INTEL_SOC_PMIC_CHTDC_TI to bool

 drivers/acpi/pmic/intel_pmic_chtdc_ti.c | 1 +
 drivers/mfd/Kconfig                     | 6 +++++-
 2 files changed, 6 insertions(+), 1 deletion(-)
Signature · 1 line
2.26.2
#1 lore raw

PATCH 1/2 ACPI / PMIC: Add i2c address for thermal control

On Asus T101HA, we keep receiving those error messages:

	i915 0000:00:02.0: [drm] *ERROR* mipi_exec_pmic failed, error: -95
	intel_soc_pmic_exec_mipi_pmic_seq_element: Not implemented
	intel_soc_pmic_exec_mipi_pmic_seq_element: i2c-addr: 0x5e reg-addr 0x4b value 0x59 mask 0xff

Because the opregion is missing the I2C address.

---
 drivers/acpi/pmic/intel_pmic_chtdc_ti.c | 1 +
 1 file changed, 1 insertion(+)
drivers/acpi/pmic/intel_pmic_chtdc_ti.c +1 -0
index 7ccd7d9660bc..a5101b07611a 100644
@@ -102,6 +102,7 @@ static struct intel_pmic_opregion_data chtdc_ti_pmic_opregion_data = {
 	.power_table_count = ARRAY_SIZE(chtdc_ti_power_table),
 	.thermal_table = chtdc_ti_thermal_table,
 	.thermal_table_count = ARRAY_SIZE(chtdc_ti_thermal_table),
+	.pmic_i2c_address = 0x5e,
 };
 
 static int chtdc_ti_pmic_opregion_probe(struct platform_device *pdev)
Signature · 1 line
2.26.2
Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] ACPI / PMIC: Add i2c address for thermal control

Hi,

Quoted 10 lines · Mauro Carvalho Chehab

On Asus T101HA, we keep receiving those error messages:

	i915 0000:00:02.0: [drm] *ERROR* mipi_exec_pmic failed, error: -95
	intel_soc_pmic_exec_mipi_pmic_seq_element: Not implemented
	intel_soc_pmic_exec_mipi_pmic_seq_element: i2c-addr: 0x5e reg-addr 0x4b value 0x59 mask 0xff

Because the opregion is missing the I2C address.

Looks good to me:

Regards,

Hans

Quoted 17 lines
---
  drivers/acpi/pmic/intel_pmic_chtdc_ti.c | 1 +
  1 file changed, 1 insertion(+)
drivers/acpi/pmic/intel_pmic_chtdc_ti.c +1 -0
index 7ccd7d9660bc..a5101b07611a 100644
@@ -102,6 +102,7 @@ static struct intel_pmic_opregion_data chtdc_ti_pmic_opregion_data = {
  	.power_table_count = ARRAY_SIZE(chtdc_ti_power_table),
  	.thermal_table = chtdc_ti_thermal_table,
  	.thermal_table_count = ARRAY_SIZE(chtdc_ti_thermal_table),
+	.pmic_i2c_address = 0x5e,
  };
 
  static int chtdc_ti_pmic_opregion_probe(struct platform_device *pdev)
Reviewed-by on v1 1/2
#3 lore raw

Re: [PATCH 1/2] ACPI / PMIC: Add i2c address for thermal control

In reply to Mauro Carvalho Chehab
Quoted 10 lines · Mauro Carvalho Chehab

On Asus T101HA, we keep receiving those error messages:

	i915 0000:00:02.0: [drm] *ERROR* mipi_exec_pmic failed, error: -95
	intel_soc_pmic_exec_mipi_pmic_seq_element: Not implemented
	intel_soc_pmic_exec_mipi_pmic_seq_element: i2c-addr: 0x5e reg-addr 0x4b value 0x59 mask 0xff

Because the opregion is missing the I2C address.

Reviewed-by on v1 1/2
#4 lore raw

Re: [PATCH 1/2] ACPI / PMIC: Add i2c address for thermal control

In reply to Mauro Carvalho Chehab
Quoted 8 lines · Mauro Carvalho Chehab

On Asus T101HA, we keep receiving those error messages:

	i915 0000:00:02.0: [drm] *ERROR* mipi_exec_pmic failed, error: -95
	intel_soc_pmic_exec_mipi_pmic_seq_element: Not implemented
	intel_soc_pmic_exec_mipi_pmic_seq_element: i2c-addr: 0x5e reg-addr 0x4b value 0x59 mask 0xff

Because the opregion is missing the I2C address.

Quoted 21 lines
---
 drivers/acpi/pmic/intel_pmic_chtdc_ti.c | 1 +
 1 file changed, 1 insertion(+)
drivers/acpi/pmic/intel_pmic_chtdc_ti.c +1 -0
index 7ccd7d9660bc..a5101b07611a 100644
@@ -102,6 +102,7 @@ static struct intel_pmic_opregion_data chtdc_ti_pmic_opregion_data = {
 	.power_table_count = ARRAY_SIZE(chtdc_ti_power_table),
 	.thermal_table = chtdc_ti_thermal_table,
 	.thermal_table_count = ARRAY_SIZE(chtdc_ti_thermal_table),
+	.pmic_i2c_address = 0x5e,
 };
 
 static int chtdc_ti_pmic_opregion_probe(struct platform_device *pdev)
Signature · 1 line
2.26.2
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#5 lore raw

Re: [PATCH 1/2] ACPI / PMIC: Add i2c address for thermal control

In reply to Mauro Carvalho Chehab
Quoted 20 lines · Mauro Carvalho Chehab

On Asus T101HA, we keep receiving those error messages:

        i915 0000:00:02.0: [drm] *ERROR* mipi_exec_pmic failed, error: -95
        intel_soc_pmic_exec_mipi_pmic_seq_element: Not implemented
        intel_soc_pmic_exec_mipi_pmic_seq_element: i2c-addr: 0x5e reg-addr 0x4b value 0x59 mask 0xff

Because the opregion is missing the I2C address.

---
 drivers/acpi/pmic/intel_pmic_chtdc_ti.c | 1 +
 1 file changed, 1 insertion(+)
drivers/acpi/pmic/intel_pmic_chtdc_ti.c +0 -0
index 7ccd7d9660bc..a5101b07611a 100644

drivers/acpi/pmic/intel_pmic_chtdc_ti.c static struct intel_pmic_opregion_data chtdc_ti_pmic_opregion_data = {

Quoted 8 lines
drivers/acpi/pmic/intel_pmic_chtdc_ti.c +1 -1
@@ -102,6 +102,7 @@ static struct intel_pmic_opregion_data chtdc_ti_pmic_opregion_data = {
        .power_table_count = ARRAY_SIZE(chtdc_ti_power_table),
        .thermal_table = chtdc_ti_thermal_table,
        .thermal_table_count = ARRAY_SIZE(chtdc_ti_thermal_table),
+       .pmic_i2c_address = 0x5e,
 };
 
 static int chtdc_ti_pmic_opregion_probe(struct platform_device *pdev)
--

This appears to be part of a series, but the second patch has not been CCed to linux-acpi.

Can I assume that this one will be applied along with the [2/2] by another maintainer?

Thanks!

#6 lore raw

Re: [PATCH 1/2] ACPI / PMIC: Add i2c address for thermal control

Hi Rafael,

Quoted 28 lines · Rafael J. Wysocki
Quoted 26 lines · Mauro Carvalho Chehab

On Asus T101HA, we keep receiving those error messages:

         i915 0000:00:02.0: [drm] *ERROR* mipi_exec_pmic failed, error: -95
         intel_soc_pmic_exec_mipi_pmic_seq_element: Not implemented
         intel_soc_pmic_exec_mipi_pmic_seq_element: i2c-addr: 0x5e reg-addr 0x4b value 0x59 mask 0xff

Because the opregion is missing the I2C address.

---
  drivers/acpi/pmic/intel_pmic_chtdc_ti.c | 1 +
  1 file changed, 1 insertion(+)
drivers/acpi/pmic/intel_pmic_chtdc_ti.c +1 -0
index 7ccd7d9660bc..a5101b07611a 100644
@@ -102,6 +102,7 @@ static struct intel_pmic_opregion_data chtdc_ti_pmic_opregion_data = {
         .power_table_count = ARRAY_SIZE(chtdc_ti_power_table),
         .thermal_table = chtdc_ti_thermal_table,
         .thermal_table_count = ARRAY_SIZE(chtdc_ti_thermal_table),
+       .pmic_i2c_address = 0x5e,
  };
 
Quoted 5 lines

drivers/acpi/pmic/intel_pmic_chtdc_ti.c static struct intel_pmic_opregion_data chtdc_ti_pmic_opregion_data = {

Quoted 2 lines
drivers/acpi/pmic/intel_pmic_chtdc_ti.c +0 -1
  static int chtdc_ti_pmic_opregion_probe(struct platform_device *pdev)
--

This appears to be part of a series, but the second patch has not been CCed to linux-acpi.

Mauro send out 3 patches related to the PMIC, this one and 2 MFD patches. I think his intention was to send out this standalone and the 2 MFD patches as a series, but instead he send out this 1 + 1 MFD patch as a series and the other MFD patch as a standalone patch.

Either way this patch is a standalone patch, the 2/2 patch is almost completely unrelated, so if you can pick this one up, then that would be great.

Regards,

Hans

#7 lore raw

Re: [PATCH 1/2] ACPI / PMIC: Add i2c address for thermal control

Em Mon, 18 May 2020 09:22:53 +0200
Hans de Goede <[email protected]> escreveu:

Quoted 37 lines

Hi Rafael,

Quoted 28 lines · Rafael J. Wysocki
Quoted 26 lines · Mauro Carvalho Chehab

On Asus T101HA, we keep receiving those error messages:

         i915 0000:00:02.0: [drm] *ERROR* mipi_exec_pmic failed, error: -95
         intel_soc_pmic_exec_mipi_pmic_seq_element: Not implemented
         intel_soc_pmic_exec_mipi_pmic_seq_element: i2c-addr: 0x5e reg-addr 0x4b value 0x59 mask 0xff

Because the opregion is missing the I2C address.

---
  drivers/acpi/pmic/intel_pmic_chtdc_ti.c | 1 +
  1 file changed, 1 insertion(+)
drivers/acpi/pmic/intel_pmic_chtdc_ti.c +1 -0
index 7ccd7d9660bc..a5101b07611a 100644
@@ -102,6 +102,7 @@ static struct intel_pmic_opregion_data chtdc_ti_pmic_opregion_data = {
         .power_table_count = ARRAY_SIZE(chtdc_ti_power_table),
         .thermal_table = chtdc_ti_thermal_table,
         .thermal_table_count = ARRAY_SIZE(chtdc_ti_thermal_table),
+       .pmic_i2c_address = 0x5e,
  };
 
Quoted 5 lines

drivers/acpi/pmic/intel_pmic_chtdc_ti.c static struct intel_pmic_opregion_data chtdc_ti_pmic_opregion_data = { · line 108

Quoted 2 lines
drivers/acpi/pmic/intel_pmic_chtdc_ti.c +0 -0
  static int chtdc_ti_pmic_opregion_probe(struct platform_device *pdev)

This appears to be part of a series, but the second patch has not been CCed to linux-acpi.

Quoted 8 lines

Mauro send out 3 patches related to the PMIC, this one and 2 MFD patches. I think his intention was to send out this standalone and the 2 MFD patches as a series, but instead he send out this 1 + 1 MFD patch as a series and the other MFD patch as a standalone patch.

Either way this patch is a standalone patch, the 2/2 patch is almost completely unrelated, so if you can pick this one up, then that would be great.

Yeah, patch 2/2 is independent of this one. It touches only drivers/mfd/Kconfig, addressing a problem when building with INTEL_SOC_PMIC_CHTDC_TI=m.

The third patch for the MFD tree addresses similar issues with drivers that register an OpRegion, but won't work properly if compiled as module.

Please pick this one via your tree. The other two patches should probably go via MFD tree.

Thanks,
Mauro

#8 lore raw

Re: [PATCH 1/2] ACPI / PMIC: Add i2c address for thermal control

Quoted 50 lines · Mauro Carvalho Chehab

Em Mon, 18 May 2020 09:22:53 +0200
Hans de Goede <[email protected]> escreveu:

Quoted 37 lines

Hi Rafael,

Quoted 28 lines · Rafael J. Wysocki
Quoted 26 lines · Mauro Carvalho Chehab

On Asus T101HA, we keep receiving those error messages:

         i915 0000:00:02.0: [drm] *ERROR* mipi_exec_pmic failed, error: -95
         intel_soc_pmic_exec_mipi_pmic_seq_element: Not implemented
         intel_soc_pmic_exec_mipi_pmic_seq_element: i2c-addr: 0x5e reg-addr 0x4b value 0x59 mask 0xff

Because the opregion is missing the I2C address.

---
  drivers/acpi/pmic/intel_pmic_chtdc_ti.c | 1 +
  1 file changed, 1 insertion(+)
drivers/acpi/pmic/intel_pmic_chtdc_ti.c +1 -0
index 7ccd7d9660bc..a5101b07611a 100644
@@ -102,6 +102,7 @@ static struct intel_pmic_opregion_data chtdc_ti_pmic_opregion_data = {
         .power_table_count = ARRAY_SIZE(chtdc_ti_power_table),
         .thermal_table = chtdc_ti_thermal_table,
         .thermal_table_count = ARRAY_SIZE(chtdc_ti_thermal_table),
+       .pmic_i2c_address = 0x5e,
  };
 
Quoted 5 lines

drivers/acpi/pmic/intel_pmic_chtdc_ti.c static struct intel_pmic_opregion_data chtdc_ti_pmic_opregion_data = {

Quoted 2 lines
drivers/acpi/pmic/intel_pmic_chtdc_ti.c +0 -1
  static int chtdc_ti_pmic_opregion_probe(struct platform_device *pdev)
--

This appears to be part of a series, but the second patch has not been CCed to linux-acpi.

Quoted 8 lines

Mauro send out 3 patches related to the PMIC, this one and 2 MFD patches. I think his intention was to send out this standalone and the 2 MFD patches as a series, but instead he send out this 1 + 1 MFD patch as a series and the other MFD patch as a standalone patch.

Either way this patch is a standalone patch, the 2/2 patch is almost completely unrelated, so if you can pick this one up, then that would be great.

Quoted 7 lines

Yeah, patch 2/2 is independent of this one. It touches only drivers/mfd/Kconfig, addressing a problem when building with INTEL_SOC_PMIC_CHTDC_TI=m.

The third patch for the MFD tree addresses similar issues with drivers that register an OpRegion, but won't work properly if compiled as module.

Please pick this one via your tree.

OK, applied as 5.8 material, thanks!