Skip to contentSkip to conversation

brcmfmac: make non-global functions static

PATCH In review Chen Zhou 3 participants 3 messages May 8, 2020 – May 12, 2020

Subsystems (3)
lore
Share & tools
lore

Chen Zhou

author
#0 lore raw

PATCH 1/1 brcmfmac: make non-global functions static

Fix sparse warning:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2206:5:
warning: symbol 'brcmf_p2p_get_conn_idx' was not declared. Should it be static?

---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c +1 -1
index e32c24a2670d..2a2440031357 100644
@@ -2203,7 +2203,7 @@ static struct wireless_dev *brcmf_p2p_create_p2pdev(struct brcmf_p2p_info *p2p,
 	return ERR_PTR(err);
 }
 
-int brcmf_p2p_get_conn_idx(struct brcmf_cfg80211_info *cfg)
+static int brcmf_p2p_get_conn_idx(struct brcmf_cfg80211_info *cfg)
 {
 	int i;
 	struct brcmf_if *ifp = netdev_priv(cfg_to_ndev(cfg));
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw

Chen Zhou 於 5/8/2020 9:32 AM 寫道:

Quoted 6 lines

Fix sparse warning:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2206:5:
warning: symbol 'brcmf_p2p_get_conn_idx' was not declared. Should it be static?

Quoted 18 lines
---
  drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c +1 -1
index e32c24a2670d..2a2440031357 100644
@@ -2203,7 +2203,7 @@ static struct wireless_dev *brcmf_p2p_create_p2pdev(struct brcmf_p2p_info *p2p,
  	return ERR_PTR(err);
  }
 
-int brcmf_p2p_get_conn_idx(struct brcmf_cfg80211_info *cfg)
+static int brcmf_p2p_get_conn_idx(struct brcmf_cfg80211_info *cfg)
  {
  	int i;
  	struct brcmf_if *ifp = netdev_priv(cfg_to_ndev(cfg));
#2 lore raw
In reply to Chen Zhou
Quoted 7 lines · Chen Zhou

Fix sparse warning:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2206:5:
warning: symbol 'brcmf_p2p_get_conn_idx' was not declared. Should it be static?

Patch applied to wireless-drivers-next.git, thanks.

7294ee6f5642 brcmfmac: make non-global functions static

Signature · 3 lines
https://patchwork.kernel.org/patch/11535195/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches