READ_ONCE: Fix comment describing 2x32-bit atomicity
PATCH 1/1 READ_ONCE: Fix comment describing 2x32-bit atomicity
READ_ONCE() permits 64-bit accesses on 32-bit architectures, since this crops up in a few places and is generally harmless because either the upper bits are always zero (e.g. for a virtual address or 32-bit time_t) or the architecture provides 64-bit atomicity anyway.
Update the corresponding comment above compiletime_assert_rwonce_type(), which incorrectly states that 32-bit x86 provides 64-bit atomicity, and instead reference 32-bit Armv7 with LPAE.
---
Applies on top of the READ_ONCE() pile I sent last night (v5).
include/linux/compiler.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
include/linux/compiler.h +3 -3
@@ -384,9 +384,9 @@ static inline void *offset_to_ptr(const int *off)/* * Yes, this permits 64-bit accesses on 32-bit architectures. These will -* actually be atomic in many cases (namely x86), but for others we rely on -* the access being split into 2x32-bit accesses for a 32-bit quantity (e.g. -* a virtual address) and a strong prevailing wind. +* actually be atomic in some cases (namely Armv7 + LPAE), but for others we +* rely on the access being split into 2x32-bit accesses for a 32-bit quantity +* (e.g. a virtual address) and a strong prevailing wind. */ #define compiletime_assert_rwonce_type (t) \ compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
Signature · 1 line
2.26.2.645.ge9eca65c58-goog
The following commit has been merged into the locking/kcsan branch of tip:
The following commit has been merged into the locking/kcsan branch of tip:
Commit-ID: ffed638b6a2180da8fd002a46632d746af72b299 Gitweb: https://git.kernel.org/tip/ffed638b6a2180da8fd002a46632d746af72b299 Author: Will Deacon <[email protected]> AuthorDate: Tue, 12 May 2020 10:01:01 +01:00 Committer: Thomas Gleixner <[email protected]> CommitterDate: Wed, 13 May 2020 14:17:09 +02:00
READ_ONCE: Fix comment describing 2x32-bit atomicity
READ_ONCE() permits 64-bit accesses on 32-bit architectures, since this crops up in a few places and is generally harmless because either the upper bits are always zero (e.g. for a virtual address or 32-bit time_t) or the architecture provides 64-bit atomicity anyway.
Update the corresponding comment above compiletime_assert_rwonce_type(), which incorrectly states that 32-bit x86 provides 64-bit atomicity, and instead reference 32-bit Armv7 with LPAE.
--- include/linux/compiler.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
include/linux/compiler.h +3 -3
@@ -384,9 +384,9 @@ static inline void *offset_to_ptr(const int *off)/* * Yes, this permits 64-bit accesses on 32-bit architectures. These will -* actually be atomic in many cases (namely x86), but for others we rely on -* the access being split into 2x32-bit accesses for a 32-bit quantity (e.g. -* a virtual address) and a strong prevailing wind. +* actually be atomic in some cases (namely Armv7 + LPAE), but for others we +* rely on the access being split into 2x32-bit accesses for a 32-bit quantity +* (e.g. a virtual address) and a strong prevailing wind. */ #define compiletime_assert_rwonce_type (t) \ compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \