Skip to contentSkip to conversation

am65x_evm_r5: Disable serial output

RFC In review Tom Rini 2 participants 3 messages May 11, 2020 – May 12, 2020

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

RFC 1/1 am65x_evm_r5: Disable serial output

Given limitations on the current implementation of our test framework, having both am65x_evm_r5 and am65x_evm_a53 have serial output on the same port confuses the tests. If we disable serial output in r5 and disable the SPL tests as well, we can run the rest of the testsuite on am65x_evm_a53.

Cc Lokesh Vutla <[email protected]>

---
For practical reasons this depends on
http://patchwork.ozlabs.org/project/uboot/patch/20200507230810.21476-1-samuel at sholland.org/ to build. Since this also removes YMODEM support, I assume it breaks a functional use case, so I'm not sure this is best. Stephen Warren
suggested a rework to the pytest framework that I haven't had a chance
to try and do yet.

---
 configs/am65x_evm_r5_defconfig | 2 --
 1 file changed, 2 deletions(-)
configs/am65x_evm_r5_defconfig +0 -2
index 4fc199e80911..2c61bee4b8bc 100644
@@ -11,7 +11,6 @@ CONFIG_ENV_SIZE=0x20000
 CONFIG_SYS_SPI_U_BOOT_OFFS=0x80000
 CONFIG_DM_GPIO=y
 CONFIG_SPL_MMC_SUPPORT=y
-CONFIG_SPL_SERIAL_SUPPORT=y
 CONFIG_SPL_DRIVERS_MISC_SUPPORT=y
 CONFIG_SPL_STACK_R_ADDR=0x82000000
 CONFIG_NR_DRAM_BANKS=2
@@ -41,7 +40,6 @@ CONFIG_SPL_REMOTEPROC=y
 # CONFIG_SPL_SPI_FLASH_TINY is not set
 CONFIG_SPL_SPI_FLASH_SFDP_SUPPORT=y
 CONFIG_SPL_SPI_LOAD=y
-CONFIG_SPL_YMODEM_SUPPORT=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_BOOTZ=y
 CONFIG_CMD_ASKENV=y
Signature · 1 line
2.17.1
#1 lore raw

Hi Tom,

Quoted 6 lines · Tom Rini

Given limitations on the current implementation of our test framework, having both am65x_evm_r5 and am65x_evm_a53 have serial output on the same port confuses the tests. If we disable serial output in r5 and disable the SPL tests as well, we can run the rest of the testsuite on am65x_evm_a53.

Quoted 6 lines
Cc Lokesh Vutla <[email protected]>

---
For practical reasons this depends on
http://patchwork.ozlabs.org/project/uboot/patch/20200507230810.21476-1-samuel at sholland.org/ to build. Since this also removes YMODEM support, I assume it breaks a

Right this breaks UART boot which is very useful for remote testing of U-Boot. This cannot be compromised.

May be I am missing something, Can you explain what is the problem here?

Thanks and regards,
Lokesh

Quoted 28 lines

functional use case, so I'm not sure this is best. Stephen Warren suggested a rework to the pytest framework that I haven't had a chance to try and do yet.

---
 configs/am65x_evm_r5_defconfig | 2 --
 1 file changed, 2 deletions(-)
configs/am65x_evm_r5_defconfig +0 -2
index 4fc199e80911..2c61bee4b8bc 100644
@@ -11,7 +11,6 @@ CONFIG_ENV_SIZE=0x20000
 CONFIG_SYS_SPI_U_BOOT_OFFS=0x80000
 CONFIG_DM_GPIO=y
 CONFIG_SPL_MMC_SUPPORT=y
-CONFIG_SPL_SERIAL_SUPPORT=y
 CONFIG_SPL_DRIVERS_MISC_SUPPORT=y
 CONFIG_SPL_STACK_R_ADDR=0x82000000
 CONFIG_NR_DRAM_BANKS=2
@@ -41,7 +40,6 @@ CONFIG_SPL_REMOTEPROC=y
 # CONFIG_SPL_SPI_FLASH_TINY is not set
 CONFIG_SPL_SPI_FLASH_SFDP_SUPPORT=y
 CONFIG_SPL_SPI_LOAD=y
-CONFIG_SPL_YMODEM_SUPPORT=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_BOOTZ=y
 CONFIG_CMD_ASKENV=y
author
#2 lore raw
Quoted 16 lines · Lokesh Vutla

Hi Tom,

Quoted 6 lines · Tom Rini

Given limitations on the current implementation of our test framework, having both am65x_evm_r5 and am65x_evm_a53 have serial output on the same port confuses the tests. If we disable serial output in r5 and disable the SPL tests as well, we can run the rest of the testsuite on am65x_evm_a53.

Quoted 6 lines
Cc Lokesh Vutla <[email protected]>

---
For practical reasons this depends on
http://patchwork.ozlabs.org/project/uboot/patch/20200507230810.21476-1-samuel at sholland.org/ to build. Since this also removes YMODEM support, I assume it breaks a

Quoted 2 lines

Right this breaks UART boot which is very useful for remote testing of U-Boot. This cannot be compromised.

I figured you might be using that in the lab there (I've got a WiFi SD card for mine again).

Quoted 1 line

May be I am missing something, Can you explain what is the problem here?

See https://lists.denx.de/pipermail/u-boot/2020-May/410921.html

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200512/2119f7ff/attachment.sig>