ALSA: Replace zero-length array with flexible-array
PATCH 1/1 ALSA: Replace zero-length array with flexible-array
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99:
struct foo {
int stuff;
struct boo array[];
};By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by this change:
"Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1]
sizeof(flexible-array-member) triggers a warning because flexible array members have incomplete type[1]. There are some instances of code in which the sizeof operator is being incorrectly/erroneously applied to zero-length arrays and the result is zero. Such instances may be hiding some bugs. So, this work (flexible-array member conversions) will also help to get completely rid of those sorts of issues.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
--- include/sound/control.h | 2 +- include/sound/intel-nhlt.h | 6 +++--- sound/core/oss/pcm_plugin.h | 2 +- sound/usb/usx2y/usbusx2y.h | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-)
include/sound/control.h +1 -1
@@ -75,7 +75,7 @@ struct snd_kcontrol {unsigned long private_value;void *private_data;void (*private_free)(struct snd_kcontrol *kcontrol); -struct snd_kcontrol_volatile vd[0 ];/* volatile data */ +struct snd_kcontrol_volatile vd[];/* volatile data */ };#define snd_kcontrol (n) list_entry(n, struct snd_kcontrol, list)
include/sound/intel-nhlt.h +3 -3
@@ -50,7 +50,7 @@ enum nhlt_device_type {struct nhlt_specific_cfg {u32 size; -u8 caps[0 ]; +u8 caps[]; } __packed;struct nhlt_fmt_cfg {
@@ -60,7 +60,7 @@ struct nhlt_fmt_cfg {struct nhlt_fmt {u8 fmt_count; -struct nhlt_fmt_cfg fmt_config[0 ]; +struct nhlt_fmt_cfg fmt_config[]; } __packed;struct nhlt_endpoint {
@@ -80,7 +80,7 @@ struct nhlt_endpoint {struct nhlt_acpi_table {struct acpi_table_header header;u8 endpoint_count; -struct nhlt_endpoint desc[0 ]; +struct nhlt_endpoint desc[]; } __packed;struct nhlt_resource_desc {
sound/core/oss/pcm_plugin.h +1 -1
@@ -64,7 +64,7 @@ struct snd_pcm_plugin {char *buf;snd_pcm_uframes_t buf_frames;struct snd_pcm_plugin_channel *buf_channels; -char extra_data[0 ]; +char extra_data[]; }; int snd_pcm_plugin_build(struct snd_pcm_substream *handle,
sound/usb/usx2y/usbusx2y.h +1 -1
@@ -18,7 +18,7 @@ struct snd_usX2Y_AsyncSeq {struct snd_usX2Y_urbSeq {int submitted;int len; -struct urb *urb[0 ]; +struct urb *urb[]; };#include "usx2yhwdeppcm.h"
Takashi Iwai
AppliedQuoted 30 lines · Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99:
struct foo { int stuff; struct boo array[]; };By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by this change:
"Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1]
sizeof(flexible-array-member) triggers a warning because flexible array members have incomplete type[1]. There are some instances of code in which the sizeof operator is being incorrectly/erroneously applied to zero-length arrays and the result is zero. Such instances may be hiding some bugs. So, this work (flexible-array member conversions) will also help to get completely rid of those sorts of issues.
Quoted 7 lines
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit76497732932f("cxgb3/l2t: Fix undefined behaviour")Signed-off-by Gustavo A. R. Silva <[email protected]>
Thanks, applied now to for-next branch.
Takashi
Quoted 7 lines · Takashi Iwai
Quoted 2 lines · Gustavo A. R. Silva
Signed-off-by Gustavo A. R. Silva <[email protected]>Thanks, applied now to for-next branch.
Thanks, Takashi.
--
Gustavo