Skip to contentSkip to conversation

hwspinlock: Simplify Kconfig

PATCH Applied Ezequiel Garcia 5 participants 5 messages Apr 14, 2020 – May 13, 2020 Hardware spinlock core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwspinlock: Simplify Kconfig

Every hwspinlock driver is expected to depend on the hwspinlock core, so it's possible to simplify the Kconfig, factoring out the HWSPINLOCK dependency.

---
 drivers/hwspinlock/Kconfig | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/hwspinlock/Kconfig +4 -6
index 826a1054100d..32cd26352f38 100644
@@ -6,9 +6,10 @@
 menuconfig HWSPINLOCK
 	bool "Hardware Spinlock drivers"
 
+if HWSPINLOCK
+
 config HWSPINLOCK_OMAP
 	tristate "OMAP Hardware Spinlock device"
-	depends on HWSPINLOCK
 	depends on ARCH_OMAP4 || SOC_OMAP5 || SOC_DRA7XX || SOC_AM33XX || SOC_AM43XX || ARCH_K3 || COMPILE_TEST
 	help
 	  Say y here to support the OMAP Hardware Spinlock device (firstly
@@ -18,7 +19,6 @@ config HWSPINLOCK_OMAP
 
 config HWSPINLOCK_QCOM
 	tristate "Qualcomm Hardware Spinlock device"
-	depends on HWSPINLOCK
 	depends on ARCH_QCOM || COMPILE_TEST
 	select MFD_SYSCON
 	help
@@ -30,7 +30,6 @@ config HWSPINLOCK_QCOM
 
 config HWSPINLOCK_SIRF
 	tristate "SIRF Hardware Spinlock device"
-	depends on HWSPINLOCK
 	depends on ARCH_SIRF || COMPILE_TEST
 	help
 	  Say y here to support the SIRF Hardware Spinlock device, which
@@ -43,7 +42,6 @@ config HWSPINLOCK_SIRF
 config HWSPINLOCK_SPRD
 	tristate "SPRD Hardware Spinlock device"
 	depends on ARCH_SPRD || COMPILE_TEST
-	depends on HWSPINLOCK
 	help
 	  Say y here to support the SPRD Hardware Spinlock device.
 
@@ -52,7 +50,6 @@ config HWSPINLOCK_SPRD
 config HWSPINLOCK_STM32
 	tristate "STM32 Hardware Spinlock device"
 	depends on MACH_STM32MP157 || COMPILE_TEST
-	depends on HWSPINLOCK
 	help
 	  Say y here to support the STM32 Hardware Spinlock device.
 
@@ -60,7 +57,6 @@ config HWSPINLOCK_STM32
 
 config HSEM_U8500
 	tristate "STE Hardware Semaphore functionality"
-	depends on HWSPINLOCK
 	depends on ARCH_U8500 || COMPILE_TEST
 	help
 	  Say y here to support the STE Hardware Semaphore functionality, which
@@ -68,3 +64,5 @@ config HSEM_U8500
 	  SoC.
 
 	  If unsure, say N.
+
+endif # HWSPINLOCK
Signature · 1 line
2.26.0.rc2
reviewer Reviewed-by on v1 1/1
#1 lore raw

Hi Ezequiel,

Quoted 6 lines · Ezequiel Garcia

Every hwspinlock driver is expected to depend on the hwspinlock core, so it's possible to simplify the Kconfig, factoring out the HWSPINLOCK dependency.

Looks reasonable to me.

Quoted 69 lines
---
 drivers/hwspinlock/Kconfig | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/hwspinlock/Kconfig +4 -7
index 826a1054100d..32cd26352f38 100644
@@ -6,9 +6,10 @@
 menuconfig HWSPINLOCK
        bool "Hardware Spinlock drivers"
 
+if HWSPINLOCK
+
 config HWSPINLOCK_OMAP
        tristate "OMAP Hardware Spinlock device"
-       depends on HWSPINLOCK
        depends on ARCH_OMAP4 || SOC_OMAP5 || SOC_DRA7XX || SOC_AM33XX || SOC_AM43XX || ARCH_K3 || COMPILE_TEST
        help
          Say y here to support the OMAP Hardware Spinlock device (firstly
@@ -18,7 +19,6 @@ config HWSPINLOCK_OMAP
 
 config HWSPINLOCK_QCOM
        tristate "Qualcomm Hardware Spinlock device"
-       depends on HWSPINLOCK
        depends on ARCH_QCOM || COMPILE_TEST
        select MFD_SYSCON
        help
@@ -30,7 +30,6 @@ config HWSPINLOCK_QCOM
 
 config HWSPINLOCK_SIRF
        tristate "SIRF Hardware Spinlock device"
-       depends on HWSPINLOCK
        depends on ARCH_SIRF || COMPILE_TEST
        help
          Say y here to support the SIRF Hardware Spinlock device, which
@@ -43,7 +42,6 @@ config HWSPINLOCK_SIRF
 config HWSPINLOCK_SPRD
        tristate "SPRD Hardware Spinlock device"
        depends on ARCH_SPRD || COMPILE_TEST
-       depends on HWSPINLOCK
        help
          Say y here to support the SPRD Hardware Spinlock device.
 
@@ -52,7 +50,6 @@ config HWSPINLOCK_SPRD
 config HWSPINLOCK_STM32
        tristate "STM32 Hardware Spinlock device"
        depends on MACH_STM32MP157 || COMPILE_TEST
-       depends on HWSPINLOCK
        help
          Say y here to support the STM32 Hardware Spinlock device.
 
@@ -60,7 +57,6 @@ config HWSPINLOCK_STM32
 
 config HSEM_U8500
        tristate "STE Hardware Semaphore functionality"
-       depends on HWSPINLOCK
        depends on ARCH_U8500 || COMPILE_TEST
        help
          Say y here to support the STE Hardware Semaphore functionality, which
@@ -68,3 +64,5 @@ config HSEM_U8500
          SoC.
 
          If unsure, say N.
+
+endif # HWSPINLOCK
--

2.26.0.rc2

Signature · 1 line
Baolin Wang
#2 lore raw

Hello,

Quoted 5 lines · Baolin Wang

Hi Ezequiel,

Quoted 1 line · Ezequiel Garcia
Quoted 9 lines
Quoted 5 lines

Every hwspinlock driver is expected to depend on the hwspinlock core, so it's possible to simplify the Kconfig, factoring out the HWSPINLOCK dependency.

Looks reasonable to me.

Gentle ping.

Thanks!
Ezequiel

Quoted 73 lines
Quoted 67 lines
---
 drivers/hwspinlock/Kconfig | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/hwspinlock/Kconfig +4 -7
index 826a1054100d..32cd26352f38 100644
@@ -6,9 +6,10 @@
 menuconfig HWSPINLOCK
        bool "Hardware Spinlock drivers"
 
+if HWSPINLOCK
+
 config HWSPINLOCK_OMAP
        tristate "OMAP Hardware Spinlock device"
-       depends on HWSPINLOCK
        depends on ARCH_OMAP4 || SOC_OMAP5 || SOC_DRA7XX || SOC_AM33XX || SOC_AM43XX || ARCH_K3 || COMPILE_TEST
        help
          Say y here to support the OMAP Hardware Spinlock device (firstly
@@ -18,7 +19,6 @@ config HWSPINLOCK_OMAP
 
 config HWSPINLOCK_QCOM
        tristate "Qualcomm Hardware Spinlock device"
-       depends on HWSPINLOCK
        depends on ARCH_QCOM || COMPILE_TEST
        select MFD_SYSCON
        help
@@ -30,7 +30,6 @@ config HWSPINLOCK_QCOM
 
 config HWSPINLOCK_SIRF
        tristate "SIRF Hardware Spinlock device"
-       depends on HWSPINLOCK
        depends on ARCH_SIRF || COMPILE_TEST
        help
          Say y here to support the SIRF Hardware Spinlock device, which
@@ -43,7 +42,6 @@ config HWSPINLOCK_SIRF
 config HWSPINLOCK_SPRD
        tristate "SPRD Hardware Spinlock device"
        depends on ARCH_SPRD || COMPILE_TEST
-       depends on HWSPINLOCK
        help
          Say y here to support the SPRD Hardware Spinlock device.
 
@@ -52,7 +50,6 @@ config HWSPINLOCK_SPRD
 config HWSPINLOCK_STM32
        tristate "STM32 Hardware Spinlock device"
        depends on MACH_STM32MP157 || COMPILE_TEST
-       depends on HWSPINLOCK
        help
          Say y here to support the STM32 Hardware Spinlock device.
 
@@ -60,7 +57,6 @@ config HWSPINLOCK_STM32
 
 config HSEM_U8500
        tristate "STE Hardware Semaphore functionality"
-       depends on HWSPINLOCK
        depends on ARCH_U8500 || COMPILE_TEST
        help
          Say y here to support the STE Hardware Semaphore functionality, which
@@ -68,3 +64,5 @@ config HSEM_U8500
          SoC.
 
          If unsure, say N.
+
+endif # HWSPINLOCK
--
Quoted 2 lines

2.26.0.rc2

--
Baolin Wang

#3 lore raw
Quoted 12 lines · Ezequiel Garcia

Hello,

Quoted 9 lines · Baolin Wang

Hi Ezequiel,

Quoted 5 lines · Ezequiel Garcia

Every hwspinlock driver is expected to depend on the hwspinlock core, so it's possible to simplify the Kconfig, factoring out the HWSPINLOCK dependency.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Looks reasonable to me.

Gentle ping.

Applied.

Thanks,
Bjorn

Quoted 76 lines

Thanks!
Ezequiel

Quoted 73 lines
Quoted 67 lines
---
 drivers/hwspinlock/Kconfig | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/hwspinlock/Kconfig +4 -7
index 826a1054100d..32cd26352f38 100644
@@ -6,9 +6,10 @@
 menuconfig HWSPINLOCK
        bool "Hardware Spinlock drivers"
 
+if HWSPINLOCK
+
 config HWSPINLOCK_OMAP
        tristate "OMAP Hardware Spinlock device"
-       depends on HWSPINLOCK
        depends on ARCH_OMAP4 || SOC_OMAP5 || SOC_DRA7XX || SOC_AM33XX || SOC_AM43XX || ARCH_K3 || COMPILE_TEST
        help
          Say y here to support the OMAP Hardware Spinlock device (firstly
@@ -18,7 +19,6 @@ config HWSPINLOCK_OMAP
 
 config HWSPINLOCK_QCOM
        tristate "Qualcomm Hardware Spinlock device"
-       depends on HWSPINLOCK
        depends on ARCH_QCOM || COMPILE_TEST
        select MFD_SYSCON
        help
@@ -30,7 +30,6 @@ config HWSPINLOCK_QCOM
 
 config HWSPINLOCK_SIRF
        tristate "SIRF Hardware Spinlock device"
-       depends on HWSPINLOCK
        depends on ARCH_SIRF || COMPILE_TEST
        help
          Say y here to support the SIRF Hardware Spinlock device, which
@@ -43,7 +42,6 @@ config HWSPINLOCK_SIRF
 config HWSPINLOCK_SPRD
        tristate "SPRD Hardware Spinlock device"
        depends on ARCH_SPRD || COMPILE_TEST
-       depends on HWSPINLOCK
        help
          Say y here to support the SPRD Hardware Spinlock device.
 
@@ -52,7 +50,6 @@ config HWSPINLOCK_SPRD
 config HWSPINLOCK_STM32
        tristate "STM32 Hardware Spinlock device"
        depends on MACH_STM32MP157 || COMPILE_TEST
-       depends on HWSPINLOCK
        help
          Say y here to support the STM32 Hardware Spinlock device.
 
@@ -60,7 +57,6 @@ config HWSPINLOCK_STM32
 
 config HSEM_U8500
        tristate "STE Hardware Semaphore functionality"
-       depends on HWSPINLOCK
        depends on ARCH_U8500 || COMPILE_TEST
        help
          Say y here to support the STE Hardware Semaphore functionality, which
@@ -68,3 +64,5 @@ config HSEM_U8500
          SoC.
 
          If unsure, say N.
+
+endif # HWSPINLOCK
--
Quoted 2 lines

2.26.0.rc2

--
Baolin Wang

#4 lore raw
In reply to Ezequiel Garcia
This patch was applied to andersson/remoteproc.git (refs/heads/for-next).

Hello:

This patch was applied to andersson/remoteproc.git (refs/heads/for-next).

Quoted 8 lines · On Tue, 14 Apr 2020 19:09:43 -0300 you wrote:

Every hwspinlock driver is expected to depend on the hwspinlock core, so it's possible to simplify the Kconfig, factoring out the HWSPINLOCK dependency.

---
 drivers/hwspinlock/Kconfig | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

Here is a summary with links:
- hwspinlock: Simplify Kconfig

    https://git.kernel.org/andersson/remoteproc/c/7521f04dba1b6d36e069f8ea0c08a7e89dba7b50

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/pwbot