Skip to contentSkip to conversation

package/apcupsd: fix missing __exchange_and_add symbol

PATCH New James Hilliard 3 participants 8 messages May 13, 2020 – Apr 19, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/apcupsd: fix missing __exchange_and_add symbol

It seems libsupc++.a is missing __exchange_and_add for uclibc on some platforms so link with libstdc++ as well on sparc and arcle.

Fixes:
http://autobuild.buildroot.net/results/bb9/bb96f327d5343a3561ea978f480585b418ce52e1/build-end.log
http://autobuild.buildroot.net/results/5a5/5a513669b0e56f38418e42d9ae733554fe6c73f1/build-end.log

---
 package/apcupsd/apcupsd.mk | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
package/apcupsd/apcupsd.mk +9 -1
index 410bce9aec..6088a41cc3 100644
@@ -14,10 +14,18 @@ ifneq ($(BR2_PACKAGE_APCUPSD_MODBUS_USB)$(BR2_PACKAGE_APCUPSD_USB),)
 APCUPSD_CONF_ENV += ac_cv_path_usbcfg=$(STAGING_DIR)/usr/bin/libusb-config
 ifeq ($(BR2_STATIC_LIBS),y)
 APCUPSD_DEPENDENCIES += host-pkgconf
-APCUPSD_CONF_ENV += LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs libusb`"
+APCUPSD_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs libusb`
 endif
 endif
 
+ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
+# __exchange_and_add symbol is missing from libsupc++ on these platforms
+ifeq ($(BR2_sparc)$(BR2_arcle),y)
+APCUPSD_LIBS += -lstdc++
+endif
+endif
+APCUPSD_CONF_ENV += LIBS+="$(APCUPSD_LIBS)"
+
 ifeq ($(BR2_PACKAGE_APCUPSD_APCSMART),y)
 APCUPSD_CONF_OPTS += --enable-apcsmart
 else
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/apcupsd: fix missing __exchange_and_add symbol

Quoted 22 lines · On Wed, 13 May 2020 01:35:37 -0600 James Hilliard <[email protected]>…

It seems libsupc++.a is missing __exchange_and_add for uclibc on some platforms so link with libstdc++ as well on sparc and arcle.

Fixes:
http://autobuild.buildroot.net/results/bb9/bb96f327d5343a3561ea978f480585b418ce52e1/build-end.log
http://autobuild.buildroot.net/results/5a5/5a513669b0e56f38418e42d9ae733554fe6c73f1/build-end.log

---
 package/apcupsd/apcupsd.mk | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
package/apcupsd/apcupsd.mk +1 -1
index 410bce9aec..6088a41cc3 100644
@@ -14,10 +14,18 @@ ifneq ($(BR2_PACKAGE_APCUPSD_MODBUS_USB)$(BR2_PACKAGE_APCUPSD_USB),)
 APCUPSD_CONF_ENV += ac_cv_path_usbcfg=$(STAGING_DIR)/usr/bin/libusb-config
 ifeq ($(BR2_STATIC_LIBS),y)
 APCUPSD_DEPENDENCIES += host-pkgconf
-APCUPSD_CONF_ENV += LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs libusb`"
+APCUPSD_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs libusb`

package/apcupsd/apcupsd.mk ifneq ($(BR2_PACKAGE_APCUPSD_MODBUS_USB)$(BR2_PACKAGE_APCUPSD_USB),) · line 27

Quoted 10 lines
package/apcupsd/apcupsd.mk +7 -0
 endif
 endif
 
+ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
+# __exchange_and_add symbol is missing from libsupc++ on these platforms
+ifeq ($(BR2_sparc)$(BR2_arcle),y)
+APCUPSD_LIBS += -lstdc++
+endif
+endif
+APCUPSD_CONF_ENV += LIBS+="$(APCUPSD_LIBS)"

Meh. We really want to fix that in uClibc, if it's a uClibc issue.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/apcupsd: fix missing __exchange_and_add symbol

Quoted 29 lines · Thomas Petazzoni
Quoted 25 lines · On Wed, 13 May 2020 01:35:37 -0600 James Hilliard <[email protected]>…

It seems libsupc++.a is missing __exchange_and_add for uclibc on some platforms so link with libstdc++ as well on sparc and arcle.

Fixes:
http://autobuild.buildroot.net/results/bb9/bb96f327d5343a3561ea978f480585b418ce52e1/build-end.log
http://autobuild.buildroot.net/results/5a5/5a513669b0e56f38418e42d9ae733554fe6c73f1/build-end.log

---
 package/apcupsd/apcupsd.mk | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
package/apcupsd/apcupsd.mk +1 -1
index 410bce9aec..6088a41cc3 100644
@@ -14,10 +14,18 @@ ifneq ($(BR2_PACKAGE_APCUPSD_MODBUS_USB)$(BR2_PACKAGE_APCUPSD_USB),)
 APCUPSD_CONF_ENV += ac_cv_path_usbcfg=$(STAGING_DIR)/usr/bin/libusb-config
 ifeq ($(BR2_STATIC_LIBS),y)
 APCUPSD_DEPENDENCIES += host-pkgconf
-APCUPSD_CONF_ENV += LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs libusb`"
+APCUPSD_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs libusb`
 endif
 endif
 
Quoted 9 lines

package/apcupsd/apcupsd.mk ifneq ($(BR2_PACKAGE_APCUPSD_MODBUS_USB)$(BR2_PACKAGE_APCUPSD_USB),) · line 27

Quoted 7 lines
package/apcupsd/apcupsd.mk +7 -0
+ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
+# __exchange_and_add symbol is missing from libsupc++ on these platforms
+ifeq ($(BR2_sparc)$(BR2_arcle),y)
+APCUPSD_LIBS += -lstdc++
+endif
+endif
+APCUPSD_CONF_ENV += LIBS+="$(APCUPSD_LIBS)"

Meh. We really want to fix that in uClibc, if it's a uClibc issue.

Well no idea if it's a bug in uClibc but the failures seem to be limited to builds
using uClibc. The libsupc++.a library appears to be originating from gcc, I don't
really know why this issues seems to be specific to uClibc and those 2 archs.

Quoted 6 lines

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

#3 lore raw

PATCH 1/1 package/apcupsd: fix missing __exchange_and_add symbol

James, All,

On 2020-05-13 03:43 -0600, James Hilliard spake thusly:

Quoted 6 lines
Quoted 4 lines · Thomas Petazzoni
Quoted 2 lines · On Wed, 13 May 2020 01:35:37 -0600 James Hilliard <[email protected]>…

It seems libsupc++.a is missing __exchange_and_add for uclibc on some platforms so link with libstdc++ as well on sparc and arcle.

[--SNIP--]

Quoted 6 lines
Quoted 1 line

Meh. We really want to fix that in uClibc, if it's a uClibc issue.

Well no idea if it's a bug in uClibc but the failures seem to be limited to builds
using uClibc. The libsupc++.a library appears to be originating from gcc, I don't
really know why this issues seems to be specific to uClibc and those 2 archs.

Pleas see the reply I wrote to another similar patch:

    http://lists.busybox.net/pipermail/buildroot/2020-August/289411.html

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH 1/1 package/apcupsd: fix missing __exchange_and_add symbol

Quoted 11 lines · Yann E. MORIN

James, All,

On 2020-05-13 03:43 -0600, James Hilliard spake thusly:

Quoted 6 lines
Quoted 4 lines · Thomas Petazzoni
Quoted 2 lines · On Wed, 13 May 2020 01:35:37 -0600 James Hilliard <[email protected]>…

It seems libsupc++.a is missing __exchange_and_add for uclibc on some platforms so link with libstdc++ as well on sparc and arcle.

[--SNIP--]

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

Meh. We really want to fix that in uClibc, if it's a uClibc issue.

Well no idea if it's a bug in uClibc but the failures seem to be limited to builds
using uClibc. The libsupc++.a library appears to be originating from gcc, I don't
really know why this issues seems to be specific to uClibc and those 2 archs.

Pleas see the reply I wrote to another similar patch:

Not sure if that's really getting at the real issue, I found this which seems likely to be related to the root cause of the failure:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70560

Quoted 13 lines
    http://lists.busybox.net/pipermail/buildroot/2020-August/289411.html

Regards,
Yann E. MORIN.

--
.-----------------.--------------------.------------------.--------------------.

|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |

'------------------------------^-------^------------------^--------------------'

#5 lore raw

PATCH 1/1 package/apcupsd: fix missing __exchange_and_add symbol

Quoted 20 lines · James Hilliard
Quoted 18 lines · Yann E. MORIN

James, All,

On 2020-05-13 03:43 -0600, James Hilliard spake thusly:

Quoted 6 lines
Quoted 4 lines · Thomas Petazzoni
Quoted 2 lines · On Wed, 13 May 2020 01:35:37 -0600 James Hilliard <[email protected]>…

It seems libsupc++.a is missing __exchange_and_add for uclibc on some platforms so link with libstdc++ as well on sparc and arcle.

[--SNIP--]

Quoted 6 lines
Quoted 1 line

Meh. We really want to fix that in uClibc, if it's a uClibc issue.

Well no idea if it's a bug in uClibc but the failures seem to be limited to builds
using uClibc. The libsupc++.a library appears to be originating from gcc, I don't
really know why this issues seems to be specific to uClibc and those 2 archs.

Quoted 4 lines
Quoted 1 line

Pleas see the reply I wrote to another similar patch:

Not sure if that's really getting at the real issue, I found this which seems likely to be related to the root cause of the failure:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70560

Looks like this is confirmed to be a gcc/libstdc++ bug, see here for details:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96657

Quoted 13 lines
Quoted 13 lines
    http://lists.busybox.net/pipermail/buildroot/2020-August/289411.html

Regards,
Yann E. MORIN.

--
.-----------------.--------------------.------------------.--------------------.

|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |

'------------------------------^-------^------------------^--------------------'

#6 lore raw

PATCH 1/1 package/apcupsd: fix missing __exchange_and_add symbol

Upstream gcc fix: https://gcc.gnu.org/g:6c0c7fc6236470a533675cd3cd1ebb1cc3dd112c

Quoted 42 lines · James Hilliard
Quoted 20 lines · James Hilliard
Quoted 18 lines · Yann E. MORIN

James, All,

On 2020-05-13 03:43 -0600, James Hilliard spake thusly:

Quoted 6 lines
Quoted 4 lines · Thomas Petazzoni
Quoted 2 lines · On Wed, 13 May 2020 01:35:37 -0600 James Hilliard <[email protected]>…

It seems libsupc++.a is missing __exchange_and_add for uclibc on some platforms so link with libstdc++ as well on sparc and arcle.

[--SNIP--]

Quoted 6 lines
Quoted 1 line

Meh. We really want to fix that in uClibc, if it's a uClibc issue.

Well no idea if it's a bug in uClibc but the failures seem to be limited to builds
using uClibc. The libsupc++.a library appears to be originating from gcc, I don't
really know why this issues seems to be specific to uClibc and those 2 archs.

Quoted 4 lines
Quoted 1 line

Pleas see the reply I wrote to another similar patch:

Not sure if that's really getting at the real issue, I found this which seems likely to be related to the root cause of the failure:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70560

Looks like this is confirmed to be a gcc/libstdc++ bug, see here for details:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96657

Quoted 13 lines
Quoted 13 lines
    http://lists.busybox.net/pipermail/buildroot/2020-August/289411.html

Regards,
Yann E. MORIN.

--
.-----------------.--------------------.------------------.--------------------.

|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |

'------------------------------^-------^------------------^--------------------'

#7 lore raw

PATCH 1/1 package/apcupsd: fix missing __exchange_and_add symbol

In reply to James Hilliard

Dear ARC maintainers,

Could you have a look at the below issue ? It seems really odd that just ARC and Sparc have this issue. I'd like to understand better before linking manually with libstdc++. I'm sure your toolchain experts will be able to shed some useful light on this weird issue.

Thanks a lot for your help,

Thomas

Quoted 36 lines · On Wed, 13 May 2020 01:35:37 -0600 James Hilliard <[email protected]>…

It seems libsupc++.a is missing __exchange_and_add for uclibc on some platforms so link with libstdc++ as well on sparc and arcle.

Fixes:
http://autobuild.buildroot.net/results/bb9/bb96f327d5343a3561ea978f480585b418ce52e1/build-end.log
http://autobuild.buildroot.net/results/5a5/5a513669b0e56f38418e42d9ae733554fe6c73f1/build-end.log

---
 package/apcupsd/apcupsd.mk | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
package/apcupsd/apcupsd.mk +9 -1
index 410bce9aec..6088a41cc3 100644
@@ -14,10 +14,18 @@ ifneq ($(BR2_PACKAGE_APCUPSD_MODBUS_USB)$(BR2_PACKAGE_APCUPSD_USB),)
 APCUPSD_CONF_ENV += ac_cv_path_usbcfg=$(STAGING_DIR)/usr/bin/libusb-config
 ifeq ($(BR2_STATIC_LIBS),y)
 APCUPSD_DEPENDENCIES += host-pkgconf
-APCUPSD_CONF_ENV += LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs libusb`"
+APCUPSD_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs libusb`
 endif
 endif
 
+ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
+# __exchange_and_add symbol is missing from libsupc++ on these platforms
+ifeq ($(BR2_sparc)$(BR2_arcle),y)
+APCUPSD_LIBS += -lstdc++
+endif
+endif
+APCUPSD_CONF_ENV += LIBS+="$(APCUPSD_LIBS)"
+
 ifeq ($(BR2_PACKAGE_APCUPSD_APCSMART),y)
 APCUPSD_CONF_OPTS += --enable-apcsmart
 else
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com