Skip to contentSkip to conversation

rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY

PATCH Superseded Corentin Labbe 3 participants 4 messages May 13, 2020 – May 15, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY

As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c9 at arm.com/T/ the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY.
Without it, booting with an initrd fail.

---
Changes since v1:
- added fix for rpi_4_32b_defconfig

 configs/rpi_4_32b_defconfig | 2 +-
 configs/rpi_4_defconfig     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
configs/rpi_4_32b_defconfig +1 -1
index 8d262d89b4..f2a975891c 100644
@@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000
 CONFIG_NR_DRAM_BANKS=2
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_OF_BOARD_SETUP=y
-# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set
+CONFIG_ARCH_FIXUP_FDT_MEMORY=y
 CONFIG_MISC_INIT_R=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
configs/rpi_4_defconfig +1 -1
index 2a0cea4222..f1c8f5ef7d 100644
@@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000
 CONFIG_NR_DRAM_BANKS=2
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_OF_BOARD_SETUP=y
-# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set
+CONFIG_ARCH_FIXUP_FDT_MEMORY=y
 CONFIG_MISC_INIT_R=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
Signature · 1 line
2.26.2
#1 lore raw

PATCH v2 1/1 rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY

Quoted 4 lines · Corentin Labbe

As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c9 at arm.com/T/ the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY.
Without it, booting with an initrd fail.

Quoted 9 lines

---
Changes since v1:
- added fix for rpi_4_32b_defconfig

 configs/rpi_4_32b_defconfig | 2 +-
 configs/rpi_4_defconfig     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Any reason why you don't added rpi_arm64_defconfig?

Regards,
Matthias

Quoted 27 lines
configs/rpi_4_32b_defconfig +1 -1
index 8d262d89b4..f2a975891c 100644
@@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000
 CONFIG_NR_DRAM_BANKS=2
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_OF_BOARD_SETUP=y
-# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set
+CONFIG_ARCH_FIXUP_FDT_MEMORY=y
 CONFIG_MISC_INIT_R=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
configs/rpi_4_defconfig +1 -1
index 2a0cea4222..f1c8f5ef7d 100644
@@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000
 CONFIG_NR_DRAM_BANKS=2
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_OF_BOARD_SETUP=y
-# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set
+CONFIG_ARCH_FIXUP_FDT_MEMORY=y
 CONFIG_MISC_INIT_R=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
#2 lore raw

PATCH v2 1/1 rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY

Quoted 12 lines · Matthias Brugger
Quoted 9 lines · Corentin Labbe

As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c9 at arm.com/T/ the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY.
Without it, booting with an initrd fail.

---
Changes since v1:
- added fix for rpi_4_32b_defconfig

Quoted 7 lines
Quoted 4 lines
 configs/rpi_4_32b_defconfig | 2 +-
 configs/rpi_4_defconfig     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Any reason why you don't added rpi_arm64_defconfig?

I didnt see rpi4 in its name so out of context of my changes.
I believe it is a common defconfig for all rpis, in that case touching it need more testing. So I propose to apply the change for rpi4 which are tested now.
And later I could try to test rpi_arm64_defconfig on rpi4 AND other rpis..

Quoted 28 lines
Quoted 28 lines
configs/rpi_4_32b_defconfig +1 -1
index 8d262d89b4..f2a975891c 100644
@@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000
 CONFIG_NR_DRAM_BANKS=2
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_OF_BOARD_SETUP=y
-# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set
+CONFIG_ARCH_FIXUP_FDT_MEMORY=y
 CONFIG_MISC_INIT_R=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
configs/rpi_4_defconfig +1 -1
index 2a0cea4222..f1c8f5ef7d 100644
@@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000
 CONFIG_NR_DRAM_BANKS=2
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_OF_BOARD_SETUP=y
-# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set
+CONFIG_ARCH_FIXUP_FDT_MEMORY=y
 CONFIG_MISC_INIT_R=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
#3 lore raw

PATCH v2 1/1 rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY

In reply to Corentin Labbe
Quoted 5 lines · Corentin Labbe

As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c9 at arm.com/T/ the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY.
Without it, booting with an initrd fail.

Best Regards,
Jaehoon Chung

Quoted 35 lines

---
Changes since v1:
- added fix for rpi_4_32b_defconfig

 configs/rpi_4_32b_defconfig | 2 +-
 configs/rpi_4_defconfig     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
configs/rpi_4_32b_defconfig +1 -1
index 8d262d89b4..f2a975891c 100644
@@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000
 CONFIG_NR_DRAM_BANKS=2
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_OF_BOARD_SETUP=y
-# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set
+CONFIG_ARCH_FIXUP_FDT_MEMORY=y
 CONFIG_MISC_INIT_R=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
configs/rpi_4_defconfig +1 -1
index 2a0cea4222..f1c8f5ef7d 100644
@@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000
 CONFIG_NR_DRAM_BANKS=2
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_OF_BOARD_SETUP=y
-# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set
+CONFIG_ARCH_FIXUP_FDT_MEMORY=y
 CONFIG_MISC_INIT_R=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set