net: ignore sock_from_file errors in __scm_install_fd
Subsystems (3)
PATCH 1/1 net: ignore sock_from_file errors in __scm_install_fd
The code had historically been ignoring these errors, and my recent refactoring changed that, which broke ssh in some setups.
--- net/core/scm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/core/scm.c +1 -1
@@ -307,7 +307,7 @@ static int __scm_install_fd(struct file *file, int __user *ufd, int o_flags)sock_update_classid (&sock->sk->sk_cgrp_data); }fd_install (new_fd,get_file (file)); -return error; +return 0 ; }static int scm_max_fds (struct msghdr *msg)
Signature · 1 line
2.26.2
Quoted 6 lines · Christoph Hellwig
The code had historically been ignoring these errors, and my recent refactoring changed that, which broke ssh in some setups.
Fixes 2618d530dd8b ("net/scm: cleanup scm_detach_fds")Reported-by Ido Schimmel <[email protected]>Signed-off-by Christoph Hellwig <[email protected]>
Thanks, Christoph.
Quoted 8 lines
Subject: [PATCH] net: ignore
sock_from_fileerrors in__scm_install_fdThe code had historically been ignoring these errors, and my recent refactoring changed that, which broke ssh in some setups.
Fixes 2618d530dd8b ("net/scm: cleanup scm_detach_fds")Reported-by Ido Schimmel <[email protected]>Signed-off-by Christoph Hellwig <[email protected]>
Thanks, I was wondering why my ssh was not working anymore.
From: Christoph Hellwig <[email protected]>
Date: Wed, 13 May 2020 13:07:59 +0200
Quoted 6 lines
The code had historically been ignoring these errors, and my recent refactoring changed that, which broke ssh in some setups.
Fixes 2618d530dd8b ("net/scm: cleanup scm_detach_fds")Reported-by Ido Schimmel <[email protected]>Signed-off-by Christoph Hellwig <[email protected]>
Applied, please put something like "[PATCH net-next]" in the Subject line next time.
Thank you.