blktrace: Report pid with note messages
Subsystems (2)
PATCH 1/1 blktrace: Report pid with note messages
Currently informational messages within block trace do not have PID information of the process reporting the message included. With BFQ it is sometimes useful to have the information and there's no good reason to omit the information from the trace. So just fill in pid information when generating note message.
--- kernel/trace/blktrace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/trace/blktrace.c +2 -2
@@ -170,10 +170,10 @@ void __trace_note_message(struct blk_trace *bt, struct blkcg *blkcg,if (!(blk_tracer_flags.val &TRACE_BLK_OPT_CGROUP )) blkcg =NULL ;#ifdef CONFIG_BLK_CGROUP -trace_note (bt,0 ,BLK_TN_MESSAGE , buf, n, +trace_note (bt, current->pid,BLK_TN_MESSAGE , buf, n, blkcg ?cgroup_id (blkcg->css.cgroup) :1 );#else -trace_note (bt,0 ,BLK_TN_MESSAGE , buf, n,0 ); +trace_note (bt, current->pid,BLK_TN_MESSAGE , buf, n,0 );#endif local_irq_restore (flags); }
Signature · 1 line
2.16.4
Quoted 10 lines
Il giorno 13 mag 2020, alle ore 18:02, Jan Kara <[email protected]> ha scritto:
Currently informational messages within block trace do not have PID information of the process reporting the message included. With BFQ it is sometimes useful to have the information and there's no good reason to omit the information from the trace. So just fill in pid information when generating note message.
Thank you!
Paolo
Quoted 25 lines
Signed-off-by Jan Kara <[email protected]>---
kernel/trace/blktrace.c| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)kernel/trace/blktrace.c +2
-2@@ -170,10 +170,10 @@ void __trace_note_message(struct blk_trace *bt, struct blkcg *blkcg,if (!(blk_tracer_flags.val &TRACE_BLK_OPT_CGROUP )) blkcg =NULL ;#ifdef CONFIG_BLK_CGROUP -trace_note (bt,0 ,BLK_TN_MESSAGE , buf, n, +trace_note (bt, current->pid,BLK_TN_MESSAGE , buf, n, blkcg ?cgroup_id (blkcg->css.cgroup) :1 );#else -trace_note (bt,0 ,BLK_TN_MESSAGE , buf, n,0 ); +trace_note (bt, current->pid,BLK_TN_MESSAGE , buf, n,0 );#endif local_irq_restore (flags); }Signature · 1 line
2.16.4
Quoted 7 lines · Jan Kara
Currently informational messages within block trace do not have PID information of the process reporting the message included. With BFQ it is sometimes useful to have the information and there's no good reason to omit the information from the trace. So just fill in pid information when generating note message.
Signed-off-by Jan Kara<[email protected]>
Looks good.
Quoted 5 lines · Jan Kara
Currently informational messages within block trace do not have PID information of the process reporting the message included. With BFQ it is sometimes useful to have the information and there's no good reason to omit the information from the trace. So just fill in pid information when generating note message.
Applied, thanks.
Signature · 1 line
Jens Axboe