Skip to contentSkip to conversation

build: disable gcc 10 zero-length-bounds warning

PATCH Applied Kevin Traynor 2 participants 4 messages May 14, 2020 – May 18, 2020 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 build: disable gcc 10 zero-length-bounds warning

gcc 10 issues warnings about the use of rearm_data marker from struct rte_mbuf.

e.g.
../drivers/net/enic/enic_rxtx_vec_avx2.c: In function ‘rx_one’:
../drivers/net/enic/enic_rxtx_vec_avx2.c:21:2:
warning:
array subscript 0 is outside the bounds of an interior zero-length array ‘RTE_MARKER64’ {aka ‘long unsigned int[0]’} [-Wzero-length-bounds]

   21 |  *(uint64_t *)&mb->rearm_data = enic->mbuf_initializer;
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../lib/librte_mbuf/rte_mbuf.h:45,
                 from ../drivers/net/enic/enic_rxtx_vec_avx2.c:6:
../lib/librte_mbuf/rte_mbuf_core.h:484:15:
note: while referencing ‘rearm_data’
  484 |  RTE_MARKER64 rearm_data;
      |

Disable this warning for gcc 10 in order to allow v20.05 to build without changes to struct rte_mbuf.

Bugzilla ID: 396
Cc: [email protected]

---
Sending as per discussion at this mornings release meeting:
http://inbox.dpdk.org/dev/[email protected]/

Reference to Gavin's patch:
http://inbox.dpdk.org/dev/CAJFAV8yL2GvEJtTXOLk6o0eXHi4CpZmqCoRsfN2WcDe_ju1C8A@mail.gmail.com/#t

---
 config/meson.build           | 4 ++++
 mk/toolchain/gcc/rte.vars.mk | 5 +++++
 2 files changed, 9 insertions(+)
config/meson.build +4 -0
index a1c38c053..43ab11310 100644
@@ -209,4 +209,8 @@ warning_flags = [
 	'-Wno-missing-field-initializers'
 ]
+if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0')
+# FIXME: Bugzilla 396
+	warning_flags += '-Wno-zero-length-bounds'
+endif
 if not dpdk_conf.get('RTE_ARCH_64')
 # for 32-bit, don't warn about casting a 32-bit pointer to 64-bit int - it's fine!!
mk/toolchain/gcc/rte.vars.mk +5 -0
index f19305e49..928f0e083 100644
@@ -82,4 +82,9 @@ WERROR_FLAGS += -Wno-uninitialized
 endif
 
+ifeq ($(shell test $(GCC_VERSION) -ge 100 && echo 1), 1)
+# FIXME: Bugzilla 396
+WERROR_FLAGS += -Wno-zero-length-bounds
+endif
+
 HOST_WERROR_FLAGS := $(WERROR_FLAGS)
 
Signature · 1 line
2.21.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 66 lines · Kevin Traynor

gcc 10 issues warnings about the use of rearm_data marker from struct rte_mbuf.

e.g.
../drivers/net/enic/enic_rxtx_vec_avx2.c: In function ‘rx_one’:
../drivers/net/enic/enic_rxtx_vec_avx2.c:21:2:
warning:
array subscript 0 is outside the bounds of an interior zero-length array ‘RTE_MARKER64’ {aka ‘long unsigned int[0]’} [-Wzero-length-bounds]

   21 |  *(uint64_t *)&mb->rearm_data = enic->mbuf_initializer;
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../lib/librte_mbuf/rte_mbuf.h:45,
                 from ../drivers/net/enic/enic_rxtx_vec_avx2.c:6:
../lib/librte_mbuf/rte_mbuf_core.h:484:15:
note: while referencing ‘rearm_data’
  484 |  RTE_MARKER64 rearm_data;
      |

Disable this warning for gcc 10 in order to allow v20.05 to build without changes to struct rte_mbuf.

Bugzilla ID: 396
Cc: [email protected]

---
Sending as per discussion at this mornings release meeting:
http://inbox.dpdk.org/dev/[email protected]/

Reference to Gavin's patch:
http://inbox.dpdk.org/dev/CAJFAV8yL2GvEJtTXOLk6o0eXHi4CpZmqCoRsfN2WcDe_ju1C8A@mail.gmail.com/#t

---
 config/meson.build           | 4 ++++
 mk/toolchain/gcc/rte.vars.mk | 5 +++++
 2 files changed, 9 insertions(+)
config/meson.build +4 -0
index a1c38c053..43ab11310 100644
@@ -209,4 +209,8 @@ warning_flags = [
        '-Wno-missing-field-initializers'
 ]
+if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0')
+# FIXME: Bugzilla 396
+       warning_flags += '-Wno-zero-length-bounds'
+endif
 if not dpdk_conf.get('RTE_ARCH_64')
 # for 32-bit, don't warn about casting a 32-bit pointer to 64-bit int - it's fine!!
mk/toolchain/gcc/rte.vars.mk +5 -1
index f19305e49..928f0e083 100644
@@ -82,4 +82,9 @@ WERROR_FLAGS += -Wno-uninitialized
 endif
 
+ifeq ($(shell test $(GCC_VERSION) -ge 100 && echo 1), 1)
+# FIXME: Bugzilla 396
+WERROR_FLAGS += -Wno-zero-length-bounds
+endif
+
 HOST_WERROR_FLAGS := $(WERROR_FLAGS)
 
--
Quoted 2 lines

2.21.3

Signature · 1 line
David Marchand
#2 lore raw
Quoted 67 lines · David Marchand
Quoted 65 lines · Kevin Traynor

gcc 10 issues warnings about the use of rearm_data marker from struct rte_mbuf.

e.g.
../drivers/net/enic/enic_rxtx_vec_avx2.c: In function ‘rx_one’:
../drivers/net/enic/enic_rxtx_vec_avx2.c:21:2:
warning:
array subscript 0 is outside the bounds of an interior zero-length array ‘RTE_MARKER64’ {aka ‘long unsigned int[0]’} [-Wzero-length-bounds]

   21 |  *(uint64_t *)&mb->rearm_data = enic->mbuf_initializer;
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../lib/librte_mbuf/rte_mbuf.h:45,
                 from ../drivers/net/enic/enic_rxtx_vec_avx2.c:6:
../lib/librte_mbuf/rte_mbuf_core.h:484:15:
note: while referencing ‘rearm_data’
  484 |  RTE_MARKER64 rearm_data;
      |

Disable this warning for gcc 10 in order to allow v20.05 to build without changes to struct rte_mbuf.

Bugzilla ID: 396
Cc: [email protected]

---
Sending as per discussion at this mornings release meeting:
http://inbox.dpdk.org/dev/[email protected]/

Reference to Gavin's patch:
http://inbox.dpdk.org/dev/CAJFAV8yL2GvEJtTXOLk6o0eXHi4CpZmqCoRsfN2WcDe_ju1C8A@mail.gmail.com/#t

---
 config/meson.build           | 4 ++++
 mk/toolchain/gcc/rte.vars.mk | 5 +++++
 2 files changed, 9 insertions(+)
config/meson.build +4 -0
index a1c38c053..43ab11310 100644
@@ -209,4 +209,8 @@ warning_flags = [
        '-Wno-missing-field-initializers'
 ]
+if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0')
+# FIXME: Bugzilla 396
+       warning_flags += '-Wno-zero-length-bounds'
+endif
 if not dpdk_conf.get('RTE_ARCH_64')
 # for 32-bit, don't warn about casting a 32-bit pointer to 64-bit int - it's fine!!
mk/toolchain/gcc/rte.vars.mk +5 -0
index f19305e49..928f0e083 100644
@@ -82,4 +82,9 @@ WERROR_FLAGS += -Wno-uninitialized
 endif
 
+ifeq ($(shell test $(GCC_VERSION) -ge 100 && echo 1), 1)
+# FIXME: Bugzilla 396
+WERROR_FLAGS += -Wno-zero-length-bounds
+endif
+
 HOST_WERROR_FLAGS := $(WERROR_FLAGS)
 
Quoted 5 lines
Quoted 3 lines

--
2.21.3

No objection on this patch, so I'll proceed and merge it for rc3.

Signature · 1 line
David Marchand
#3 lore raw
In reply to David Marchand
Quoted 20 lines · David Marchand
Quoted 19 lines · Kevin Traynor

gcc 10 issues warnings about the use of rearm_data marker from struct rte_mbuf.

e.g.
../drivers/net/enic/enic_rxtx_vec_avx2.c: In function ‘rx_one’:
../drivers/net/enic/enic_rxtx_vec_avx2.c:21:2:
warning:
array subscript 0 is outside the bounds of an interior zero-length array ‘RTE_MARKER64’ {aka ‘long unsigned int[0]’} [-Wzero-length-bounds]

   21 |  *(uint64_t *)&mb->rearm_data = enic->mbuf_initializer;
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../lib/librte_mbuf/rte_mbuf.h:45,
                 from ../drivers/net/enic/enic_rxtx_vec_avx2.c:6:
../lib/librte_mbuf/rte_mbuf_core.h:484:15:
note: while referencing ‘rearm_data’
  484 |  RTE_MARKER64 rearm_data;
      |
Quoted 8 lines
Quoted 7 lines

Disable this warning for gcc 10 in order to allow v20.05 to build without changes to struct rte_mbuf.

Bugzilla ID: 396
Cc: [email protected]

Applied, thanks.

Signature · 1 line
David Marchand