Skip to contentSkip to conversation

pty04: Fix read retries

PATCH New Richard Palethorpe 2 participants 2 messages May 14, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pty04: Fix read retries

We need to increase the data pointer by the amount already read.

---
 testcases/kernel/pty/pty04.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
testcases/kernel/pty/pty04.c +1 -1
index 68a84ea87..d574d8b2c 100644
@@ -294,7 +294,7 @@ static void try_read(int fd, char *data, ssize_t size)
 	int retry = mtu;
 
 	while (retry--) {
-		ret = read(fd, data, size - n);
+		ret = read(fd, data + n, size - n);
 
 		if (ret < 0)
 			break;
Signature · 1 line
2.26.1
Applied
#1 lore raw

PATCH 1/1 pty04: Fix read retries

Hi!

Quoted 1 line

We need to increase the data pointer by the amount already read.

Applied, thanks.

Quoted 10 lines
---
 testcases/kernel/pty/pty04.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
testcases/kernel/pty/pty04.c +0 -0
index 68a84ea87..d574d8b2c 100644

testcases/kernel/pty/pty04.c static void try_read(int fd, char *data, ssize_t size) · line 297

Quoted 5 lines
testcases/kernel/pty/pty04.c +1 -1
@@ -294,7 +294,7 @@ static void try_read(int fd, char *data, ssize_t size)
 	int retry = mtu;
 
 	while (retry--) {
-		ret = read(fd, data, size - n);
+		ret = read(fd, data + n, size - n);

Sorry for not catching that during the review...

Signature · 2 lines
Cyril Hrubis
[email protected]