Skip to contentSkip to conversation

make implementation of read16, read32 and write32 optional fix

PATCH New [email protected] 1 participant 2 messages May 14, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 make implementation of read16, read32 and write32 optional fix

From: Amir Mizinski <[email protected]>

This patch fix compilation error for newly added CR50 SPI driver found in previous submission.

Amir Mizinski (1):
tpm: tpm_tis: make implementation of read16, read32 and write32
optional fix

 drivers/char/tpm/tpm_tis_spi.h      | 4 ----
 drivers/char/tpm/tpm_tis_spi_cr50.c | 3 ---
 2 files changed, 7 deletions(-)
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 tpm: tpm_tis: make implementation of read16, read32 and write32 optional fix

From: Amir Mizinski <[email protected]>

Removed SPI extern function definitions and unused callback functions for CR50 driver.

Fixes fa05dc792ea0 ("tpm: tpm_tis: make implementation of read16, read32 and write32 optional")
---
 drivers/char/tpm/tpm_tis_spi.h      | 4 ----
 drivers/char/tpm/tpm_tis_spi_cr50.c | 3 ---
 2 files changed, 7 deletions(-)
drivers/char/tpm/tpm_tis_spi.h +0 -4
index bba7397..d0f66f6 100644
@@ -31,10 +31,6 @@ extern int tpm_tis_spi_init(struct spi_device *spi, struct tpm_tis_spi_phy *phy,
 extern int tpm_tis_spi_transfer(struct tpm_tis_data *data, u32 addr, u16 len,
 				u8 *in, const u8 *out);
 
-extern int tpm_tis_spi_read16(struct tpm_tis_data *data, u32 addr, u16 *result);
-extern int tpm_tis_spi_read32(struct tpm_tis_data *data, u32 addr, u32 *result);
-extern int tpm_tis_spi_write32(struct tpm_tis_data *data, u32 addr, u32 value);
-
 #ifdef CONFIG_TCG_TIS_SPI_CR50
 extern int cr50_spi_probe(struct spi_device *spi);
 #else
drivers/char/tpm/tpm_tis_spi_cr50.c +0 -3
index 37d72e8..f339d20 100644
@@ -215,9 +215,6 @@ static int tpm_tis_spi_cr50_write_bytes(struct tpm_tis_data *data, u32 addr,
 static const struct tpm_tis_phy_ops tpm_spi_cr50_phy_ops = {
 	.read_bytes = tpm_tis_spi_cr50_read_bytes,
 	.write_bytes = tpm_tis_spi_cr50_write_bytes,
-	.read16 = tpm_tis_spi_read16,
-	.read32 = tpm_tis_spi_read32,
-	.write32 = tpm_tis_spi_write32,
 };
 
 static void cr50_print_fw_version(struct tpm_tis_data *data)
Signature · 1 line
2.7.4