Skip to contentSkip to conversation

fp16 support in xBGR order, and for DCE-11+

PATCH In review Mario Kleiner 4 participants 9 messages May 15, 2020 – May 20, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hi,

two patches. The first one adds the xBGR ordered variants of fp16 in addition to the xRGB ordered variants that were merged just very recently.

These variants are required for direct scanout of OpenGL and Vulkan rendered content, as both OpenGL (GL_RGBA16F) and Vulkan (VK_FORMAT_R16G16B16A16_SFLOAT) expect RGBA channel order for fp16, instead of the previously exposed BGRA fp16 ordering.

I have a proof of concept patch against the amdvlk Vulkan driver that allows fp16 rendering and presentation with this format, but not with the xRGB format. Nicholas already has the test patch in his inbox. Results look visually correct, also when used on a HDR monitor.

I also tested with Patch 2/2 on top on a Polaris11 gpu with DCE-11.2 display engine, and also got correct results, so maybe it makes sense to enable fp16 scanout support also for DCE and not only DCN? Patch 2/2 does not enable fp16 on DCE 10 or DCE 8, because i don't have hardware to test it. But it would be nice to expose fp16 on all supported display engines.

Thanks,
-mario

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#1 lore raw

PATCH 1/2 drm/amd/display: Expose support for xBGR ordered fp16 formats.

Expose support for DRM_FORMAT_ABGR16161616F and DRM_FORMAT_XBGR16161616F to the DRM core, complementing the already existing xRGB ordered fp16 formats.

These are especially useful for creating presentable swapchains in Vulkan for VK_FORMAT_R16G16B16A16_SFLOAT.

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +6 -0
index 48f2b3710e7c..bd0c9eda8f93 100644
@@ -3651,6 +3651,10 @@ fill_dc_plane_info_and_addr(struct amdgpu_device *adev,
 	case DRM_FORMAT_ARGB16161616F:
 		plane_info->format = SURFACE_PIXEL_FORMAT_GRPH_ARGB16161616F;
 		break;
+	case DRM_FORMAT_XBGR16161616F:
+	case DRM_FORMAT_ABGR16161616F:
+		plane_info->format = SURFACE_PIXEL_FORMAT_GRPH_ABGR16161616F;
+		break;
 	default:
 		DRM_ERROR(
 			"Unsupported screen format %s\n",
@@ -5566,6 +5570,8 @@ static int get_plane_formats(const struct drm_plane *plane,
 		if (plane_cap && plane_cap->pixel_format_support.fp16) {
 			formats[num_formats++] = DRM_FORMAT_XRGB16161616F;
 			formats[num_formats++] = DRM_FORMAT_ARGB16161616F;
+			formats[num_formats++] = DRM_FORMAT_XBGR16161616F;
+			formats[num_formats++] = DRM_FORMAT_ABGR16161616F;
 		}
 		break;
 
Signature · 6 lines
2.20.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
#2 lore raw

PATCH 2/2 drm/amd/display: Enable fp16 also on DCE-11.0 - DCE-12.

In reply to Mario Kleiner

Testing on a Polaris11 gpu with DCE-11.2 suggests that it seems to work fine there, so optimistically enable it for DCE-11 and later.

---
 drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 2 +-
 drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 2 +-
 drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +1 -1
index 9597fc79d7fa..a043ddae5149 100644
@@ -410,7 +410,7 @@ static const struct dc_plane_cap plane_cap = {
 		.pixel_format_support = {
 				.argb8888 = true,
 				.nv12 = false,
-				.fp16 = false
+				.fp16 = true
 		},
 
 		.max_upscale_factor = {
drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +1 -1
index 4a7796de2ff5..51b3fe502670 100644
@@ -411,7 +411,7 @@ static const struct dc_plane_cap plane_cap = {
 	.pixel_format_support = {
 			.argb8888 = true,
 			.nv12 = false,
-			.fp16 = false
+			.fp16 = true
 	},
 
 	.max_upscale_factor = {
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +1 -1
index 9a9764cbd78d..8f362e8c1787 100644
@@ -516,7 +516,7 @@ static const struct dc_plane_cap plane_cap = {
 	.pixel_format_support = {
 			.argb8888 = true,
 			.nv12 = false,
-			.fp16 = false
+			.fp16 = true
 	},
 
 	.max_upscale_factor = {
Signature · 6 lines
2.20.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Reviewed-by on v1 2/2
#3 lore raw

Re: [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-11.0 - DCE-12.

Quoted 5 lines · Mario Kleiner

Testing on a Polaris11 gpu with DCE-11.2 suggests that it seems to work fine there, so optimistically enable it for DCE-11 and later.

Series is:

Thanks!

Quoted 38 lines
---
  drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 2 +-
  drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 2 +-
  drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 2 +-
  3 files changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +1 -1
index 9597fc79d7fa..a043ddae5149 100644
@@ -410,7 +410,7 @@ static const struct dc_plane_cap plane_cap = {
  		.pixel_format_support = {
  				.argb8888 = true,
  				.nv12 = false,
-				.fp16 = false
+				.fp16 = true
  		},
 
  		.max_upscale_factor = {
drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +1 -1
index 4a7796de2ff5..51b3fe502670 100644
@@ -411,7 +411,7 @@ static const struct dc_plane_cap plane_cap = {
  	.pixel_format_support = {
  			.argb8888 = true,
  			.nv12 = false,
-			.fp16 = false
+			.fp16 = true
  	},
 
  	.max_upscale_factor = {
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +0 -0
index 9a9764cbd78d..8f362e8c1787 100644

drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c static const struct dc_plane_cap plane_cap = { · line 522

Quoted 8 lines
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +1 -1
@@ -516,7 +516,7 @@ static const struct dc_plane_cap plane_cap = {
  	.pixel_format_support = {
  			.argb8888 = true,
  			.nv12 = false,
-			.fp16 = false
+			.fp16 = true
  	},
 
  	.max_upscale_factor = {

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw

Re: [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-11.0 - DCE-12.

In reply to Mario Kleiner
Quoted 16 lines · Mario Kleiner

Testing on a Polaris11 gpu with DCE-11.2 suggests that it seems to work fine there, so optimistically enable it for DCE-11 and later.

---
 drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 2 +-
 drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 2 +-
 drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +0 -0
index 9597fc79d7fa..a043ddae5149 100644

drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c static const struct dc_plane_cap plane_cap = { · line 413

Quoted 5 lines
drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +1 -1
@@ -410,7 +410,7 @@ static const struct dc_plane_cap plane_cap = {
 		.pixel_format_support = {
 				.argb8888 = true,
 				.nv12 = false,
-				.fp16 = false
+				.fp16 = true

Carrizo (DCE 11.0) has a HW bug where FP16 scaling doesn't work. I recommend we leave it off here.

Harry

Quoted 22 lines
drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +0 -0
 		},
 
 		.max_upscale_factor = {
drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +1 -1
index 4a7796de2ff5..51b3fe502670 100644
@@ -411,7 +411,7 @@ static const struct dc_plane_cap plane_cap = {
 	.pixel_format_support = {
 			.argb8888 = true,
 			.nv12 = false,
-			.fp16 = false
+			.fp16 = true
 	},
 
 	.max_upscale_factor = {
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +0 -0
index 9a9764cbd78d..8f362e8c1787 100644

drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c static const struct dc_plane_cap plane_cap = { · line 522

Quoted 8 lines
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +1 -1
@@ -516,7 +516,7 @@ static const struct dc_plane_cap plane_cap = {
 	.pixel_format_support = {
 			.argb8888 = true,
 			.nv12 = false,
-			.fp16 = false
+			.fp16 = true
 	},
 
 	.max_upscale_factor = {

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#5 lore raw

Re: [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-11.0 - DCE-12.

Quoted 13 lines · Harry Wentland
Quoted 11 lines · Mario Kleiner

Testing on a Polaris11 gpu with DCE-11.2 suggests that it seems to work fine there, so optimistically enable it for DCE-11 and later.

---
 drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 2 +-
 drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 2 +-
 drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Quoted 13 lines

drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c static const struct dc_plane_cap plane_cap = { · line 413

Quoted 10 lines
drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +1 -1
index 9597fc79d7fa..a043ddae5149 100644
@@ -410,7 +410,7 @@ static const struct dc_plane_cap plane_cap = {
              .pixel_format_support = {
                              .argb8888 = true,
                              .nv12 = false,
-                             .fp16 = false
+                             .fp16 = true

Carrizo (DCE 11.0) has a HW bug where FP16 scaling doesn't work. I recommend we leave it off here.

I'll drop this hunk for upstream.

Alex

Quoted 31 lines

Harry

Quoted 28 lines
drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +0 -0
              },
 
              .max_upscale_factor = {
drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +1 -1
index 4a7796de2ff5..51b3fe502670 100644
@@ -411,7 +411,7 @@ static const struct dc_plane_cap plane_cap = {
      .pixel_format_support = {
                      .argb8888 = true,
                      .nv12 = false,
-                     .fp16 = false
+                     .fp16 = true
      },
 
      .max_upscale_factor = {
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +1 -1
index 9a9764cbd78d..8f362e8c1787 100644
@@ -516,7 +516,7 @@ static const struct dc_plane_cap plane_cap = {
      .pixel_format_support = {
                      .argb8888 = true,
                      .nv12 = false,
-                     .fp16 = false
+                     .fp16 = true
      },
 
Quoted 6 lines

drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c static const struct dc_plane_cap plane_cap = { · line 522

Quoted 2 lines
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +0 -0
      .max_upscale_factor = {

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#6 lore raw

Re: [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-11.0 - DCE-12.

Quoted 29 lines · Alex Deucher
Quoted 6 lines · Harry Wentland
Quoted 4 lines · Mario Kleiner

Testing on a Polaris11 gpu with DCE-11.2 suggests that it seems to work fine there, so optimistically enable it for DCE-11 and later.

Quoted 8 lines

Review

Quoted 8 lines
---
 drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 2 +-
 drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 2 +-
 drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c

Quoted 4 lines
Quoted 4 lines

index 9597fc79d7fa..a043ddae5149 100644

drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +0 -0
@@ -410,7 +410,7 @@ static const struct dc_plane_cap plane_cap = {
Quoted 8 lines

drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c static const struct dc_plane_cap plane_cap = { · line 413

Quoted 5 lines
drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +1 -1
              .pixel_format_support = {
                              .argb8888 = true,
                              .nv12 = false,
-                             .fp16 = false
+                             .fp16 = true

Carrizo (DCE 11.0) has a HW bug where FP16 scaling doesn't work. I recommend we leave it off here.

Quoted 5 lines

I'll drop this hunk for upstream.

Alex

Ok, no fixup patch needed from myself, thanks Alex. Does the scaling bug refer to scaling the planes (those max_downscale_factor / max_upscale_factor definitions seem to be unused) or the fp16 values itself?

What about DCE 8 and DCE 10 hw capabilities wrt. fp16? Should i send fp16 enable patches for those as well?

-mario

Quoted 19 lines
Quoted 7 lines

Harry

Review

Quoted 4 lines
drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +0 -0
              },
 
              .max_upscale_factor = {
(quoted diff) +0 -0

b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c

Quoted 11 lines
Quoted 11 lines

index 4a7796de2ff5..51b3fe502670 100644

drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +1 -1
@@ -411,7 +411,7 @@ static const struct dc_plane_cap plane_cap = {
      .pixel_format_support = {
                      .argb8888 = true,
                      .nv12 = false,
-                     .fp16 = false
+                     .fp16 = true
      },
 
Quoted 21 lines
Quoted 2 lines

Review

Quoted 2 lines
drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +0 -0
      .max_upscale_factor = {
(quoted diff) +0 -0

b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c

Quoted 17 lines

drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c static const struct dc_plane_cap plane_cap = { · line 522

Quoted 13 lines

index 9a9764cbd78d..8f362e8c1787 100644

drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +1 -1
@@ -516,7 +516,7 @@ static const struct dc_plane_cap plane_cap = {
      .pixel_format_support = {
                      .argb8888 = true,
                      .nv12 = false,
-                     .fp16 = false
+                     .fp16 = true
      },
 
      .max_upscale_factor = {

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#7 lore raw

Re: [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-11.0 - DCE-12.

Quoted 39 lines · Mario Kleiner

On Wed, May 20, 2020 at 8:25 PM Alex Deucher <[email protected] <mailto:[email protected]>> wrote:

    On Wed, May 20, 2020 at 12:39 PM Harry Wentland <[email protected]
    <mailto:[email protected]>> wrote:
     >
     > On 2020-05-15 1:19 a.m., Mario Kleiner wrote:
     > > Testing on a Polaris11 gpu with DCE-11.2 suggests that it
     > > seems to work fine there, so optimistically enable it for
     > > DCE-11 and later.
     > >
     > > Signed-off-by: Mario Kleiner <[email protected]
    <mailto:[email protected]>>
     > > ---
     > >  drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 2 +-
     > >  drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 2 +-
     > >  drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 2 +-
     > >  3 files changed, 3 insertions(+), 3 deletions(-)
     > >
     > > diff --git
    a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
    b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
     > > index 9597fc79d7fa..a043ddae5149 100644
     > > --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
     > > +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
     > > @@ -410,7 +410,7 @@ static const struct dc_plane_cap plane_cap = {
     > >               .pixel_format_support = {
     > >                               .argb8888 = true,
     > >                               .nv12 = false,
     > > -                             .fp16 = false
     > > +                             .fp16 = true
     >
     > Carrizo (DCE 11.0) has a HW bug where FP16 scaling doesn't work. I
     > recommend we leave it off here.

    I'll drop this hunk for upstream.

    Alex
Quoted 5 lines

Ok, no fixup patch needed from myself, thanks Alex. Does the scaling bug refer to scaling the planes (those max_downscale_factor / max_upscale_factor definitions seem to be unused) or the fp16 values itself?

What about DCE 8 and DCE 10 hw capabilities wrt. fp16? Should i send fp16 enable patches for those as well?

-mario

Yeah, the upscale and downscale factors were intended to block FP16 accepted and reject the commit but I guess nobody ever added those to atomic check.

I reviewed the patch with the idea in mind that we already blocked this on a DC level. We can re-enable it in the caps after this is in I think.

Off the top of my head I don't remember what DCE8/DCE10 supports, but I'm also not sure if they even support sending the SDP message for those to really be usable.

Regards,
Nicholas Kazlauskas

Quoted 36 lines
     >
     > Harry
     >
     > >               },
     > >
     > >               .max_upscale_factor = {
     > > diff --git
    a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
    b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
     > > index 4a7796de2ff5..51b3fe502670 100644
     > > --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
     > > +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
     > > @@ -411,7 +411,7 @@ static const struct dc_plane_cap plane_cap = {
     > >       .pixel_format_support = {
     > >                       .argb8888 = true,
     > >                       .nv12 = false,
     > > -                     .fp16 = false
     > > +                     .fp16 = true
     > >       },
     > >
     > >       .max_upscale_factor = {
     > > diff --git
    a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
    b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
     > > index 9a9764cbd78d..8f362e8c1787 100644
     > > --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
     > > +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
     > > @@ -516,7 +516,7 @@ static const struct dc_plane_cap plane_cap = {
     > >       .pixel_format_support = {
     > >                       .argb8888 = true,
     > >                       .nv12 = false,
     > > -                     .fp16 = false
     > > +                     .fp16 = true
     > >       },
     > >
Quoted 9 lines
     > >       .max_upscale_factor = {
     > >
     > _______________________________________________
     > dri-devel mailing list
     > [email protected]
    <mailto:[email protected]>
     > https://lists.freedesktop.org/mailman/listinfo/dri-devel
    <https://lists.freedesktop.org/mailman/listinfo/dri-devel>

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#8 lore raw

Re: [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-11.0 - DCE-12.

Quoted 56 lines · Nicholas
Quoted 18 lines · Mario Kleiner

On Wed, May 20, 2020 at 8:25 PM Alex Deucher <[email protected] <mailto:[email protected]>> wrote:

    On Wed, May 20, 2020 at 12:39 PM Harry Wentland <[email protected]
    <mailto:[email protected]>> wrote:
     >
     > On 2020-05-15 1:19 a.m., Mario Kleiner wrote:
     > > Testing on a Polaris11 gpu with DCE-11.2 suggests that it
     > > seems to work fine there, so optimistically enable it for
     > > DCE-11 and later.
     > >
     > > Signed-off-by: Mario Kleiner <[email protected]
    <mailto:[email protected]>>
     > > ---
     > >  drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 2 +-
     > >  drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 2 +-
     > >  drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 2 +-
     > >  3 files changed, 3 insertions(+), 3 deletions(-)
Quoted 8 lines
     > >
     > > diff --git
    a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
    b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
     > > index 9597fc79d7fa..a043ddae5149 100644
     > > --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
     > > +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
     > > @@ -410,7 +410,7 @@ static const struct dc_plane_cap plane_cap

= {

Quoted 9 lines

> > .pixel_format_support = {
> > .argb8888 = true,
> > .nv12 = false,
> > - .fp16 = false
> > + .fp16 = true
>
> Carrizo (DCE 11.0) has a HW bug where FP16 scaling doesn't work. I > recommend we leave it off here.

Quoted 8 lines

I'll drop this hunk for upstream.

Alex

Ok, no fixup patch needed from myself, thanks Alex. Does the scaling bug refer to scaling the planes (those max_downscale_factor / max_upscale_factor definitions seem to be unused) or the fp16 values

itself?

Quoted 5 lines

What about DCE 8 and DCE 10 hw capabilities wrt. fp16? Should i send fp16 enable patches for those as well?

-mario

Yeah, the upscale and downscale factors were intended to block FP16 accepted and reject the commit but I guess nobody ever added those to atomic check.

Quoted 7 lines

I reviewed the patch with the idea in mind that we already blocked this on a DC level. We can re-enable it in the caps after this is in I think.

Off the top of my head I don't remember what DCE8/DCE10 supports, but I'm also not sure if they even support sending the SDP message for those to really be usable.

While HDR is the typical user for fp16, even on SDR displays, without any HDR signalling, fp16 should give an additional bit of precision ~ 11 bpc effective in standard 0.0 - 1.0 unorm range on a 12 bit pipeline with a 12 bpc panel or even on a 10 bpc panel with dithering. Useful for neuroscience/medical research applications or the color precision obsessed people. I take every bit i can get ;)

-mario

Quoted 33 lines

Regards,
Nicholas Kazlauskas

Quoted 14 lines
     >
     > Harry
     >
     > >               },
     > >
     > >               .max_upscale_factor = {
     > > diff --git
    a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
    b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
     > > index 4a7796de2ff5..51b3fe502670 100644
     > > --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
     > > +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
     > > @@ -411,7 +411,7 @@ static const struct dc_plane_cap plane_cap

= {

Quoted 7 lines
     > >       .pixel_format_support = {
     > >                       .argb8888 = true,
     > >                       .nv12 = false,
     > > -                     .fp16 = false
     > > +                     .fp16 = true
     > >       },
     > >
Quoted 8 lines
     > >       .max_upscale_factor = {
     > > diff --git
    a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
    b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
     > > index 9a9764cbd78d..8f362e8c1787 100644
     > > --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
     > > +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
     > > @@ -516,7 +516,7 @@ static const struct dc_plane_cap plane_cap
Quoted 19 lines

= {

Quoted 16 lines
     > >       .pixel_format_support = {
     > >                       .argb8888 = true,
     > >                       .nv12 = false,
     > > -                     .fp16 = false
     > > +                     .fp16 = true
     > >       },
     > >
     > >       .max_upscale_factor = {
     > >
     > _______________________________________________
     > dri-devel mailing list
     > [email protected]
    <mailto:[email protected]>
     > https://lists.freedesktop.org/mailman/listinfo/dri-devel
    <https://lists.freedesktop.org/mailman/listinfo/dri-devel>

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx