Skip to contentSkip to conversation

ASoC: max98390: Added Amplifier Driver

PATCH In review Steve Lee 3 participants 4 messages May 15, 2020 – May 18, 2020

Subsystems (2)
lore
Share & tools
lore

Steve Lee

author
#0 lore raw

PATCH v5 2/2 ASoC: max98390: Added Amplifier Driver

This is the initial amplifier driver for max98390.

---

Changes since V4:
* Revert return calibration status in max98390_dsm_calib_get:
There is no need to return calibration status in get function because there is mixer control lock protecting mixer control access. And set function of DSM calib finishes calibration synchronously.
* Fix sprintf in max98390_dsm_init func:
Use snprintf to avoid any unreasonable value from DMI.
Changes since V3:
* Add operation at max98390_dsm_calib_get:
Add cal_running variable at max98390_priv structure Add return cal_running at max98390_dsm_calib_get Update cal_running value during calibration
* Update max98390_dsm_init func
Add dsm_param bin name can select upon vendor and product name.
Changes since V2:
* Removed warn massage in max98390_dsm_calib_get func
and add comment.
Changes since V1:
* Updated according to Mark's comments.
* Updated according to Tzung-Bi's comments.
* Removed Enum structure and use TLV data for Volume control

 sound/soc/codecs/Kconfig    |    5 +
 sound/soc/codecs/Makefile   |    2 +
 sound/soc/codecs/max98390.c | 1040 +++++++++++++++++++++++++++++++++++
 sound/soc/codecs/max98390.h |  663 ++++++++++++++++++++++
 4 files changed, 1710 insertions(+)
 create mode 100644 sound/soc/codecs/max98390.c
 create mode 100644 sound/soc/codecs/max98390.h
sound/soc/codecs/Kconfig +5 -0
index e60e0b6a689c..93f88cd9970a 100644
@@ -116,6 +116,7 @@ config SND_SOC_ALL_CODECS
 	imply SND_SOC_MAX98926
 	imply SND_SOC_MAX98927
 	imply SND_SOC_MAX98373
+	imply SND_SOC_MAX98390
 	imply SND_SOC_MAX9850
 	imply SND_SOC_MAX9860
 	imply SND_SOC_MAX9759
@@ -867,6 +868,10 @@ config SND_SOC_MAX98373
 	tristate "Maxim Integrated MAX98373 Speaker Amplifier"
 	depends on I2C
 
+config SND_SOC_MAX98390
+	tristate "Maxim Integrated MAX98390 Speaker Amplifier"
+	depends on I2C
+
 config SND_SOC_MAX9850
 	tristate
 	depends on I2C
sound/soc/codecs/Makefile +2 -0
index 03533157cda6..e7c17f701529 100644
@@ -115,6 +115,7 @@ snd-soc-max98925-objs := max98925.o
 snd-soc-max98926-objs := max98926.o
 snd-soc-max98927-objs := max98927.o
 snd-soc-max98373-objs := max98373.o
+snd-soc-max98390-objs := max98390.o
 snd-soc-max9850-objs := max9850.o
 snd-soc-max9860-objs := max9860.o
 snd-soc-mc13783-objs := mc13783.o
@@ -415,6 +416,7 @@ obj-$(CONFIG_SND_SOC_MAX98925)	+= snd-soc-max98925.o
 obj-$(CONFIG_SND_SOC_MAX98926)	+= snd-soc-max98926.o
 obj-$(CONFIG_SND_SOC_MAX98927)	+= snd-soc-max98927.o
 obj-$(CONFIG_SND_SOC_MAX98373)	+= snd-soc-max98373.o
+obj-$(CONFIG_SND_SOC_MAX98390)	+= snd-soc-max98390.o
 obj-$(CONFIG_SND_SOC_MAX9850)	+= snd-soc-max9850.o
 obj-$(CONFIG_SND_SOC_MAX9860)	+= snd-soc-max9860.o
 obj-$(CONFIG_SND_SOC_MC13783)	+= snd-soc-mc13783.o
sound/soc/codecs/max98390.c new file +1040 -0

1,040 lines not on this page · raw message

sound/soc/codecs/max98390.h new file +663 -0

663 lines not on this page · raw message

Signature · 1 line
2.17.1
#1 lore raw
Quoted 4 lines · Steve Lee

This is the initial amplifier driver for max98390.

Hi,

Your "From" address still does not match the Signed-off-by. Set the author of commit to the signed-off person.

Best regards,
Krzysztof

maintainer
#2 lore raw
Quoted 2 lines · Krzysztof Kozlowski

Your "From" address still does not match the Signed-off-by. Set the author of commit to the signed-off person.

git commit --amend --author='foo <[email protected]>'

author
#3 lore raw
Quoted 7 lines · Mark Brown
Quoted 2 lines · Krzysztof Kozlowski

Your "From" address still does not match the Signed-off-by. Set the author of commit to the signed-off person.

git commit --amend --author='foo <[email protected]>'

Thanks. I will resend patch with matching email with signed off by.