Skip to contentSkip to conversation

mac80211_hwsim: report the WIPHY_FLAG_SUPPORTS_5_10_MHZ capability

PATCH In review Ramon Fontes 2 participants 5 messages May 15, 2020 – May 27, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mac80211_hwsim: report the WIPHY_FLAG_SUPPORTS_5_10_MHZ capability

---
 drivers/net/wireless/mac80211_hwsim.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/wireless/mac80211_hwsim.c +1 -0
index 0528d4cb4..67f97ac36 100644
@@ -2995,6 +2995,7 @@ static int mac80211_hwsim_new_radio(struct genl_info *info,
 	hw->wiphy->flags |= WIPHY_FLAG_SUPPORTS_TDLS |
 			    WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL |
 			    WIPHY_FLAG_AP_UAPSD |
+                            WIPHY_FLAG_SUPPORTS_5_10_MHZ |
 			    WIPHY_FLAG_HAS_CHANNEL_SWITCH;
 	hw->wiphy->features |= NL80211_FEATURE_ACTIVE_MONITOR |
 			       NL80211_FEATURE_AP_MODE_CHAN_WIDTH_CHANGE |
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 10 lines · Ramon Fontes
---
 drivers/net/wireless/mac80211_hwsim.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/wireless/mac80211_hwsim.c +0 -0
index 0528d4cb4..67f97ac36 100644

drivers/net/wireless/mac80211_hwsim.c static int mac80211_hwsim_new_radio(struct genl_info *info, · line 2998

Quoted 4 lines
drivers/net/wireless/mac80211_hwsim.c +1 -0
@@ -2995,6 +2995,7 @@ static int mac80211_hwsim_new_radio(struct genl_info *info,
 	hw->wiphy->flags |= WIPHY_FLAG_SUPPORTS_TDLS |
 			    WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL |
 			    WIPHY_FLAG_AP_UAPSD |
+                            WIPHY_FLAG_SUPPORTS_5_10_MHZ |

Not sure this is enough? How about wmediumd, for example?

And also, 5/10 MHz has many more channels inbetween the normal ones, no? Shouldn't those also be added?

johannes

#2 lore raw
Quoted 1 line

Not sure this is enough? How about wmediumd, for example?

It works with wmediumd too. At least I was able to enable 5 / 10MHz via iw with 5.9GHz

Quoted 2 lines

And also, 5/10 MHz has many more channels inbetween the normal ones, no? Shouldn't those also be added?

Tested with 5855MHz - 5925MHz

--
Ramon

maintainer
#3 lore raw
Quoted 4 lines · Ramon Fontes
Quoted 1 line

Not sure this is enough? How about wmediumd, for example?

It works with wmediumd too. At least I was able to enable 5 / 10MHz via iw with 5.9GHz

Yeah, but wmediumd won't know that it's not 20 MHz, I guess :-)

Quoted 4 lines
Quoted 2 lines

And also, 5/10 MHz has many more channels inbetween the normal ones, no? Shouldn't those also be added?

Tested with 5855MHz - 5925MHz

Yeah, but which channels? I believe with 10 MHz you can also use channel 175, for example, which doesn't exist in 20 MHz channelization.

Anyway, I've applied it now, we can fix more later.

johannes

#4 lore raw
Quoted 1 line

Yeah, but wmediumd won't know that it's not 20 MHz, I guess :-)

Yes, I know. You're right! I hope advances in wmediumd in this regard :).

Quoted 2 lines

Yeah, but which channels? I believe with 10 MHz you can also use channel 175, for example, which doesn't exist in 20 MHz channelization.

I'm doing some research with 802.11p and I could use all the channels between 171 and 185 with both 5 and 10MHz.

Quoted 1 line

Anyway, I've applied it now, we can fix more later.

Thanks!

Ramon