Skip to contentSkip to conversation

README: add pkg kernel-devel to dnf command

PATCH In review [email protected] 5 participants 19 messages May 15, 2020 – May 20, 2020 SELinux security module

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 README: add pkg kernel-devel to dnf command

From: William Roberts <[email protected]>

The text above states that kernel-devel is needed, but it's missing from the dnf command.

---
 README.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
README.md +2 -1
index 1f7e5d92a100..a73e9cc0c06d 100644
@@ -77,7 +77,8 @@ following command:
 		kernel-devel \
 		quota \
 		xfsprogs-devel \
-		libuuid-devel
+		libuuid-devel \
+		kernel-devel-$(uname -r)
 
 #### Debian
 
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 10 lines · On Fri, May 15, 2020 at 1:30 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

The text above states that kernel-devel is needed, but it's missing from the dnf command.

---
 README.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

It's not clear from the subject, diffstat, or your comments, but I'm assuming this is for selinux-testsuite, yes?

Quoted 17 lines
README.md +2 -2
index 1f7e5d92a100..a73e9cc0c06d 100644
@@ -77,7 +77,8 @@ following command:
                kernel-devel \
                quota \
                xfsprogs-devel \
-               libuuid-devel
+               libuuid-devel \
+               kernel-devel-$(uname -r)
 
 #### Debian
 
--

2.17.1

Signature · 2 lines
paul moore
www.paul-moore.com
#2 lore raw
Quoted 8 lines · Paul Moore
Quoted 6 lines · On Fri, May 15, 2020 at 1:30 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

The text above states that kernel-devel is needed, but it's missing from the dnf command.

Quoted 7 lines
Quoted 4 lines
---
 README.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

It's not clear from the subject, diffstat, or your comments, but I'm assuming this is for selinux-testsuite, yes?

Yes, that is correct.

Quoted 23 lines
Quoted 16 lines
README.md +2 -2
index 1f7e5d92a100..a73e9cc0c06d 100644
@@ -77,7 +77,8 @@ following command:
                kernel-devel \
                quota \
                xfsprogs-devel \
-               libuuid-devel
+               libuuid-devel \
+               kernel-devel-$(uname -r)
 
 #### Debian
 
--
Quoted 2 lines

2.17.1

--
paul moore
www.paul-moore.com

#3 lore raw
In reply to [email protected]
Quoted 15 lines · On Fri, May 15, 2020 at 7:31 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

The text above states that kernel-devel is needed, but it's missing from the dnf command.

---
 README.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
README.md +0 -0
index 1f7e5d92a100..a73e9cc0c06d 100644

README.md following command: · line 77

Quoted 1 line
README.md +0 -0
@@ -77,7 +77,8 @@ following command:
                kernel-devel \

It's actually right there already ^^

README.md following command: · line 81

Quoted 5 lines
README.md +2 -1
                quota \
                xfsprogs-devel \
-               libuuid-devel
+               libuuid-devel \
+               kernel-devel-$(uname -r)

I proposed adding the -$(uname -r) before, but there were some valid counterarguments. See the discussion here:
https://lore.kernel.org/selinux/CAFqZXNs5jcOOnhzT8=DQgzaf9RtBZ1=oqTU83pjVLMqPb-rzHA@mail.gmail.com/

Quoted 6 lines
README.md +0 -1
 #### Debian
 
--

2.17.1

--
Ondrej Mosnacek <omosnace at redhat dot com>
Software Engineer, Security Technologies
Red Hat, Inc.

#4 lore raw
Quoted 12 lines · Ondrej Mosnacek
Quoted 10 lines · On Fri, May 15, 2020 at 7:31 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

The text above states that kernel-devel is needed, but it's missing from the dnf command.

---
 README.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 8 lines

README.md following command: · line 77

Quoted 6 lines
README.md +0 -0
index 1f7e5d92a100..a73e9cc0c06d 100644
@@ -77,7 +77,8 @@ following command:
                kernel-devel \

It's actually right there already ^^

Yeah that's the foot cannon, I thought I was good, but you need the specific ones
as Ondrej pointed out to me.

Quoted 11 lines

README.md following command: · line 81

Quoted 6 lines
README.md +2 -1
                quota \
                xfsprogs-devel \
-               libuuid-devel
+               libuuid-devel \
+               kernel-devel-$(uname -r)

I proposed adding the -$(uname -r) before, but there were some valid counterarguments. See the discussion here:
https://lore.kernel.org/selinux/CAFqZXNs5jcOOnhzT8=DQgzaf9RtBZ1=oqTU83pjVLMqPb-rzHA@mail.gmail.com/

Arguments for why the dnf command should have it with uname:
1. We tried to add it twice, it's bit people twice.
2. The README states "On a modern Fedora system you can install these dependencies with the following command:"
- which is wrong, you need the specific package
- If you're going to provide a "dnf install" or a apt-get install,
it should just work
- the apt-get example has uname -r in it.
- so the precludes building your own kernel, if you do that as
Paul stated, you're on your own. (lore comment)

Quoted 12 lines
Quoted 6 lines
README.md +0 -1
 #### Debian
 
--

2.17.1

--
Ondrej Mosnacek <omosnace at redhat dot com>
Software Engineer, Security Technologies
Red Hat, Inc.

maintainer
#5 lore raw
Quoted 39 lines · William Roberts
Quoted 12 lines · Ondrej Mosnacek
Quoted 10 lines · On Fri, May 15, 2020 at 7:31 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

The text above states that kernel-devel is needed, but it's missing from the dnf command.

---
 README.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 8 lines

README.md following command: · line 77

Quoted 6 lines
README.md +0 -0
index 1f7e5d92a100..a73e9cc0c06d 100644
@@ -77,7 +77,8 @@ following command:
                kernel-devel \

It's actually right there already ^^

Yeah that's the foot cannon, I thought I was good, but you need the specific ones
as Ondrej pointed out to me.

Quoted 11 lines

README.md following command: · line 81

Quoted 6 lines
README.md +2 -1
                quota \
                xfsprogs-devel \
-               libuuid-devel
+               libuuid-devel \
+               kernel-devel-$(uname -r)

I proposed adding the -$(uname -r) before, but there were some valid counterarguments. See the discussion here:
https://lore.kernel.org/selinux/CAFqZXNs5jcOOnhzT8=DQgzaf9RtBZ1=oqTU83pjVLMqPb-rzHA@mail.gmail.com/

Quoted 10 lines

Arguments for why the dnf command should have it with uname:
1. We tried to add it twice, it's bit people twice.
2. The README states "On a modern Fedora system you can install these dependencies with the following command:"
- which is wrong, you need the specific package
- If you're going to provide a "dnf install" or a apt-get install,
it should just work
- the apt-get example has uname -r in it.
- so the precludes building your own kernel, if you do that as
Paul stated, you're on your own. (lore comment)

I'm ok with adding it.

#6 lore raw
Quoted 53 lines · Stephen Smalley
Quoted 39 lines · William Roberts
Quoted 12 lines · Ondrej Mosnacek
Quoted 10 lines · On Fri, May 15, 2020 at 7:31 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

The text above states that kernel-devel is needed, but it's missing from the dnf command.

---
 README.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 8 lines

README.md following command: · line 77

Quoted 6 lines
README.md +0 -0
index 1f7e5d92a100..a73e9cc0c06d 100644
@@ -77,7 +77,8 @@ following command:
                kernel-devel \

It's actually right there already ^^

Yeah that's the foot cannon, I thought I was good, but you need the specific ones
as Ondrej pointed out to me.

Quoted 11 lines

README.md following command: · line 81

Quoted 6 lines
README.md +2 -1
                quota \
                xfsprogs-devel \
-               libuuid-devel
+               libuuid-devel \
+               kernel-devel-$(uname -r)

I proposed adding the -$(uname -r) before, but there were some valid counterarguments. See the discussion here:
https://lore.kernel.org/selinux/CAFqZXNs5jcOOnhzT8=DQgzaf9RtBZ1=oqTU83pjVLMqPb-rzHA@mail.gmail.com/

Quoted 10 lines

Arguments for why the dnf command should have it with uname:
1. We tried to add it twice, it's bit people twice.
2. The README states "On a modern Fedora system you can install these dependencies with the following command:"
- which is wrong, you need the specific package
- If you're going to provide a "dnf install" or a apt-get install,
it should just work
- the apt-get example has uname -r in it.
- so the precludes building your own kernel, if you do that as
Paul stated, you're on your own. (lore comment)

Quoted 1 line

I'm ok with adding it.

Does anyone want to ack this one?

Ok I found another one, kernel-modules-extra is needed for the sctp module.

The tests expect sctp support, should we conditionally skip these if sctp is not enabled?
Whats the best way of checking for that proto if we want this? just an ls of /proc/sys/net:
ls /proc/sys/net/
bridge core ipv4 ipv6 netfilter nf_conntrack_max sctp unix

maintainer
#7 lore raw
Quoted 56 lines · William Roberts
Quoted 53 lines · Stephen Smalley
Quoted 49 lines · William Roberts
Quoted 12 lines · Ondrej Mosnacek
Quoted 10 lines · On Fri, May 15, 2020 at 7:31 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

The text above states that kernel-devel is needed, but it's missing from the dnf command.

---
 README.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 8 lines

README.md following command: · line 77

Quoted 6 lines
README.md +0 -0
index 1f7e5d92a100..a73e9cc0c06d 100644
@@ -77,7 +77,8 @@ following command:
                kernel-devel \

It's actually right there already ^^

Yeah that's the foot cannon, I thought I was good, but you need the specific ones
as Ondrej pointed out to me.

Quoted 11 lines

README.md following command: · line 81

Quoted 6 lines
README.md +2 -1
                quota \
                xfsprogs-devel \
-               libuuid-devel
+               libuuid-devel \
+               kernel-devel-$(uname -r)

I proposed adding the -$(uname -r) before, but there were some valid counterarguments. See the discussion here:
https://lore.kernel.org/selinux/CAFqZXNs5jcOOnhzT8=DQgzaf9RtBZ1=oqTU83pjVLMqPb-rzHA@mail.gmail.com/

Arguments for why the dnf command should have it with uname:
1. We tried to add it twice, it's bit people twice.
2. The README states "On a modern Fedora system you can install these dependencies with the following command:"
- which is wrong, you need the specific package
- If you're going to provide a "dnf install" or a apt-get install,
it should just work
- the apt-get example has uname -r in it.
- so the precludes building your own kernel, if you do that as
Paul stated, you're on your own. (lore comment)

Quoted 3 lines
Quoted 1 line

I'm ok with adding it.

Does anyone want to ack this one?

To be clear, we should just replace "kernel-devel" in the dnf command with "kernel-devel-$(uname -r)" assuming that works.
Not just add it in addition to the existing kernel-devel line.

Quoted 8 lines

Ok I found another one, kernel-modules-extra is needed for the sctp module.

The tests expect sctp support, should we conditionally skip these if sctp is not enabled?
Whats the best way of checking for that proto if we want this? just an ls of /proc/sys/net:
ls /proc/sys/net/
bridge core ipv4 ipv6 netfilter nf_conntrack_max sctp unix

Currently we require that the defconfig options are enabled (as per the README.md).
Making sctp optional however might not be a bad idea since it is blacklisted these days by default in some distros.

#8 lore raw
Quoted 59 lines · Stephen Smalley
Quoted 56 lines · William Roberts
Quoted 53 lines · Stephen Smalley
Quoted 49 lines · William Roberts
Quoted 12 lines · Ondrej Mosnacek
Quoted 10 lines · On Fri, May 15, 2020 at 7:31 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

The text above states that kernel-devel is needed, but it's missing from the dnf command.

---
 README.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 8 lines

README.md following command: · line 77

Quoted 6 lines
README.md +0 -0
index 1f7e5d92a100..a73e9cc0c06d 100644
@@ -77,7 +77,8 @@ following command:
                kernel-devel \

It's actually right there already ^^

Yeah that's the foot cannon, I thought I was good, but you need the specific ones
as Ondrej pointed out to me.

Quoted 11 lines

README.md following command: · line 81

Quoted 6 lines
README.md +2 -1
                quota \
                xfsprogs-devel \
-               libuuid-devel
+               libuuid-devel \
+               kernel-devel-$(uname -r)

I proposed adding the -$(uname -r) before, but there were some valid counterarguments. See the discussion here:
https://lore.kernel.org/selinux/CAFqZXNs5jcOOnhzT8=DQgzaf9RtBZ1=oqTU83pjVLMqPb-rzHA@mail.gmail.com/

Arguments for why the dnf command should have it with uname:
1. We tried to add it twice, it's bit people twice.
2. The README states "On a modern Fedora system you can install these dependencies with the following command:"
- which is wrong, you need the specific package
- If you're going to provide a "dnf install" or a apt-get install,
it should just work
- the apt-get example has uname -r in it.
- so the precludes building your own kernel, if you do that as
Paul stated, you're on your own. (lore comment)

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

I'm ok with adding it.

Does anyone want to ack this one?

To be clear, we should just replace "kernel-devel" in the dnf command with "kernel-devel-$(uname -r)" assuming that works.
Not just add it in addition to the existing kernel-devel line.

Ahh, Ok.

Quoted 10 lines
Quoted 9 lines

Ok I found another one, kernel-modules-extra is needed for the sctp module.

The tests expect sctp support, should we conditionally skip these if sctp is not enabled?
Whats the best way of checking for that proto if we want this? just an ls of /proc/sys/net:
ls /proc/sys/net/
bridge core ipv4 ipv6 netfilter nf_conntrack_max sctp unix

Quoted 4 lines

Currently we require that the defconfig options are enabled (as per the README.md).
Making sctp optional however might not be a bad idea since it is blacklisted these days by default in some distros.

Except defconfig has it as a module, so you need to have the module there and loaded. So for Fedora, you need the kernel modules package and modprobe it.

#9 lore raw
In reply to William Roberts
Quoted 55 lines · William Roberts
Quoted 53 lines · Stephen Smalley
Quoted 49 lines · William Roberts
Quoted 12 lines · Ondrej Mosnacek
Quoted 10 lines · On Fri, May 15, 2020 at 7:31 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

The text above states that kernel-devel is needed, but it's missing from the dnf command.

---
 README.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 8 lines

README.md following command: · line 77

Quoted 6 lines
README.md +0 -0
index 1f7e5d92a100..a73e9cc0c06d 100644
@@ -77,7 +77,8 @@ following command:
                kernel-devel \

It's actually right there already ^^

Yeah that's the foot cannon, I thought I was good, but you need the specific ones
as Ondrej pointed out to me.

Quoted 11 lines

README.md following command: · line 81

Quoted 6 lines
README.md +2 -1
                quota \
                xfsprogs-devel \
-               libuuid-devel
+               libuuid-devel \
+               kernel-devel-$(uname -r)

I proposed adding the -$(uname -r) before, but there were some valid counterarguments. See the discussion here:
https://lore.kernel.org/selinux/CAFqZXNs5jcOOnhzT8=DQgzaf9RtBZ1=oqTU83pjVLMqPb-rzHA@mail.gmail.com/

Arguments for why the dnf command should have it with uname:
1. We tried to add it twice, it's bit people twice.
2. The README states "On a modern Fedora system you can install these dependencies with the following command:"
- which is wrong, you need the specific package
- If you're going to provide a "dnf install" or a apt-get install,
it should just work
- the apt-get example has uname -r in it.
- so the precludes building your own kernel, if you do that as
Paul stated, you're on your own. (lore comment)

Quoted 3 lines
Quoted 1 line

I'm ok with adding it.

Does anyone want to ack this one?

As Stephen already said while I was writing this message, please just update the existing kernel-devel line.

Quoted 2 lines

Ok I found another one, kernel-modules-extra is needed for the sctp module.

On Fedora it shouldn't be, only on RHEL/CentOS 8.

Quoted 8 lines

The tests expect sctp support, should we conditionally skip these if sctp is not enabled?
Whats the best way of checking for that proto if we want this? just an ls of /proc/sys/net:
ls /proc/sys/net/
bridge core ipv4 ipv6 netfilter nf_conntrack_max sctp unix

Signature · 3 lines
Ondrej Mosnacek <omosnace at redhat dot com>
Software Engineer, Security Technologies
Red Hat, Inc.
#10 lore raw
Quoted 62 lines · Ondrej Mosnacek
Quoted 55 lines · William Roberts
Quoted 53 lines · Stephen Smalley
Quoted 49 lines · William Roberts
Quoted 12 lines · Ondrej Mosnacek
Quoted 10 lines · On Fri, May 15, 2020 at 7:31 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

The text above states that kernel-devel is needed, but it's missing from the dnf command.

---
 README.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 8 lines

README.md following command: · line 77

Quoted 6 lines
README.md +0 -0
index 1f7e5d92a100..a73e9cc0c06d 100644
@@ -77,7 +77,8 @@ following command:
                kernel-devel \

It's actually right there already ^^

Yeah that's the foot cannon, I thought I was good, but you need the specific ones
as Ondrej pointed out to me.

Quoted 11 lines

README.md following command: · line 81

Quoted 6 lines
README.md +2 -1
                quota \
                xfsprogs-devel \
-               libuuid-devel
+               libuuid-devel \
+               kernel-devel-$(uname -r)

I proposed adding the -$(uname -r) before, but there were some valid counterarguments. See the discussion here:
https://lore.kernel.org/selinux/CAFqZXNs5jcOOnhzT8=DQgzaf9RtBZ1=oqTU83pjVLMqPb-rzHA@mail.gmail.com/

Arguments for why the dnf command should have it with uname:
1. We tried to add it twice, it's bit people twice.
2. The README states "On a modern Fedora system you can install these dependencies with the following command:"
- which is wrong, you need the specific package
- If you're going to provide a "dnf install" or a apt-get install,
it should just work
- the apt-get example has uname -r in it.
- so the precludes building your own kernel, if you do that as
Paul stated, you're on your own. (lore comment)

Quoted 3 lines
Quoted 1 line

I'm ok with adding it.

Does anyone want to ack this one?

Quoted 7 lines

As Stephen already said while I was writing this message, please just update the existing kernel-devel line.

Quoted 2 lines

Ok I found another one, kernel-modules-extra is needed for the sctp module.

On Fedora it shouldn't be, only on RHEL/CentOS 8.

Not on the cloud image, so I am assuming that desktop just has it already fulfilled.

Quoted 15 lines
Quoted 9 lines

The tests expect sctp support, should we conditionally skip these if sctp is not enabled?
Whats the best way of checking for that proto if we want this? just an ls of /proc/sys/net:
ls /proc/sys/net/
bridge core ipv4 ipv6 netfilter nf_conntrack_max sctp unix

--
Ondrej Mosnacek <omosnace at redhat dot com>
Software Engineer, Security Technologies
Red Hat, Inc.

#11 lore raw
Quoted 67 lines · William Roberts
Quoted 66 lines · Ondrej Mosnacek
Quoted 55 lines · William Roberts
Quoted 53 lines · Stephen Smalley
Quoted 49 lines · William Roberts
Quoted 12 lines · Ondrej Mosnacek
Quoted 10 lines · On Fri, May 15, 2020 at 7:31 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

The text above states that kernel-devel is needed, but it's missing from the dnf command.

---
 README.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 8 lines

README.md following command: · line 77

Quoted 6 lines
README.md +0 -0
index 1f7e5d92a100..a73e9cc0c06d 100644
@@ -77,7 +77,8 @@ following command:
                kernel-devel \

It's actually right there already ^^

Yeah that's the foot cannon, I thought I was good, but you need the specific ones
as Ondrej pointed out to me.

Quoted 11 lines

README.md following command: · line 81

Quoted 6 lines
README.md +2 -1
                quota \
                xfsprogs-devel \
-               libuuid-devel
+               libuuid-devel \
+               kernel-devel-$(uname -r)

I proposed adding the -$(uname -r) before, but there were some valid counterarguments. See the discussion here:
https://lore.kernel.org/selinux/CAFqZXNs5jcOOnhzT8=DQgzaf9RtBZ1=oqTU83pjVLMqPb-rzHA@mail.gmail.com/

Arguments for why the dnf command should have it with uname:
1. We tried to add it twice, it's bit people twice.
2. The README states "On a modern Fedora system you can install these dependencies with the following command:"
- which is wrong, you need the specific package
- If you're going to provide a "dnf install" or a apt-get install,
it should just work
- the apt-get example has uname -r in it.
- so the precludes building your own kernel, if you do that as
Paul stated, you're on your own. (lore comment)

Quoted 3 lines
Quoted 1 line

I'm ok with adding it.

Does anyone want to ack this one?

As Stephen already said while I was writing this message, please just update the existing kernel-devel line.

Quoted 1 line
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Ok I found another one, kernel-modules-extra is needed for the sctp module.

On Fedora it shouldn't be, only on RHEL/CentOS 8.

Not on the cloud image, so I am assuming that desktop just has it already fulfilled.

That's strange... Was this with the 5.6.6-300.fc32.x86_64 kernel mentioned in the other thread? I just downloaded the RPMs for that build and sctp.ko was in kernel-modules, not kernel-modules-extra.

--
Ondrej Mosnacek <omosnace at redhat dot com>
Software Engineer, Security Technologies
Red Hat, Inc.

#12 lore raw
Quoted 72 lines · Ondrej Mosnacek
Quoted 69 lines · William Roberts
Quoted 68 lines · Ondrej Mosnacek
Quoted 55 lines · William Roberts
Quoted 53 lines · Stephen Smalley
Quoted 49 lines · William Roberts
Quoted 12 lines · Ondrej Mosnacek
Quoted 10 lines · On Fri, May 15, 2020 at 7:31 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

The text above states that kernel-devel is needed, but it's missing from the dnf command.

---
 README.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 8 lines

README.md following command: · line 77

Quoted 6 lines
README.md +0 -0
index 1f7e5d92a100..a73e9cc0c06d 100644
@@ -77,7 +77,8 @@ following command:
                kernel-devel \

It's actually right there already ^^

Yeah that's the foot cannon, I thought I was good, but you need the specific ones
as Ondrej pointed out to me.

Quoted 11 lines

README.md following command: · line 81

Quoted 6 lines
README.md +2 -1
                quota \
                xfsprogs-devel \
-               libuuid-devel
+               libuuid-devel \
+               kernel-devel-$(uname -r)

I proposed adding the -$(uname -r) before, but there were some valid counterarguments. See the discussion here:
https://lore.kernel.org/selinux/CAFqZXNs5jcOOnhzT8=DQgzaf9RtBZ1=oqTU83pjVLMqPb-rzHA@mail.gmail.com/

Arguments for why the dnf command should have it with uname:
1. We tried to add it twice, it's bit people twice.
2. The README states "On a modern Fedora system you can install these dependencies with the following command:"
- which is wrong, you need the specific package
- If you're going to provide a "dnf install" or a apt-get install,
it should just work
- the apt-get example has uname -r in it.
- so the precludes building your own kernel, if you do that as
Paul stated, you're on your own. (lore comment)

Quoted 3 lines
Quoted 1 line

I'm ok with adding it.

Does anyone want to ack this one?

As Stephen already said while I was writing this message, please just update the existing kernel-devel line.

Quoted 2 lines

Ok I found another one, kernel-modules-extra is needed for the sctp module.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

On Fedora it shouldn't be, only on RHEL/CentOS 8.

Not on the cloud image, so I am assuming that desktop just has it already fulfilled.

That's strange... Was this with the 5.6.6-300.fc32.x86_64 kernel mentioned in the other thread? I just downloaded the RPMs for that build and sctp.ko was in kernel-modules, not kernel-modules-extra.

I say it was in kernel-modules-extra-$(uname -r), but what I should have said, that solved the issue od not having the sctp module, but it solved it buy being dependent on kernel-modules, so the correct line to add would be that one, not extra.

I don't do really use fedora distros, so bear me with as I learn where to find info
and poke the system.

Quoted 6 lines

--
Ondrej Mosnacek <omosnace at redhat dot com>
Software Engineer, Security Technologies
Red Hat, Inc.

#13 lore raw

PATCH v2 1/1 README: update kernel-devel package in dnf command

In reply to [email protected]

From: William Roberts <[email protected]>

The README.md file in the selinux-testsuite states that kernel-devel package is needed. However, for everything to work you need the kernel-devel package specific to your kernel version. Update the dnf command to include uname -r, so that a copy + paste of the dnf command, results in a system with dependencies filled for recent Fedora distro's like Fedora 32.

---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
README.md +1 -1
index 1f7e5d92a100..4d5d6d22203a 100644
@@ -74,7 +74,7 @@ following command:
 		attr \
 		libbpf-devel \
 		keyutils-libs-devel \
-		kernel-devel \
+		kernel-devel-$(uname -r)
 		quota \
 		xfsprogs-devel \
 		libuuid-devel
Signature · 1 line
2.17.1
maintainer
#14 lore raw

Re: [PATCH v2] README: update kernel-devel package in dnf command

Quoted 20 lines · On Fri, May 15, 2020 at 5:02 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

The README.md file in the selinux-testsuite states that kernel-devel package is needed. However, for everything to work you need the kernel-devel package specific to your kernel version. Update the dnf command to include uname -r, so that a copy + paste of the dnf command, results in a system with dependencies filled for recent Fedora distro's like Fedora 32.

---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
README.md +0 -0
index 1f7e5d92a100..4d5d6d22203a 100644

README.md following command: · line 77

Quoted 5 lines
README.md +1 -1
@@ -74,7 +74,7 @@ following command:
                attr \
                libbpf-devel \
                keyutils-libs-devel \
-               kernel-devel \
+               kernel-devel-$(uname -r)

I \
think \
you \
forgot \
the \
trailing \
slash \

Quoted 5 lines
README.md +0 -1
                quota \
                xfsprogs-devel \
                libuuid-devel
--

2.17.1

Signature · 2 lines
paul moore
www.paul-moore.com
#15 lore raw

Re: [PATCH v2] README: update kernel-devel package in dnf command

Quoted 28 lines · Paul Moore
Quoted 20 lines · On Fri, May 15, 2020 at 5:02 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

The README.md file in the selinux-testsuite states that kernel-devel package is needed. However, for everything to work you need the kernel-devel package specific to your kernel version. Update the dnf command to include uname -r, so that a copy + paste of the dnf command, results in a system with dependencies filled for recent Fedora distro's like Fedora 32.

---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
README.md +0 -0
index 1f7e5d92a100..4d5d6d22203a 100644

README.md following command: · line 77

Quoted 5 lines
README.md +1 -1
@@ -74,7 +74,7 @@ following command:
                attr \
                libbpf-devel \
                keyutils-libs-devel \
-               kernel-devel \
+               kernel-devel-$(uname -r)
Quoted 7 lines

I \
think \
you \
forgot \
the \
trailing \
slash \

fsck \

Quoted 10 lines
Quoted 6 lines
README.md +0 -1
                quota \
                xfsprogs-devel \
                libuuid-devel
--

2.17.1

--
paul moore
www.paul-moore.com

#16 lore raw

PATCH v3 1/1 README: update kernel-devel package in dnf command

In reply to [email protected]

From: William Roberts <[email protected]>

The README.md file in the selinux-testsuite states that kernel-devel package is needed. However, for everything to work you need the kernel-devel package specific to your kernel version. Update the dnf command to include uname -r, so that a copy + paste of the dnf command, results in a system with dependencies filled for recent Fedora distro's like Fedora 32.

---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
README.md +1 -1
index 1f7e5d92a100..1bec9fe85c91 100644
@@ -74,7 +74,7 @@ following command:
 		attr \
 		libbpf-devel \
 		keyutils-libs-devel \
-		kernel-devel \
+		kernel-devel-$(uname -r) \
 		quota \
 		xfsprogs-devel \
 		libuuid-devel
Signature · 1 line
2.17.1
Acked-by on v3 1/1
#17 lore raw

Re: [PATCH v3] README: update kernel-devel package in dnf command

Quoted 28 lines · On Fri, May 15, 2020 at 11:22 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

The README.md file in the selinux-testsuite states that kernel-devel package is needed. However, for everything to work you need the kernel-devel package specific to your kernel version. Update the dnf command to include uname -r, so that a copy + paste of the dnf command, results in a system with dependencies filled for recent Fedora distro's like Fedora 32.

---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
README.md +1 -2
index 1f7e5d92a100..1bec9fe85c91 100644
@@ -74,7 +74,7 @@ following command:
                attr \
                libbpf-devel \
                keyutils-libs-devel \
-               kernel-devel \
+               kernel-devel-$(uname -r) \
                quota \
                xfsprogs-devel \
                libuuid-devel
--
Quoted 2 lines

2.17.1

Signature · 3 lines
Ondrej Mosnacek <omosnace at redhat dot com>
Software Engineer, Security Technologies
Red Hat, Inc.
#18 lore raw

Re: [PATCH v3] README: update kernel-devel package in dnf command

Quoted 25 lines · Ondrej Mosnacek
Quoted 24 lines · On Fri, May 15, 2020 at 11:22 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

The README.md file in the selinux-testsuite states that kernel-devel package is needed. However, for everything to work you need the kernel-devel package specific to your kernel version. Update the dnf command to include uname -r, so that a copy + paste of the dnf command, results in a system with dependencies filled for recent Fedora distro's like Fedora 32.

---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
README.md +1 -1
index 1f7e5d92a100..1bec9fe85c91 100644
@@ -74,7 +74,7 @@ following command:
                attr \
                libbpf-devel \
                keyutils-libs-devel \
-               kernel-devel \
+               kernel-devel-$(uname -r) \
Quoted 8 lines
Quoted 6 lines
README.md +0 -1
                quota \
                xfsprogs-devel \
                libuuid-devel
--

2.17.1

Applied.

Signature · 3 lines
Ondrej Mosnacek <omosnace at redhat dot com>
Software Engineer, Security Technologies
Red Hat, Inc.