ALSA: hda: Cleanup helpers
cover ALSA: hda: Cleanup helpers
Some helper functions are used only locally or not used, here just a simple cleanup.
Takashi
===
Takashi Iwai (2):
ALSA: hda: Drop unused snd_hda_queue_unsol_event()
ALSA: hda: Unexport some local helper functions
include/sound/hda_codec.h | 7 ------- include/sound/hdaudio.h | 3 --- sound/hda/hdac_bus.c | 2 -- sound/hda/hdac_controller.c | 1 + sound/hda/local.h | 3 +++ 5 files changed, 4 insertions(+), 12 deletions(-)
Signature · 1 line
2.16.4
PATCH 1/2 ALSA: hda: Drop unused snd_hda_queue_unsol_event()
The inline function is nowhere used. Drop it.
Signed-off-by Takashi Iwai <[email protected]>
--- include/sound/hda_codec.h | 7 ------- 1 file changed, 7 deletions(-)
include/sound/hda_codec.h +0 -7
@@ -366,13 +366,6 @@ struct hda_verb {void snd_hda_sequence_write (struct hda_codec *codec,const struct hda_verb *seq); -/* unsolicited event */ -static inline void -snd_hda_queue_unsol_event (struct hda_bus *bus,u32 res,u32 res_ex) -{ -snd_hdac_bus_queue_event (&bus->core, res, res_ex); -} -/* cached write */ static inline int snd_hda_codec_write_cache(struct hda_codec *codec, hda_nid_t nid,
Signature · 1 line
2.16.4
PATCH 2/2 ALSA: hda: Unexport some local helper functions
In reply to Takashi Iwaisnd_hdac_bus_queue_event() and snd_hdac_bus_exec_verb() are used only internally in HD-audio core. Let's drop the exports and move the declarations into local.h.
Signed-off-by Takashi Iwai <[email protected]>
--- include/sound/hdaudio.h | 3 --- sound/hda/hdac_bus.c | 2 -- sound/hda/hdac_controller.c | 1 + sound/hda/local.h | 3 +++ 4 files changed, 4 insertions(+), 5 deletions(-)
include/sound/hdaudio.h +0 -3
@@ -372,11 +372,8 @@ struct hdac_bus {int snd_hdac_bus_init (struct hdac_bus *bus,struct device *dev,const struct hdac_bus_ops *ops);void snd_hdac_bus_exit (struct hdac_bus *bus); -int snd_hdac_bus_exec_verb (struct hdac_bus *bus,unsigned int addr, -unsigned int cmd,unsigned int *res);int snd_hdac_bus_exec_verb_unlocked (struct hdac_bus *bus,unsigned int addr,unsigned int cmd,unsigned int *res); -void snd_hdac_bus_queue_event (struct hdac_bus *bus,u32 res,u32 res_ex);static inline void snd_hdac_codec_link_up (struct hdac_device *codec) {
sound/hda/hdac_bus.c +0 -2
@@ -81,7 +81,6 @@ int snd_hdac_bus_exec_verb(struct hdac_bus *bus, unsigned int addr,mutex_unlock (&bus->cmd_mutex);return err; } -EXPORT_SYMBOL_GPL (snd_hdac_bus_exec_verb);/** * snd_hdac_bus_exec_verb_unlocked - unlocked version
@@ -150,7 +149,6 @@ void snd_hdac_bus_queue_event(struct hdac_bus *bus, u32 res, u32 res_ex)schedule_work (&bus->unsol_work); } -EXPORT_SYMBOL_GPL (snd_hdac_bus_queue_event);/* * process queued unsolicited events
sound/hda/hdac_controller.c +1 -0
@@ -9,6 +9,7 @@#include <sound/core.h> #include <sound/hdaudio.h> #include <sound/hda_register.h> +#include "local.h" /* clear CORB read pointer properly */ static void azx_clear_corbrp (struct hdac_bus *bus)
sound/hda/local.h +3 -0
@@ -36,6 +36,9 @@ void hda_widget_sysfs_exit(struct hdac_device *codec);int snd_hdac_bus_add_device (struct hdac_bus *bus,struct hdac_device *codec);void snd_hdac_bus_remove_device (struct hdac_bus *bus,struct hdac_device *codec); +void snd_hdac_bus_queue_event (struct hdac_bus *bus,u32 res,u32 res_ex); +int snd_hdac_bus_exec_verb (struct hdac_bus *bus,unsigned int addr, +unsigned int cmd,unsigned int *res);int snd_hdac_exec_verb (struct hdac_device *codec,unsigned int cmd,unsigned int flags,unsigned int *res);
Signature · 1 line
2.16.4