Skip to contentSkip to conversation

package/python-pyqt5: fix QtLocation module dependency

PATCH New Peter Seiderer 3 participants 3 messages May 16, 2020 – May 26, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/python-pyqt5: fix QtLocation module dependency

The QT module location from qt5location depends on QT quick from qt5declarative.

From qt5location-5.14.2/src/src.pro:

  qtHaveModule(quick) {
      SUBDIRS += positioningquick location
      ...
  }

Adjust pyqt5 QtLocation module dependency accordingly.

Fixes:

- http://autobuild.buildroot.net/results/122bb0a37d968cd79dc043b48f90f1ba4135491f

Reading .../build/python-pyqt5-5.7/QtLocation/QtLocation.pro Project ERROR: Unknown module(s) in QT: location

---
Changes v1 -> v2:
- fix python-pyqt5 QTLocation vs. QtLocation spelling

---
 package/python-pyqt5/python-pyqt5.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
package/python-pyqt5/python-pyqt5.mk +4 -1
index 260a93af9c..9b5e9089fc 100644
@@ -65,7 +65,10 @@ endif
 
 ifeq ($(BR2_PACKAGE_QT5LOCATION),y)
 PYTHON_PYQT5_DEPENDENCIES += qt5location
-PYTHON_PYQT5_MODULES += QtLocation QtPositioning
+PYTHON_PYQT5_MODULES += QtPositioning
+ifeq ($(BR2_PACKAGE_QT5DECLARATIVE_QUICK),y)
+PYTHON_PYQT5_MODULES += QtLocation
+endif
 endif
 
 ifeq ($(BR2_PACKAGE_QT5MULTIMEDIA),y)
Signature · 1 line
2.26.2
#1 lore raw

PATCH v2 1/1 package/python-pyqt5: fix QtLocation module dependency

Peter, All,

On 2020-05-16 13:26 +0200, Peter Seiderer spake thusly:

Quoted 12 lines

The QT module location from qt5location depends on QT quick from qt5declarative.

From qt5location-5.14.2/src/src.pro:

  qtHaveModule(quick) {
      SUBDIRS += positioningquick location
      ...
  }

Adjust pyqt5 QtLocation module dependency accordingly.

Quoted 8 lines

Fixes:

- http://autobuild.buildroot.net/results/122bb0a37d968cd79dc043b48f90f1ba4135491f

Reading .../build/python-pyqt5-5.7/QtLocation/QtLocation.pro Project ERROR: Unknown module(s) in QT: location

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 30 lines

---
Changes v1 -> v2:
- fix python-pyqt5 QTLocation vs. QtLocation spelling

---
 package/python-pyqt5/python-pyqt5.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
package/python-pyqt5/python-pyqt5.mk +4 -1
index 260a93af9c..9b5e9089fc 100644
@@ -65,7 +65,10 @@ endif
 
 ifeq ($(BR2_PACKAGE_QT5LOCATION),y)
 PYTHON_PYQT5_DEPENDENCIES += qt5location
-PYTHON_PYQT5_MODULES += QtLocation QtPositioning
+PYTHON_PYQT5_MODULES += QtPositioning
+ifeq ($(BR2_PACKAGE_QT5DECLARATIVE_QUICK),y)
+PYTHON_PYQT5_MODULES += QtLocation
+endif
 endif
 
 ifeq ($(BR2_PACKAGE_QT5MULTIMEDIA),y)
Signature · 6 lines
2.26.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH v2 1/1 package/python-pyqt5: fix QtLocation module dependency

In reply to Peter Seiderer
Quoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Seiderer <[email protected]> writes:

The QT module location from qt5location depends on QT quick from qt5declarative.

From qt5location-5.14.2/src/src.pro:

  qtHaveModule(quick) {
      SUBDIRS += positioningquick location
      ...
  }

Adjust pyqt5 QtLocation module dependency accordingly.

Fixes:

- http://autobuild.buildroot.net/results/122bb0a37d968cd79dc043b48f90f1ba4135491f

Quoted 7 lines

Reading .../build/python-pyqt5-5.7/QtLocation/QtLocation.pro Project ERROR: Unknown module(s) in QT: location

---
Changes v1 -> v2:
- fix python-pyqt5 QTLocation vs. QtLocation spelling

Committed to 2020.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard