drm/tegra: gr3d: Assert reset before power-gating

PATCH Superseded Dmitry Osipenko 1 participant 1 message May 16, 2020

Subsystems (3)

DRM drivers Tegra architecture support DRM drivers for NVIDIA Tegra

lore

Share & tools

lore

Dmitry Osipenko

author

2020-05-16 15:41 UTC #0 lore raw

PATCH 1/1 drm/tegra: gr3d: Assert reset before power-gating

Tegra TRM documentation states that hardware should be in a default state when power partition is turned off, i.e. reset should be asserted. This patch adds the missing reset assertions.

Signed-off-by Dmitry Osipenko <[email protected]>

---
 drivers/gpu/drm/tegra/gr3d.c | 2 ++
 1 file changed, 2 insertions(+)

drivers/gpu/drm/tegra/gr3d.c +2 -0

index c0a528be0369..b0b8154e8104 100644
@@ -381,10 +381,12 @@ static int gr3d_remove(struct platform_device *pdev)
 	}
 
 	if (gr3d->clk_secondary) {
+		reset_control_assert(gr3d->rst_secondary);
 		tegra_powergate_power_off(TEGRA_POWERGATE_3D1);
 		clk_disable_unprepare(gr3d->clk_secondary);
 	}
 
+	reset_control_assert(gr3d->rst);
 	tegra_powergate_power_off(TEGRA_POWERGATE_3D);
 	clk_disable_unprepare(gr3d->clk);

Signature · 1 line

2.26.0