package/usb_modeswitch: fix parallel install
PATCH 1/1 package/usb_modeswitch: fix parallel install
Extract from bug report:
"In usb_modeswitch Makefile dispatcher-script, dispatcher-dynlink and dispatcher-statlink are .PHONY targets. The result is that sources are compiled also when install targets are called. USB_MODESWITCH_INSTALL_TARGET_CMDS calls $(MAKE) which is a call to parallel make eg. make -j9. So the install phase can install empty usb_modeswitch binary (happened once) if the compiler have just cleared the binary and install command installs it before compiler writes the binary. USB_MODESWITCH_INSTALL_TARGET_CMDS should call $(MAKE1)."
Instead of disabling parellel install, use install-common target instead of install-{dyn,stat}link targets. Indeed, the dynamic or static usb_modeswitch_dispatcher binary will be built by all-with-{dyn,stat}link-dispatcher targets, there is no need to rebuild it during the install step
Fixes:
- https://bugs.buildroot.org/show_bug.cgi?id=12911
--- package/usb_modeswitch/usb_modeswitch.mk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
package/usb_modeswitch/usb_modeswitch.mk +1 -2
@@ -17,12 +17,11 @@ USB_MODESWITCH_BUILD_TARGETS = all USB_MODESWITCH_INSTALL_TARGETS = install-script else USB_MODESWITCH_DEPENDENCIES += jimtcl +USB_MODESWITCH_INSTALL_TARGETS = install-common ifeq ($(BR2_STATIC_LIBS),y) USB_MODESWITCH_BUILD_TARGETS = all-with-statlink-dispatcher -USB_MODESWITCH_INSTALL_TARGETS = install-statlink else USB_MODESWITCH_BUILD_TARGETS = all-with-dynlink-dispatcher -USB_MODESWITCH_INSTALL_TARGETS = install-dynlink endif endif
Signature · 1 line
2.26.2
PATCH 1/1 package/usb_modeswitch: fix parallel install
Quoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Fabrice" == Fabrice Fontaine <[email protected]> writes:
Extract from bug report:
"Inusb_modeswitchMakefiledispatcher-script, dispatcher-dynlink and dispatcher-statlink are .PHONY targets. The result is that sources are compiled also when install targets are called.USB_MODESWITCH_INSTALL_TARGET_CMDScalls $(MAKE) which is a call to parallel make eg. make -j9. So the install phase can install emptyusb_modeswitchbinary (happened once) if the compiler have just cleared the binary and install command installs it before compiler writes the binary.USB_MODESWITCH_INSTALL_TARGET_CMDSshould call $(MAKE1)."Instead of disabling parellel install, use install-common target instead of install-{dyn,stat}link targets. Indeed, the dynamic or static
usb_modeswitch_dispatcherbinary will be built by all-with-{dyn,stat}link-dispatcher targets, there is no need to rebuild it during the install step
Quoted 4 lines
Fixes:
- https://bugs.buildroot.org/show_bug.cgi?id=12911Signed-off-by Fabrice Fontaine <[email protected]>
Committed to 2020.02.x, 2020.05.x and 2020.08.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard