package/apitrace: force Release mode
PATCH 1/1 package/apitrace: force Release mode
Force Release mode otherwise the toolchain workarounds added by commit 6f5fcb43296ffc54b2b67d0b3723405b56d8d439 will be ignored when debug is enabled as CMAKE_C_FLAGS_RELWITHDEBINFO is appended to CFLAGS:
output/build/apitrace-9.0/thirdparty/brotli/CMakeFiles/brotli_dec.dir/flags.make:C_FLAGS = -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -g2 -O0 -fvisibility=hidden -Wall -Wno-sign-compare -fno-strict-aliasing -fmessage-length=0 -fno-omit-frame-pointer -O2 -g -DNDEBUG -fPIC
Fixes:
- http://autobuild.buildroot.org/results/2e31abd7b115d4c29117ca82007fd4f87f853ff7
--- package/apitrace/apitrace.mk | 2 ++ 1 file changed, 2 insertions(+)
package/apitrace/apitrace.mk +2 -0
@@ -34,7 +34,9 @@ ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y) APITRACE_CXXFLAGS += -O0 endif +# Force Release mode otherwise the above workarounds will be ignored APITRACE_CONF_OPTS += \ + -DCMAKE_BUILD_TYPE=Release \ -DCMAKE_C_FLAGS="$(APITRACE_CFLAGS)" \ -DCMAKE_CXX_FLAGS="$(APITRACE_CXXFLAGS)"
Signature · 1 line
2.26.2
PATCH 1/1 package/apitrace: force Release mode
Quoted 6 lines · On Sun, 17 May 2020 16:05:15 +0200 Fabrice Fontaine…
Force Release mode otherwise the toolchain workarounds added by commit
6f5fcb43296ffc54b2b67d0b3723405b56d8d439will be ignored when debug is enabled asCMAKE_C_FLAGS_RELWITHDEBINFOis appended to CFLAGS:output/build/apitrace-9.0/thirdparty/brotli/CMakeFiles/brotli_dec.dir/flags.make:C_FLAGS = -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -g2 -O0 -fvisibility=hidden -Wall -Wno-sign-compare -fno-strict-aliasing -fmessage-length=0 -fno-omit-frame-pointer -O2 -g -DNDEBUG -fPIC
Quoted 7 lines
Fixes:
- http://autobuild.buildroot.org/results/2e31abd7b115d4c29117ca82007fd4f87f853ff7Signed-off-by Fabrice Fontaine <[email protected]>--- package/apitrace/apitrace.mk | 2 ++ 1 file changed, 2 insertions(+)
This was fixed in a different way in commitce053a2004d089b3080a750496b3b3b21bcc224d.
I've marked this patch as Superseded then.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com