Skip to contentSkip to conversation

driver core: Remove check in driver_deferred_probe_force_trigger()

PATCH New Saravana Kannan 1 participant 1 message May 17, 2020 Driver core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 driver core: Remove check in driver_deferred_probe_force_trigger()

The whole point behind adding driver_deferred_probe_force_trigger() in commit 716a7a259690 ("driver core: fw_devlink: Add support for batching fwnode parsing") was to skip the check for driver_deferred_probe_enable. Otherwise, it's identical to driver_deferred_probe_trigger().

Delete the check in driver_deferred_probe_force_trigger() so that fw_devlink_pause() and fw_devlink_resume() can kick off deferred probe as intended. Without doing this forced deferred probe trigger, some platforms seem to be crashing during boot because they assume probe order of devices.

Fixes 716a7a259690 ("driver core: fw_devlink: Add support for batching fwnode parsing")
---
 drivers/base/dd.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/base/dd.c +0 -3
index 63991d97adcc..9a1d940342ac 100644
@@ -169,9 +169,6 @@ static void driver_deferred_probe_trigger(void)
 
 void driver_deferred_probe_force_trigger(void)
 {
-	if (!driver_deferred_probe_enable)
-		return;
-
 	/*
 	 * A successful probe means that all the devices in the pending list
 	 * should be triggered to be reprobed.  Move all the deferred devices
Signature · 1 line
2.26.2.761.g0e0b3e54be-goog