Skip to contentSkip to conversation

libubootenv: Depend on zlib

PATCH In review Marek Vasut 3 participants 4 messages May 18, 2020 – May 19, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libubootenv: Depend on zlib

The libubootenv depends on zlib as it calls at least crc32() from there and links against it. Add the DEPENDS entry.

---
 meta/recipes-bsp/u-boot/libubootenv_0.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-bsp/u-boot/libubootenv_0.2.bb +1 -1
index 3251d0f05b..fa90a12bf8 100644
@@ -1,5 +1,5 @@
 SUMMARY = "U-Boot libraries and tools to access environment"
-DEPENDS += "mtd-utils"
+DEPENDS += "mtd-utils zlib"
 
 DESCRIPTION = "This package contains tools and libraries to read \
 and modify U-Boot environment. \
Signature · 1 line
2.25.1
#1 lore raw
Quoted 15 lines · Marek Vasut

The libubootenv depends on zlib as it calls at least crc32() from there and links against it. Add the DEPENDS entry.

---
 meta/recipes-bsp/u-boot/libubootenv_0.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-bsp/u-boot/libubootenv_0.2.bb +0 -0
index 3251d0f05b..fa90a12bf8 100644

meta/recipes-bsp/u-boot/libubootenv_0.2.bb line 3

Quoted 4 lines
meta/recipes-bsp/u-boot/libubootenv_0.2.bb +1 -1
@@ -1,5 +1,5 @@
 SUMMARY = "U-Boot libraries and tools to access environment"
-DEPENDS += "mtd-utils"
+DEPENDS += "mtd-utils zlib"
 

should this be a packageconfig

Quoted 6 lines
meta/recipes-bsp/u-boot/libubootenv_0.2.bb +0 -1
 DESCRIPTION = "This package contains tools and libraries to read \
 and modify U-Boot environment. \
--

2.25.1

#2 lore raw

Hi Khem,

Quoted 11 lines · Khem Raj
Quoted 10 lines · Marek Vasut

The libubootenv depends on zlib as it calls at least crc32() from there and links against it. Add the DEPENDS entry.

---
 meta/recipes-bsp/u-boot/libubootenv_0.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 9 lines

meta/recipes-bsp/u-boot/libubootenv_0.2.bb line 3

Quoted 9 lines
meta/recipes-bsp/u-boot/libubootenv_0.2.bb +1 -1
index 3251d0f05b..fa90a12bf8 100644
@@ -1,5 +1,5 @@
 SUMMARY = "U-Boot libraries and tools to access environment"
-DEPENDS += "mtd-utils"
+DEPENDS += "mtd-utils zlib"
 

It can't, it is not an option. U-Boot requires a CRC-32 on the environment and zlib is always linked to the binaries fw_setenv / fw_printenv.

Stefano

Quoted 9 lines

should this be a packageconfig

Quoted 6 lines
meta/recipes-bsp/u-boot/libubootenv_0.2.bb +0 -1
 DESCRIPTION = "This package contains tools and libraries to read \
 and modify U-Boot environment. \
--

2.25.1

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
#3 lore raw
Quoted 15 lines · Stefano Babic

Hi Khem,

Quoted 11 lines · Khem Raj
Quoted 10 lines · Marek Vasut

The libubootenv depends on zlib as it calls at least crc32() from there and links against it. Add the DEPENDS entry.

---
 meta/recipes-bsp/u-boot/libubootenv_0.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines
Quoted 9 lines

meta/recipes-bsp/u-boot/libubootenv_0.2.bb line 3

Quoted 9 lines
meta/recipes-bsp/u-boot/libubootenv_0.2.bb +1 -1
index 3251d0f05b..fa90a12bf8 100644
@@ -1,5 +1,5 @@
 SUMMARY = "U-Boot libraries and tools to access environment"
-DEPENDS += "mtd-utils"
+DEPENDS += "mtd-utils zlib"
 

It can't, it is not an option. U-Boot requires a CRC-32 on the environment and zlib is always linked to the binaries fw_setenv / fw_printenv.

OK thanks

Quoted 19 lines

Stefano

Quoted 9 lines

should this be a packageconfig

Quoted 6 lines
meta/recipes-bsp/u-boot/libubootenv_0.2.bb +0 -1
 DESCRIPTION = "This package contains tools and libraries to read \
 and modify U-Boot environment. \
--

2.25.1

--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================