Skip to contentSkip to conversation

powerpc/papr_scm: Add support for reporting NVDIMM performance statistics

RFC PATCH In review Vaibhav Jain 2 participants 6 messages May 18, 2020 – Oct 21, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover powerpc/papr_scm: Add support for reporting NVDIMM performance statistics

The patch-set proposes to add support for fetching and reporting performance statistics for PAPR compliant NVDIMMs as described in documentation for H_SCM_PERFORMANCE_STATS hcall Ref[1]. The patch-set also implements mechanisms to expose NVDIMM performance stats via sysfs and newly introduced PDSMs[2] for libndctl.

This patch-set combined with corresponding ndctl and libndctl changes proposed at Ref[3] should enable user to fetch PAPR compliant NVDIMMs using following command:

 # ndctl list -D --stats
[
  {
    "dev":"nmem0",
    "stats":{
      "Controller Reset Count":2,
      "Controller Reset Elapsed Time":603331,
      "Power-on Seconds":603931,
      "Life Remaining":"100%",
      "Critical Resource Utilization":"0%",
      "Host Load Count":5781028,
      "Host Store Count":8966800,
      "Host Load Duration":975895365,
      "Host Store Duration":716230690,
      "Media Read Count":0,
      "Media Write Count":6313,
      "Media Read Duration":0,
      "Media Write Duration":9679615,
      "Cache Read Hit Count":5781028,
      "Cache Write Hit Count":8442479,
      "Fast Write Count":8969912
    }
  }
]

The patchset is dependent on existing patch-set "[PATCH v7 0/5] powerpc/papr_scm: Add support for reporting nvdimm health" available at Ref[2] that adds support for reporting PAPR compliant NVDIMMs in 'papr_scm' kernel module.

Structure of the patch-set
==========================

The patch-set starts with implementing functionality in papr_scm module to issue H_SCM_PERFORMANCE_STATS hcall, fetch & parse dimm performance stats and exposing them as a PAPR specific libnvdimm attribute named 'perf_stats'

Patch-2 introduces a new PDSM named FETCH_PERF_STATS that can be issued by libndctl asking papr_scm to issue the H_SCM_PERFORMANCE_STATS hcall using helpers introduced earlier and storing the results in a dimm specific perf-stats-buffer.

Patch-3 introduces a new PDSM named READ_PERF_STATS that can be issued by libndctl to read the perf-stats-buffer in an incremental manner to workaround the 256-bytes envelop limitation of libnvdimm.

Finally Patch-4 introduces a new PDSM named GET_PERF_STAT that can be issued by libndctl to read values of a specific NVDIMM performance stat like "Life Remaining".

References
==========
[1] Documentation/powerpc/papr_hcals.rst

[2] https://lore.kernel.org/linux-nvdimm/[email protected]/

[3] https://github.com/vaibhav92/ndctl/tree/papr_scm_stats_v1

Vaibhav Jain (4):
powerpc/papr_scm: Fetch nvdimm performance stats from PHYP powerpc/papr_scm: Add support for PAPR_SCM_PDSM_FETCH_PERF_STATS powerpc/papr_scm: Implement support for PAPR_SCM_PDSM_READ_PERF_STATS powerpc/papr_scm: Add support for PDSM GET_PERF_STAT

 Documentation/ABI/testing/sysfs-bus-papr-scm  |  27 ++
 arch/powerpc/include/uapi/asm/papr_scm_pdsm.h |  60 +++
 arch/powerpc/platforms/pseries/papr_scm.c     | 391 ++++++++++++++++++
 3 files changed, 478 insertions(+)
Signature · 4 lines
2.26.2
_______________________________________________
Linux-nvdimm mailing list -- [email protected]
To unsubscribe send an email to [email protected]
#1 lore raw

RFC PATCH 1/4 powerpc/papr_scm: Fetch nvdimm performance stats from PHYP

Update papr_scm.c to query dimm performance statistics from PHYP via H_SCM_PERFORMANCE_STATS hcall and export them to userspace as PAPR specific NVDIMM attribute 'perf_stats' in sysfs. The patch also provide a sysfs ABI documentation for the stats being reported and their meanings.

During NVDIMM probe time in papr_scm_nvdimm_init() a special variant of H_SCM_PERFORMANCE_STATS hcall is issued to check if collection of performance statistics is supported or not. If yes then a per-nvdimm performance stats buffer is of size as returned by PHYP is allocated and stored along with its length in two newly introduced NVDIMM private struct members 'perf_stats' and 'len_stat_buffer'.

---
 Documentation/ABI/testing/sysfs-bus-papr-scm |  27 ++++
 arch/powerpc/platforms/pseries/papr_scm.c    | 156 +++++++++++++++++++
 2 files changed, 183 insertions(+)
Documentation/ABI/testing/sysfs-bus-papr-scm +27 -0
index 6143d06072f1..ad06b3e9c315 100644
@@ -25,3 +25,30 @@ Description:
 				  NVDIMM have been scrubbed.
 		* "locked"	: Indicating that NVDIMM contents cant
 				  be modified until next power cycle.
+
+What:		/sys/bus/nd/devices/nmemX/papr/perf_stats
+Date:		May, 2020
+KernelVersion:	v5.8
+Contact:	linuxppc-dev <[email protected]>, [email protected],
+Description:
+		(RO) Report various performance stats related to papr-scm NVDIMM
+		device.  Each stat is reported on a new line with each line
+		composed of a stat-identifier followed by it value. Below are
+		currently known dimm performance stats which are reported:
+
+		* "CtlResCt" : Controller Reset Count
+		* "CtlResTm" : Controller Reset Elapsed Time
+		* "PonSecs " : Power-on Seconds
+		* "MemLife " : Life Remaining
+		* "CritRscU" : Critical Resource Utilization
+		* "HostLCnt" : Host Load Count
+		* "HostSCnt" : Host Store Count
+		* "HostSDur" : Host Store Duration
+		* "HostLDur" : Host Load Duration
+		* "MedRCnt " : Media Read Count
+		* "MedWCnt " : Media Write Count
+		* "MedRDur " : Media Read Duration
+		* "MedWDur " : Media Write Duration
+		* "CchRHCnt" : Cache Read Hit Count
+		* "CchWHCnt" : Cache Write Hit Count
+		* "FastWCnt" : Fast Write Count
\ No newline at end of file
arch/powerpc/platforms/pseries/papr_scm.c +156 -0

198 lines not on this page · raw message

Signature · 4 lines
2.26.2
_______________________________________________
Linux-nvdimm mailing list -- [email protected]
To unsubscribe send an email to [email protected]
#2 lore raw

RFC PATCH 2/4 powerpc/papr_scm: Add support for PAPR_SCM_PDSM_FETCH_PERF_STATS

In reply to Vaibhav Jain

Add support for pdsm PAPR_SCM_PDSM_FETCH_PERF_STATS that issues HCALL H_SCM_PERFORMANCE_STATS to PHYP to fetch all the NVDIMM performance stats and store them in per nvdimm 'struct papr_scm_priv' as member 'perf_stats'. A further PDSM request (introduced later) is needed to read the contents of this performance stats buffer.

A new uapi struct 'nd_psdm_perf_stats_size' is introduced to be used by libndctl to retrieve the size of buffer needed to store all NVDIMM performance stats.

The patch updates papr_scm_service_pdsm() to route PAPR_SCM_PDSM_FETCH_PERF_STATS to newly introduced papr_scm_fetch_perf_stats() which then issues the HCALL and copies the needed size to the PDSM payload.

---
 arch/powerpc/include/uapi/asm/papr_scm_pdsm.h | 13 ++++
 arch/powerpc/platforms/pseries/papr_scm.c     | 70 +++++++++++++++++++
 2 files changed, 83 insertions(+)
arch/powerpc/include/uapi/asm/papr_scm_pdsm.h +13 -0
index db0cf550dabe..40ec55d06f4c 100644
@@ -114,6 +114,7 @@ struct nd_pdsm_cmd_pkg {
 enum papr_scm_pdsm {
 	PAPR_SCM_PDSM_MIN = 0x0,
 	PAPR_SCM_PDSM_HEALTH,
+	PAPR_SCM_PDSM_FETCH_PERF_STATS,
 	PAPR_SCM_PDSM_MAX,
 };
 
@@ -170,4 +171,16 @@ struct nd_papr_pdsm_health_v1 {
 /* Current version number for the dimm health struct */
 #define ND_PAPR_PDSM_HEALTH_VERSION 1
 
+/*
+ * Return the maximum buffer size needed to hold all performance state.
+ * max_stats_size: The buffer size needed to hold all stat entries
+ */
+struct nd_pdsm_fetch_perf_stats_v1 {
+	__u32 max_stats_size;
+	__u8 reserved[4];
+} __packed;
+
+#define nd_pdsm_fetch_perf_stats nd_pdsm_fetch_perf_stats_v1
+#define ND_PDSM_FETCH_PERF_STATS_VERSION 1
+
 #endif /* _UAPI_ASM_POWERPC_PAPR_SCM_PDSM_H_ */
arch/powerpc/platforms/pseries/papr_scm.c +70 -0

82 lines not on this page · raw message

Signature · 4 lines
2.26.2
_______________________________________________
Linux-nvdimm mailing list -- [email protected]
To unsubscribe send an email to [email protected]
#3 lore raw

RFC PATCH 3/4 powerpc/papr_scm: Implement support for PAPR_SCM_PDSM_READ_PERF_STATS

In reply to Vaibhav Jain

Implement support for pdsm READ_PERF_STATS to be used by libndctl to fetch all NVDIMM performance statistics. The stats are to be exchanged via newly introduced 'struct nd_pdsm_get_perf_stats' which is allocated and sent by libndctl to papr_scm. The struct contains members 'in_offset' and 'in_length' to provide incremental access to performance statistics data buffer and workaround 'libnvdimm' limit of 256 bytes evelope size.

The patch introduces new function 'papr_scm_read_perf_stats()' to service this pdsm and copy the requested chunk of performance stats to the libndctl provided payload buffer for the given offset and length.

---
 arch/powerpc/include/uapi/asm/papr_scm_pdsm.h | 35 +++++++
 arch/powerpc/platforms/pseries/papr_scm.c     | 91 +++++++++++++++++++
 2 files changed, 126 insertions(+)
arch/powerpc/include/uapi/asm/papr_scm_pdsm.h +35 -0
index 40ec55d06f4c..2db4ffdff285 100644
@@ -115,6 +115,7 @@ enum papr_scm_pdsm {
 	PAPR_SCM_PDSM_MIN = 0x0,
 	PAPR_SCM_PDSM_HEALTH,
 	PAPR_SCM_PDSM_FETCH_PERF_STATS,
+	PAPR_SCM_PDSM_READ_PERF_STATS,
 	PAPR_SCM_PDSM_MAX,
 };
 
@@ -183,4 +184,38 @@ struct nd_pdsm_fetch_perf_stats_v1 {
 #define nd_pdsm_fetch_perf_stats nd_pdsm_fetch_perf_stats_v1
 #define ND_PDSM_FETCH_PERF_STATS_VERSION 1
 
+/*
+ * Holds a single performance stat. papr_scm owns a buffer that holds an array
+ * of all the available stats and their values. Access to the buffer is provided
+ * via PERF_STAT_SIZE and READ_PERF_STATS psdm.
+ * id : id of the performance stat. Usually acsii encode stat name.
+ * val : Non normalized value of the id.
+ */
+
+struct nd_pdsm_perf_stat {
+	__u64 id;
+	__u64 val;
+};
+
+/*
+ * Returns a chunk of performance stats buffer data to libndctl.
+ * This is needed to overcome the 256 byte envelope size limit enforced by
+ * libnvdimm.
+ * in_offset: The starting offset to perf stats data buffer.
+ * in_length: Length of data to be copied to 'stats_data'
+ * stats_data: Holds the chunk of requested perf stats data buffer.
+ *
+ * Note: To prevent races in reading performance stats, in_offset and in_length
+ * should multiple of 16-Bytes. If they are not then papr_scm will return an
+ * -EINVAL error.
+ */
+struct nd_pdsm_read_perf_stats_v1 {
+	__u32 in_offset;
+	__u32 in_length;
+	struct nd_pdsm_perf_stat stats_data[];
+} __packed;
+
+#define nd_pdsm_read_perf_stats nd_pdsm_read_perf_stats_v1
+#define ND_PDSM_READ_PERF_STATS_VERSION 1
+
 #endif /* _UAPI_ASM_POWERPC_PAPR_SCM_PDSM_H_ */
arch/powerpc/platforms/pseries/papr_scm.c +91 -0

103 lines not on this page · raw message

Signature · 4 lines
2.26.2
_______________________________________________
Linux-nvdimm mailing list -- [email protected]
To unsubscribe send an email to [email protected]
#4 lore raw

RFC PATCH 4/4 powerpc/papr_scm: Add support for PDSM GET_PERF_STAT

In reply to Vaibhav Jain

This patch adds support for retrieving a singled NVDIMM performance stat from PHYP via PDSM GET_PERF_STAT_VERSION. A new uapi 'struct nd_pdsm_get_perf_stat' is introduced that holds a single performance stat and is populated by newly introduced papr_scm_get_perf_stat() by issuing an H_SCM_PERFORMANCE_STATS to PHYP.

---
 arch/powerpc/include/uapi/asm/papr_scm_pdsm.h | 12 +++
 arch/powerpc/platforms/pseries/papr_scm.c     | 74 +++++++++++++++++++
 2 files changed, 86 insertions(+)
arch/powerpc/include/uapi/asm/papr_scm_pdsm.h +12 -0
index 2db4ffdff285..473c4bbddb2f 100644
@@ -116,6 +116,7 @@ enum papr_scm_pdsm {
 	PAPR_SCM_PDSM_HEALTH,
 	PAPR_SCM_PDSM_FETCH_PERF_STATS,
 	PAPR_SCM_PDSM_READ_PERF_STATS,
+	PAPR_SCM_PDSM_GET_PERF_STAT,
 	PAPR_SCM_PDSM_MAX,
 };
 
@@ -218,4 +219,15 @@ struct nd_pdsm_read_perf_stats_v1 {
 #define nd_pdsm_read_perf_stats nd_pdsm_read_perf_stats_v1
 #define ND_PDSM_READ_PERF_STATS_VERSION 1
 
+/*
+ * Fetch the value of single nvdimm performance stat id of which is
+ * stored in 'stat.id'
+ */
+struct nd_pdsm_get_perf_stat_v1 {
+	struct nd_pdsm_perf_stat stat;
+} __packed;
+
+#define nd_pdsm_get_perf_stat nd_pdsm_get_perf_stat_v1
+#define ND_PDSM_GET_PERF_STAT_VERSION 1
+
 #endif /* _UAPI_ASM_POWERPC_PAPR_SCM_PDSM_H_ */
arch/powerpc/platforms/pseries/papr_scm.c +74 -0

86 lines not on this page · raw message

Signature · 4 lines
2.26.2
_______________________________________________
Linux-nvdimm mailing list -- [email protected]
To unsubscribe send an email to [email protected]
#5 lore raw
In reply to Vaibhav Jain

Hello,

apparently this has not received any (public) comments.

Maybe resend without the RFC status?

Clearly the kernel interface must be defined first, and then ndctl can follow and make use of it.

Thanks

Michal

Quoted 75 lines · Vaibhav Jain

The patch-set proposes to add support for fetching and reporting performance statistics for PAPR compliant NVDIMMs as described in documentation for H_SCM_PERFORMANCE_STATS hcall Ref[1]. The patch-set also implements mechanisms to expose NVDIMM performance stats via sysfs and newly introduced PDSMs[2] for libndctl.

This patch-set combined with corresponding ndctl and libndctl changes proposed at Ref[3] should enable user to fetch PAPR compliant NVDIMMs using following command:

 # ndctl list -D --stats
[
  {
    "dev":"nmem0",
    "stats":{
      "Controller Reset Count":2,
      "Controller Reset Elapsed Time":603331,
      "Power-on Seconds":603931,
      "Life Remaining":"100%",
      "Critical Resource Utilization":"0%",
      "Host Load Count":5781028,
      "Host Store Count":8966800,
      "Host Load Duration":975895365,
      "Host Store Duration":716230690,
      "Media Read Count":0,
      "Media Write Count":6313,
      "Media Read Duration":0,
      "Media Write Duration":9679615,
      "Cache Read Hit Count":5781028,
      "Cache Write Hit Count":8442479,
      "Fast Write Count":8969912
    }
  }
]

The patchset is dependent on existing patch-set "[PATCH v7 0/5] powerpc/papr_scm: Add support for reporting nvdimm health" available at Ref[2] that adds support for reporting PAPR compliant NVDIMMs in 'papr_scm' kernel module.

Structure of the patch-set
==========================

The patch-set starts with implementing functionality in papr_scm module to issue H_SCM_PERFORMANCE_STATS hcall, fetch & parse dimm performance stats and exposing them as a PAPR specific libnvdimm attribute named 'perf_stats'

Patch-2 introduces a new PDSM named FETCH_PERF_STATS that can be issued by libndctl asking papr_scm to issue the H_SCM_PERFORMANCE_STATS hcall using helpers introduced earlier and storing the results in a dimm specific perf-stats-buffer.

Patch-3 introduces a new PDSM named READ_PERF_STATS that can be issued by libndctl to read the perf-stats-buffer in an incremental manner to workaround the 256-bytes envelop limitation of libnvdimm.

Finally Patch-4 introduces a new PDSM named GET_PERF_STAT that can be issued by libndctl to read values of a specific NVDIMM performance stat like "Life Remaining".

References
==========
[1] Documentation/powerpc/papr_hcals.rst

[2] https://lore.kernel.org/linux-nvdimm/[email protected]/

[3] https://github.com/vaibhav92/ndctl/tree/papr_scm_stats_v1

Vaibhav Jain (4):
powerpc/papr_scm: Fetch nvdimm performance stats from PHYP powerpc/papr_scm: Add support for PAPR_SCM_PDSM_FETCH_PERF_STATS powerpc/papr_scm: Implement support for PAPR_SCM_PDSM_READ_PERF_STATS powerpc/papr_scm: Add support for PDSM GET_PERF_STAT

Quoted 8 lines
 Documentation/ABI/testing/sysfs-bus-papr-scm  |  27 ++
 arch/powerpc/include/uapi/asm/papr_scm_pdsm.h |  60 +++
 arch/powerpc/platforms/pseries/papr_scm.c     | 391 ++++++++++++++++++
 3 files changed, 478 insertions(+)
Signature · 1 line
2.26.2

_______________________________________________
Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]