Skip to contentSkip to conversation

drm/mediatek: Delete not used of_device_get_match_data

PATCH Applied [email protected] 3 participants 4 messages May 18, 2020 – Jul 4, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/mediatek: Delete not used of_device_get_match_data

From: Matthias Brugger <[email protected]>

The driver will be loaded by via a platform device. So we will need to get the device_node from the parent device. Depending on this we will set the driver data.
As all this is done later already, just delete the call to of_device_get_match_data.

---
 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/mediatek/mtk_drm_drv.c +0 -1
index e2bb0d19ef99..63ec92ba0e92 100644
@@ -447,7 +447,6 @@ static int mtk_drm_probe(struct platform_device *pdev)
 	if (!private)
 		return -ENOMEM;
 
-	private->data = of_device_get_match_data(dev);
 	private->mmsys_dev = dev->parent;
 	if (!private->mmsys_dev) {
 		dev_err(dev, "Failed to get MMSYS device\n");
Signature · 1 line
2.26.2
maintainer Reviewed-by on v1 1/1
#1 lore raw

Hi, Matthias:

<[email protected]> 於 2020年5月18日 週一 下午7:23寫道:

Quoted 9 lines

From: Matthias Brugger <[email protected]>

The driver will be loaded by via a platform device. So we will need to get the device_node from the parent device. Depending on this we will set the driver data.
As all this is done later already, just delete the call to of_device_get_match_data.

Quoted 20 lines
---
 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/mediatek/mtk_drm_drv.c +0 -2
index e2bb0d19ef99..63ec92ba0e92 100644
@@ -447,7 +447,6 @@ static int mtk_drm_probe(struct platform_device *pdev)
        if (!private)
                return -ENOMEM;
 
-       private->data = of_device_get_match_data(dev);
        private->mmsys_dev = dev->parent;
        if (!private->mmsys_dev) {
                dev_err(dev, "Failed to get MMSYS device\n");
--

2.26.2

Reviewed-by on v1 1/1
#2 lore raw
In reply to [email protected]

Hi Matthias,

Quoted 9 lines · On 18/5/20 13:22, [email protected] wrote:

From: Matthias Brugger <[email protected]>

The driver will be loaded by via a platform device. So we will need to get the device_node from the parent device. Depending on this we will set the driver data.
As all this is done later already, just delete the call to of_device_get_match_data.

Quoted 10 lines
---
 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/mediatek/mtk_drm_drv.c +0 -0
index e2bb0d19ef99..63ec92ba0e92 100644

drivers/gpu/drm/mediatek/mtk_drm_drv.c static int mtk_drm_probe(struct platform_device *pdev) · line 452

Quoted 7 lines
drivers/gpu/drm/mediatek/mtk_drm_drv.c +0 -1
@@ -447,7 +447,6 @@ static int mtk_drm_probe(struct platform_device *pdev)
 	if (!private)
 		return -ENOMEM;
 
-	private->data = of_device_get_match_data(dev);
 	private->mmsys_dev = dev->parent;
 	if (!private->mmsys_dev) {
 		dev_err(dev, "Failed to get MMSYS device\n");

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer Applied
#3 lore raw
In reply to [email protected]

Hi, Matthias:

<[email protected]> 於 2020年5月18日 週一 下午7:23寫道:

Quoted 8 lines

From: Matthias Brugger <[email protected]>

The driver will be loaded by via a platform device. So we will need to get the device_node from the parent device. Depending on this we will set the driver data.
As all this is done later already, just delete the call to of_device_get_match_data.

Applied to mediatek-drm-fixes [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes

Regards,
Chun-Kuang.

Quoted 19 lines
---
 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/mediatek/mtk_drm_drv.c +0 -2
index e2bb0d19ef99..63ec92ba0e92 100644
@@ -447,7 +447,6 @@ static int mtk_drm_probe(struct platform_device *pdev)
        if (!private)
                return -ENOMEM;
 
-       private->data = of_device_get_match_data(dev);
        private->mmsys_dev = dev->parent;
        if (!private->mmsys_dev) {
                dev_err(dev, "Failed to get MMSYS device\n");
--
Quoted 2 lines

2.26.2

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel