Skip to contentSkip to conversation

unicode-ucd: Remove pointless license check

PATCH In review Adrian Bunk 2 participants 3 messages May 18, 2020 – May 19, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 unicode-ucd: Remove pointless license check

WARNING: unicode-ucd-12.1.0-r0 do_fetch: Checksum mismatch for local file /home/bunk/yoctomaster/yocto-tmp/downloads/unicode.org.license.html
Cleaning and trying again.
WARNING: unicode-ucd-12.1.0-r0 do_fetch: Renaming /home/bunk/yoctomaster/yocto-tmp/downloads/unicode.org.license.html to /home/bunk/yoctomaster/yocto-tmp/downloads/unicode.org.license.html_bad-checksum_e9dd7d435db23241be3be21b5fca729b5cf883c8c039a70ea093031420d06abb
WARNING: unicode-ucd-12.1.0-r0 do_fetch: Checksum failure encountered with download of https://www.unicode.org/license.html;name=license;subdir=unicode-ucd-12.1.0;downloadfilename=unicode.org.license.html - will attempt other sources if available

This downloaded a license file from upstream.
The upstream file did not match (copyright year changed). A stale copy was downloaded from a mirror instead and checked. The stale file with known contents never changes.

---
 meta-oe/recipes-support/unicode-ucd/unicode-ucd_12.1.0.bb | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
meta-oe/recipes-support/unicode-ucd/unicode-ucd_12.1.0.bb +2 -5
index 89ab565ce..dc1251777 100644
@@ -1,18 +1,15 @@
 SUMMARY = "Unicode Character Database"
 HOMEPAGE = "https://unicode.org/ucd/"
 LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://unicode.org.license.html;beginline=42;endline=85;md5=67619d0c52706853c0256514e7fd04cd"
+
+ERROR_QA_remove = "license-checksum"
 
 SRC_URI = " \
     https://www.unicode.org/Public/zipped/${PV}/UCD.zip;name=ucd;subdir=ucd \
-    https://www.unicode.org/license.html;name=license;subdir=${BP};downloadfilename=unicode.org.license.html \
 "
 SRC_URI[ucd.md5sum] = "430cbdac2615451571dd69a976dd08f6"
 SRC_URI[ucd.sha256sum] = "25ba51a0d4c6fa41047b7a5e5733068d4a734588f055f61e85f450097834a0a6"
 
-SRC_URI[license.md5sum] = "f03bafb623258f85ff2032c1ce567b7c"
-SRC_URI[license.sha256sum] = "983225207de8a707d0903a8d70fb7a4b28c5e0f64f2366e84a6192a2d618fed4"
-
 inherit allarch
 
 do_configure[noexec] = "1"
Signature · 1 line
2.17.1
#1 lore raw
Quoted 33 lines · Adrian Bunk

WARNING: unicode-ucd-12.1.0-r0 do_fetch: Checksum mismatch for local file /home/bunk/yoctomaster/yocto-tmp/downloads/unicode.org.license.html
Cleaning and trying again.
WARNING: unicode-ucd-12.1.0-r0 do_fetch: Renaming /home/bunk/yoctomaster/yocto-tmp/downloads/unicode.org.license.html to /home/bunk/yoctomaster/yocto-tmp/downloads/unicode.org .license.html_bad-checksum_e9dd7d435db23241be3be21b5fca729b5cf883c8c039a70ea093031420d06abb
WARNING: unicode-ucd-12.1.0-r0 do_fetch: Checksum failure encountered with download of
https://www.unicode.org/license.html;name=license;subdir=unicode-ucd-12.1.0;downloadfilename=unicode.org.license.html
- will attempt other sources if available

This downloaded a license file from upstream.
The upstream file did not match (copyright year changed). A stale copy was downloaded from a mirror instead and checked. The stale file with known contents never changes.

---
 meta-oe/recipes-support/unicode-ucd/unicode-ucd_12.1.0.bb | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
meta-oe/recipes-support/unicode-ucd/unicode-ucd_12.1.0.bb +0 -1
index 89ab565ce..dc1251777 100644
@@ -1,18 +1,15 @@
 SUMMARY = "Unicode Character Database"
 HOMEPAGE = "https://unicode.org/ucd/"
 LICENSE = "MIT"
-LIC_FILES_CHKSUM =

"file://unicode.org.license.html;beginline=42;endline=85;md5=67619d0c52706853c0256514e7fd04cd"

meta-oe/recipes-support/unicode-ucd/unicode-ucd_12.1.0.bb line 5

Quoted 2 lines
meta-oe/recipes-support/unicode-ucd/unicode-ucd_12.1.0.bb +2 -0
+
+ERROR_QA_remove = "license-checksum"

Isn’t there any other file in archive to checksum ?
If not perhaps add one or compare against the MIT template from licenses from OE-core having no entry can trip post processing tools

Quoted 24 lines

SRC_URI = " \

https://www.unicode.org/Public/zipped/${PV}/UCD.zip;name=ucd;subdir=ucd \
-
https://www.unicode.org/license.html;name=license;subdir=${BP};downloadfilename=unicode.org.license.html
\
"
SRC_URI[ucd.md5sum] = "430cbdac2615451571dd69a976dd08f6" SRC_URI[ucd.sha256sum] =
"25ba51a0d4c6fa41047b7a5e5733068d4a734588f055f61e85f450097834a0a6"

meta-oe/recipes-support/unicode-ucd/unicode-ucd_12.1.0.bb +0 -2
-SRC_URI[license.md5sum] = "f03bafb623258f85ff2032c1ce567b7c"
-SRC_URI[license.sha256sum] =

"983225207de8a707d0903a8d70fb7a4b28c5e0f64f2366e84a6192a2d618fed4" -
inherit allarch

do_configure[noexec] = "1"
--
2.17.1

#2 lore raw
Quoted 4 lines · Khem Raj

Isn’t there any other file in archive to checksum ?
If not perhaps add one or compare against the MIT template from licenses from OE-core having no entry can trip post processing tools

I've sent a new version that adds a local copy of the license.

cu
Adrian