iio: imu: bmi160: added regulator and mount-matrix support
Subsystems (2)
cover iio: imu: bmi160: added regulator and mount-matrix support
Convert txt format documentation to yaml.
Add documentation about vdd-supply, vddio-supply and mount-matrix.
Add vdd-supply and vddio-supply support. Without this support, vdd and vddio should be set to always-on in device tree.
Add mount-matrix binding support. As chip could have different orientations a mount matrix support is needed to correctly translate these differences
Jonathan Albrieux (4):
dt-bindings: iio: imu: bmi160: convert txt format to yaml
dt-bindings: iio: imu: bmi160: add regulators and mount-matrix
iio: imu: bmi160: added regulator support
iio: imu: bmi160: added mount-matrix support
.../devicetree/bindings/iio/imu/bmi160.txt | 37 ------ .../devicetree/bindings/iio/imu/bmi160.yaml | 105 ++++++++++++++++++ drivers/iio/imu/bmi160/bmi160.h | 3 + drivers/iio/imu/bmi160/bmi160_core.c | 47 +++++++- 4 files changed, 154 insertions(+), 38 deletions(-) delete mode 100644 Documentation/devicetree/bindings/iio/imu/bmi160.txt create mode 100644 Documentation/devicetree/bindings/iio/imu/bmi160.yaml
Signature · 1 line
2.17.1
PATCH 1/4 dt-bindings: iio: imu: bmi160: convert txt format to yaml
Converts documentation from txt format to yaml
--- .../devicetree/bindings/iio/imu/bmi160.txt | 37 -------- .../devicetree/bindings/iio/imu/bmi160.yaml | 84 +++++++++++++++++++ 2 files changed, 84 insertions(+), 37 deletions(-) delete mode 100644 Documentation/devicetree/bindings/iio/imu/bmi160.txt create mode 100644 Documentation/devicetree/bindings/iio/imu/bmi160.yaml
Documentation/devicetree/bindings/iio/imu/bmi160.txt deleted +0 -37
@@ -1,37 +0,0 @@ -Bosch BMI160 - Inertial Measurement Unit with Accelerometer, Gyroscope -and externally connectable Magnetometer - -https://www.bosch-sensortec.com/bst/products/all_products/bmi160 - -Required properties: - - compatible : should be "bosch,bmi160" - - reg : the I2C address or SPI chip select number of the sensor - - spi-max-frequency : set maximum clock frequency (only for SPI) - -Optional properties: - - interrupts : interrupt mapping for IRQ - - interrupt-names : set to "INT1" if INT1 pin should be used as interrupt - input, set to "INT2" if INT2 pin should be used instead - - drive-open-drain : set if the specified interrupt pin should be configured as - open drain. If not set, defaults to push-pull. - -Examples: - -bmi160@68 { - compatible = "bosch,bmi160"; - reg = <0x68>; - - interrupt-parent = <&gpio4>; - interrupts = <12 IRQ_TYPE_EDGE_RISING>; - interrupt-names = "INT1"; -}; - -bmi160@0 { - compatible = "bosch,bmi160"; - reg = <0>; - spi-max-frequency = <10000000>; - - interrupt-parent = <&gpio2>; - interrupts = <12 IRQ_TYPE_LEVEL_LOW>; - interrupt-names = "INT2"; -};
Documentation/devicetree/bindings/iio/imu/bmi160.yaml new file +84 -0
84 lines not on this page · raw message
Signature · 1 line
2.17.1
PATCH 2/4 dt-bindings: iio: imu: bmi160: add regulators and mount-matrix
In reply to Jonathan AlbrieuxAdd vdd-supply and vddio-supply support.
Add mount-matrix support.
--- .../devicetree/bindings/iio/imu/bmi160.yaml | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+)
Documentation/devicetree/bindings/iio/imu/bmi160.yaml +21 -0
@@ -46,6 +46,21 @@ properties: set if the specified interrupt pin should be configured as open drain. If not set, defaults to push-pull. + vdd-supply: + maxItems: 1 + description: | + an optional regulator that needs to be on to provide VDD power to + the sensor. + + vddio-supply: + maxItems: 1 + description: | + an optional regulator that needs to be on to provide the VDD IO power to + the sensor. + + mount-matrix: + description: an optional 3x3 mounting rotation matrix + required: - compatible - reg
@@ -61,9 +76,15 @@ examples: bmi160@68 { compatible = "bosch,bmi160"; reg = <0x68>; + vdd-supply = <&pm8916_l17>; + vddio-supply = <&pm8916_l6>; interrupt-parent = <&gpio4>; interrupts = <12 1>; interrupt-names = "INT1"; + mount-matrix = "0", "1", "0", + "-1", "0", "0", + "0", "0", "1"; + }; }; - | // Example for SPI
Signature · 1 line
2.17.1
PATCH 3/4 iio: imu: bmi160: added regulator support
In reply to Jonathan Albrieux--- drivers/iio/imu/bmi160/bmi160.h | 2 ++ drivers/iio/imu/bmi160/bmi160_core.c | 27 ++++++++++++++++++++++++++- 2 files changed, 28 insertions(+), 1 deletion(-)
drivers/iio/imu/bmi160/bmi160.h +2 -0
@@ -3,10 +3,12 @@#define BMI160_H_ #include <linux/iio/iio.h> +#include <linux/regulator/consumer.h> struct bmi160_data {struct regmap *regmap;struct iio_trigger *trig; +struct regulator_bulk_data supplies[2 ]; };extern const struct regmap_config bmi160_regmap_config;
drivers/iio/imu/bmi160/bmi160_core.c +26 -1
@@ -15,6 +15,7 @@#include <linux/delay.h> #include <linux/irq.h> #include <linux/of_irq.h> +#include <linux/regulator/consumer.h> #include <linux/iio/iio.h> #include <linux/iio/triggered_buffer.h>
@@ -709,6 +710,12 @@ static int bmi160_chip_init(struct bmi160_data *data, bool use_spi)unsigned int val;struct device *dev =regmap_get_device (data->regmap); + ret =regulator_bulk_enable (ARRAY_SIZE (data->supplies), data->supplies); +if (ret) { +dev_err (dev,"Failed to enable regulators: %d\n" , ret); +return ret; + } + ret =regmap_write (data->regmap,BMI160_REG_CMD ,BMI160_CMD_SOFTRESET );if (ret)return ret;
@@ -793,9 +800,17 @@ int bmi160_probe_trigger(struct iio_dev *indio_dev, int irq, u32 irq_type)static void bmi160_chip_uninit (void *data) {struct bmi160_data *bmi_data = data; +struct device *dev =regmap_get_device (bmi_data->regmap); +int ret;bmi160_set_mode (bmi_data,BMI160_GYRO , false);bmi160_set_mode (bmi_data,BMI160_ACCEL , false); + + ret =regulator_bulk_disable (ARRAY_SIZE (bmi_data->supplies), + bmi_data->supplies); +if (ret) { +dev_err (dev,"Failed to disable regulators: %d\n" , ret); + } } int bmi160_core_probe(struct device *dev, struct regmap *regmap,
@@ -815,6 +830,16 @@ int bmi160_core_probe(struct device *dev, struct regmap *regmap,dev_set_drvdata (dev, indio_dev); data->regmap = regmap; + data->supplies[0 ].supply ="vdd" ; + data->supplies[1 ].supply ="vddio" ; + ret =devm_regulator_bulk_get (dev, +ARRAY_SIZE (data->supplies), + data->supplies); +if (ret) { +dev_err (dev,"Failed to get regulators: %d\n" , ret); +return ret; + } + ret =bmi160_chip_init (data, use_spi);if (ret)return ret;
@@ -853,6 +878,6 @@ int bmi160_core_probe(struct device *dev, struct regmap *regmap, }EXPORT_SYMBOL_GPL (bmi160_core_probe); -MODULE_AUTHOR ("Daniel Baluta <[email protected]" ); +MODULE_AUTHOR ("Daniel Baluta <[email protected]>" );MODULE_DESCRIPTION ("Bosch BMI160 driver" );MODULE_LICENSE ("GPL v2" );
Signature · 1 line
2.17.1
PATCH 4/4 iio: imu: bmi160: added mount-matrix support
In reply to Jonathan AlbrieuxAdd mount-matrix binding support. As chip could have different orientations a mount matrix support is needed to correctly translate these differences
--- drivers/iio/imu/bmi160/bmi160.h | 1 + drivers/iio/imu/bmi160/bmi160_core.c | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+)
drivers/iio/imu/bmi160/bmi160.h +1 -0
@@ -9,6 +9,7 @@ struct bmi160_data {struct regmap *regmap;struct iio_trigger *trig;struct regulator_bulk_data supplies[2 ]; +struct iio_mount_matrix orientation; };extern const struct regmap_config bmi160_regmap_config;
drivers/iio/imu/bmi160/bmi160_core.c +20 -0
@@ -110,6 +110,7 @@ .storagebits = 16, \ .endianness = IIO_LE, \ }, \ + .ext_info = bmi160_ext_info, \ }/* scan indexes follow DATA register order */
@@ -265,6 +266,20 @@ static const struct bmi160_odr_item bmi160_odr_table[] = { }, }; +static const struct iio_mount_matrix * +bmi160_get_mount_matrix (const struct iio_dev *indio_dev, +const struct iio_chan_spec *chan) +{ +struct bmi160_data *data =iio_priv (indio_dev); + +return &data->orientation; +} + +static const struct iio_chan_spec_ext_info bmi160_ext_info[] = { +IIO_MOUNT_MATRIX (IIO_SHARED_BY_DIR , bmi160_get_mount_matrix), + { } +}; +static const struct iio_chan_spec bmi160_channels[] = {BMI160_CHANNEL (IIO_ACCEL ,X ,BMI160_SCAN_ACCEL_X ),BMI160_CHANNEL (IIO_ACCEL ,Y ,BMI160_SCAN_ACCEL_Y ),
@@ -840,6 +855,11 @@ int bmi160_core_probe(struct device *dev, struct regmap *regmap,return ret; } + ret =iio_read_mount_matrix (dev,"mount-matrix" , + &data->orientation); +if (ret) +return ret; + ret =bmi160_chip_init (data, use_spi);if (ret)return ret;
Signature · 1 line
2.17.1