Skip to contentSkip to conversation

ci/config: correct instruction for CI preferences

PATCH In review Đoàn Trần Công Danh 2 participants 2 messages May 18, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ci/config: correct instruction for CI preferences

From e76eec3554 (ci: allow per-branch config for GitHub Actions, 2020-05-07), we started to allow contributors decide which branch they want to build with GitHub Actions
by checking for a file named "ci/config/allow-ref".

In order to assist those contributors,
we provided a sample in "ci/config/allow-refs.sample", and instructed them to drop the ".sample", then commit that file to their repository.

We've misspelt the filename in that change.
Let's fix the spelling.

While we're at it, also instruct our contributors introduce that new file to Git before commit, in case of they've never told Git before.

---

This is a merge from:
<[email protected]>
<[email protected]>

It's slipped over the crack.

Hence, it may need Peff's SoB.
Cc: Jeff King <[email protected]>
Cc: Junio C Hamano <[email protected]>

 ci/config/{allow-refs.sample => allow-ref.sample} | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 rename ci/config/{allow-refs.sample => allow-ref.sample} (91%)
ci/config/allow-ref.sample renamed from ci/config/allow-refs.sample +3 -2
similarity index 91%
rename from ci/config/allow-refs.sample
rename to ci/config/allow-ref.sample
index f157f1945a..af0e076f8a 100755
@@ -7,8 +7,9 @@
 # your repository:
 #
 #   git checkout -b ci-config
-#   cp allow-refs.sample allow-refs
-#   $EDITOR allow-refs
+#   cp allow-ref.sample allow-ref
+#   $EDITOR allow-ref
+#   git add allow-ref
 #   git commit -am "implement my ci preferences"
 #   git push
 #
Signature · 1 line
2.26.2.672.g232c24e857
#1 lore raw
Quoted 16 lines · Đoàn Trần Công Danh

From e76eec3554 (ci: allow per-branch config for GitHub Actions, 2020-05-07), we started to allow contributors decide which branch they want to build with GitHub Actions
by checking for a file named "ci/config/allow-ref".

In order to assist those contributors,
we provided a sample in "ci/config/allow-refs.sample", and instructed them to drop the ".sample", then commit that file to their repository.

We've misspelt the filename in that change.
Let's fix the spelling.

While we're at it, also instruct our contributors introduce that new file to Git before commit, in case of they've never told Git before.

Quoted 8 lines

---

This is a merge from:
<[email protected]>
<[email protected]>

It's slipped over the crack.

Yep, looks good. thanks for tying up this loose end.

Quoted 2 lines

Hence, it may need Peff's SoB.
Cc: Jeff King <[email protected]>

-Peff