mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()
Subsystems (5)
John Hubbard
reviewercover mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()
This needs to go through Andrew's -mm tree, due to adding a new gup.c routine. However, I would really love to have some testing from the drm/i915 folks, because I haven't been able to run-time test that part of it.
Otherwise, though, the series has passed my basic run time testing:
some LTP tests, some xfs and etx4 non-destructive xfstests, and an assortment of other smaller ones: vm selftests, io_uring_register, a few more. But that's only on one particular machine. Also, cross-compile tests for half a dozen arches all pass.
Details:
In order to convert the drm/i915 driver from get_user_pages() to pin_user_pages(), a FOLL_PIN equivalent of __get_user_pages_fast() was required. That led to refactoring __get_user_pages_fast(), with the following goals:
1) As above: provide a pin_user_pages*() routine for drm/i915 to call, in place of __get_user_pages_fast(),
2) Get rid of the gup.c duplicate code for walking page tables with interrupts disabled. This duplicate code is a minor maintenance problem anyway.
3) Make it easy for an upcoming patch from Souptick, which aims to convert __get_user_pages_fast() to use a gup_flags argument, instead of a bool writeable arg. Also, if this series looks good, we can ask Souptick to change the name as well, to whatever the consensus is. My initial recommendation is: get_user_pages_fast_only(), to match the new pin_user_pages_only().
John Hubbard (4):
mm/gup: move __get_user_pages_fast() down a few lines in gup.c mm/gup: refactor and de-duplicate gup_fast() code mm/gup: introduce pin_user_pages_fast_only() drm/i915: convert get_user_pages() --> pin_user_pages()
drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 22 +-- include/linux/mm.h | 3 + mm/gup.c | 150 ++++++++++++-------- 3 files changed, 107 insertions(+), 68 deletions(-)
base-commit: 642b151f45dd54809ea00ecd3976a56c1ec9b53d
Signature · 1 line
2.26.2
John Hubbard
reviewerPATCH 1/4 mm/gup: move __get_user_pages_fast() down a few lines in gup.c
This is in order to avoid a forward declaration of internal_get_user_pages_fast(), in the next patch.
This is code movement only--all generated code should be identical.
--- mm/gup.c | 112 +++++++++++++++++++++++++++---------------------------- 1 file changed, 56 insertions(+), 56 deletions(-)
mm/gup.c +56 -56
@@ -2666,62 +2666,6 @@ static bool gup_fast_permitted(unsigned long start, unsigned long end) }#endif -/* -* Like get_user_pages_fast() except it's IRQ-safe in that it won't fall back to -* the regular GUP. -* Note a difference with get_user_pages_fast: this always returns the -* number of pages pinned, 0 if no pages were pinned. -* -* If the architecture does not support this function, simply return with no -* pages pinned. -*/ -int __get_user_pages_fast (unsigned long start,int nr_pages,int write, -struct page **pages) -{ -unsigned long len, end; -unsigned long flags; -int nr_pinned =0 ; -/* -* Internally (within mm/gup.c), gup fast variants must set FOLL_GET, -* because gup fast is always a "pin with a +1 page refcount" request. -*/ -unsigned int gup_flags =FOLL_GET ; - -if (write) - gup_flags |=FOLL_WRITE ; - - start =untagged_addr (start) &PAGE_MASK ; - len = (unsigned long ) nr_pages <<PAGE_SHIFT ; - end = start + len; - -if (end <= start) -return 0 ; -if (unlikely (!access_ok ((void __user *)start, len))) -return 0 ; - -/* -* Disable interrupts. We use the nested form as we can already have -* interrupts disabled by get_futex_key. -* -* With interrupts disabled, we block page table pages from being -* freed from under us. See struct mmu_table_batch comments in -* include/asm-generic/tlb.h for more details. -* -* We do not adopt an rcu_read_lock(.) here as we also want to -* block IPIs that come from THPs splitting. -*/ - -if (IS_ENABLED (CONFIG_HAVE_FAST_GUP ) && -gup_fast_permitted (start, end)) { -local_irq_save (flags); -gup_pgd_range (start, end, gup_flags, pages, &nr_pinned); -local_irq_restore (flags); - } - -return nr_pinned; -} -EXPORT_SYMBOL_GPL (__get_user_pages_fast); -static int __gup_longterm_unlocked (unsigned long start,int nr_pages,unsigned int gup_flags,struct page **pages) {
@@ -2794,6 +2738,62 @@ static int internal_get_user_pages_fast(unsigned long start, int nr_pages,return ret; } +/* +* Like get_user_pages_fast() except it's IRQ-safe in that it won't fall back to +* the regular GUP. +* Note a difference with get_user_pages_fast: this always returns the +* number of pages pinned, 0 if no pages were pinned. +* +* If the architecture does not support this function, simply return with no +* pages pinned. +*/ +int __get_user_pages_fast (unsigned long start,int nr_pages,int write, +struct page **pages) +{ +unsigned long len, end; +unsigned long flags; +int nr_pinned =0 ; +/* +* Internally (within mm/gup.c), gup fast variants must set FOLL_GET, +* because gup fast is always a "pin with a +1 page refcount" request. +*/ +unsigned int gup_flags =FOLL_GET ; + +if (write) + gup_flags |=FOLL_WRITE ; + + start =untagged_addr (start) &PAGE_MASK ; + len = (unsigned long ) nr_pages <<PAGE_SHIFT ; + end = start + len; + +if (end <= start) +return 0 ; +if (unlikely (!access_ok ((void __user *)start, len))) +return 0 ; + +/* +* Disable interrupts. We use the nested form as we can already have +* interrupts disabled by get_futex_key. +* +* With interrupts disabled, we block page table pages from being +* freed from under us. See struct mmu_table_batch comments in +* include/asm-generic/tlb.h for more details. +* +* We do not adopt an rcu_read_lock(.) here as we also want to +* block IPIs that come from THPs splitting. +*/ + +if (IS_ENABLED (CONFIG_HAVE_FAST_GUP ) && +gup_fast_permitted (start, end)) { +local_irq_save (flags); +gup_pgd_range (start, end, gup_flags, pages, &nr_pinned); +local_irq_restore (flags); + } + +return nr_pinned; +} +EXPORT_SYMBOL_GPL (__get_user_pages_fast); +/** * get_user_pages_fast() - pin user pages in memory * @start: starting user address
Signature · 1 line
2.26.2
John Hubbard
reviewerPATCH 2/4 mm/gup: refactor and de-duplicate gup_fast() code
In reply to John HubbardThere were two nearly identical sets of code for gup_fast() style of walking the page tables with interrupts disabled. This has lead to the usual maintenance problems that arise from having duplicated code.
There is already a core internal routine in gup.c for gup_fast(), so just enhance it very slightly: allow skipping the fall-back to "slow" (regular) get_user_pages(), via the new FOLL_FAST_ONLY flag. Then, just call internal_get_user_pages_fast() from __get_user_pages_fast(), and adjust the API to match pre-existing API behavior.
There is a change in behavior from this refactoring: the nested form of interrupt disabling is used in all gup_fast() variants now. That's because there is only one place that interrupt disabling for page walking is done, and so the safer form is required. This should, if anything, eliminate possible (rare) bugs, because the non-nested form of enabling interrupts was fragile at best.
--- include/linux/mm.h | 1 + mm/gup.c | 60 ++++++++++++++++++++++------------------------ 2 files changed, 29 insertions(+), 32 deletions(-)
include/linux/mm.h +1 -0
@@ -2782,6 +2782,7 @@ struct page *follow_page(struct vm_area_struct *vma, unsigned long address,#define FOLL_LONGTERM 0x10000/* mapping lifetime is indefinite: see below */ #define FOLL_SPLIT_PMD 0x20000/* split huge pmd before returning */ #define FOLL_PIN 0x40000/* pages must be released via unpin_user_page */ +#define FOLL_FAST_ONLY 0x80000/* gup_fast: prevent fall-back to slow gup */ /* * FOLL_PIN and FOLL_LONGTERM may be used in various combinations with each
mm/gup.c +28 -32
94 lines not on this page · raw message
Signature · 1 line
2.26.2
John Hubbard
reviewerPATCH 3/4 mm/gup: introduce pin_user_pages_fast_only()
In reply to John HubbardThis is the FOLL_PIN equivalent of __get_user_pages_fast(), except with a more descriptive name, and gup_flags instead of a boolean "write" in the argument list.
--- include/linux/mm.h | 2 ++ mm/gup.c | 36 ++++++++++++++++++++++++++++++++++++ 2 files changed, 38 insertions(+)
include/linux/mm.h +2 -0
@@ -1820,6 +1820,8 @@ extern int mprotect_fixup(struct vm_area_struct *vma,*/ int __get_user_pages_fast (unsigned long start,int nr_pages,int write,struct page **pages); +int pin_user_pages_fast_only (unsigned long start,int nr_pages, +unsigned int gup_flags,struct page **pages);/* * per-process(per-mm_struct) statistics. */
mm/gup.c +36 -0
@@ -2858,6 +2858,42 @@ int pin_user_pages_fast(unsigned long start, int nr_pages, }EXPORT_SYMBOL_GPL (pin_user_pages_fast); +/* +* This is the FOLL_PIN equivalent of __get_user_pages_fast(). Behavior is the +* same, except that this one sets FOLL_PIN instead of FOLL_GET. +* +* The API rules are the same, too: no negative values may be returned. +*/ +int pin_user_pages_fast_only (unsigned long start,int nr_pages, +unsigned int gup_flags,struct page **pages) +{ +int nr_pinned; + +/* +* FOLL_GET and FOLL_PIN are mutually exclusive. Note that the API +* rules require returning 0, rather than -errno: +*/ +if (WARN_ON_ONCE (gup_flags &FOLL_GET )) +return 0 ; +/* +* FOLL_FAST_ONLY is required in order to match the API description of +* this routine: no fall back to regular ("slow") GUP. +*/ + gup_flags |= (FOLL_PIN |FOLL_FAST_ONLY ); + nr_pinned =internal_get_user_pages_fast (start, nr_pages, gup_flags, + pages); +/* +* This routine is not allowed to return negative values. However, +* internal_get_user_pages_fast() *can* return -errno. Therefore, +* correct for that here: +*/ +if (nr_pinned <0 ) + nr_pinned =0 ; + +return nr_pinned; +} +EXPORT_SYMBOL_GPL (pin_user_pages_fast_only); +/** * pin_user_pages_remote() - pin pages of a remote process (task != current) *
Signature · 1 line
2.26.2
John Hubbard
reviewerPATCH 4/4 drm/i915: convert get_user_pages() --> pin_user_pages()
In reply to John HubbardThis code was using get_user_pages*(), in a "Case 2" scenario (DMA/RDMA), using the categorization from [1]. That means that it's time to convert the get_user_pages*() + put_page() calls to pin_user_pages*() + unpin_user_pages() calls.
There is some helpful background in [2]: basically, this is a small part of fixing a long-standing disconnect between pinning pages, and file systems' use of those pages.
[1] Documentation/core-api/pin_user_pages.rst
[2] "Explicit pinning of user-space pages":
https://lwn.net/Articles/807108/
--- drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 22 ++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_userptr.c +13 -9
@@ -471,7 +471,7 @@ __i915_gem_userptr_get_pages_worker(struct work_struct *_work)down_read (&mm->mmap_sem); locked =1 ; } - ret = get_user_pages_remote + ret = pin_user_pages_remote (work->task, mm, obj->userptr.ptr + pinned * PAGE_SIZE, npages - pinned,
@@ -507,7 +507,7 @@ __i915_gem_userptr_get_pages_worker(struct work_struct *_work) }mutex_unlock (&obj->mm.lock); -release_pages (pvec, pinned); +unpin_user_pages (pvec, pinned);kvfree (pvec);i915_gem_object_put (obj);
@@ -564,6 +564,7 @@ static int i915_gem_userptr_get_pages(struct drm_i915_gem_object *obj)struct sg_table *pages;bool active;int pinned; +unsigned int gup_flags =0 ;/* If userspace should engineer that these pages are replaced in * the vma between us binding this page into the GTT and completion
@@ -598,11 +599,14 @@ static int i915_gem_userptr_get_pages(struct drm_i915_gem_object *obj)GFP_KERNEL | __GFP_NORETRY | __GFP_NOWARN); -if (pvec)/* defer to worker if malloc fails */ - pinned =__get_user_pages_fast (obj->userptr.ptr, - num_pages, - !i915_gem_object_is_readonly (obj), - pvec); +/* defer to worker if malloc fails */ +if (pvec) { +if (!i915_gem_object_is_readonly (obj)) + gup_flags |=FOLL_WRITE ; + pinned =pin_user_pages_fast_only (obj->userptr.ptr, + num_pages, gup_flags, + pvec); + } } active = false;
@@ -620,7 +624,7 @@ static int i915_gem_userptr_get_pages(struct drm_i915_gem_object *obj)__i915_gem_userptr_set_active (obj, true);if (IS_ERR (pages)) -release_pages (pvec, pinned); +unpin_user_pages (pvec, pinned);kvfree (pvec);return PTR_ERR_OR_ZERO (pages);
@@ -675,7 +679,7 @@ i915_gem_userptr_put_pages(struct drm_i915_gem_object *obj, }mark_page_accessed (page); -put_page (page); +unpin_user_page (page); } obj->mm.dirty = false;
Signature · 1 line
2.26.2
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()
In reply to John Hubbard== Series Details ==
== Series Details ==
Series: mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()
URL : https://patchwork.freedesktop.org/series/77381/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 5dd288837ad8 mm/gup: move __get_user_pages_fast() down a few lines in gup.c -:111: CHECK:SPACING: No space is necessary after a cast #111: FILE: mm/gup.c:2764: + len = (unsigned long) nr_pages << PAGE_SHIFT;
total: 0 errors, 0 warnings, 1 checks, 124 lines checked 4bab9b886ef9 mm/gup: refactor and de-duplicate gup_fast() code d8a6c141995a mm/gup: introduce pin_user_pages_fast_only() ace503a8f42c drm/i915: convert get_user_pages() --> pin_user_pages()
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()
In reply to John Hubbard== Series Details ==
== Series Details ==
Series: mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()
URL : https://patchwork.freedesktop.org/series/77381/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1019:47: expected unsigned int [addressable] [usertype] ulClockParams +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1019:47: got restricted __le32 [usertype] +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1019:47: warning: incorrect type in assignment (different base types) +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1028:50: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1029:49: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1037:47: warning: too many warnings +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:184:44: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:283:14: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:320:14: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:323:14: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:326:14: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:329:18: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:330:26: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:338:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:340:38: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:342:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:346:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:348:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:353:33: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:367:43: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:369:38: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:374:67: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:375:53: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:378:66: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:389:80: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:395:57: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:402:69: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:403:53: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:406:66: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:414:66: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:423:69: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:424:69: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:473:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:476:45: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:477:45: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:484:54: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:52:28: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:531:35: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:53:29: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:533:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:54:26: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:55:27: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:56:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:57:26: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:577:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:581:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:58:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:583:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:586:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:590:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:59:26: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:598:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:600:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:617:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:621:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:623:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:630:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:632:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:644:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:648:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:650:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:657:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:659:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:662:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:664:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:676:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:688:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:691:47: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:697:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:796:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:797:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:800:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:801:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:804:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:805:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:812:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:813:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:816:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:817:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:820:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:821:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:828:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:829:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:832:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:833:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:836:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:837:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:844:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:845:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:848:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:849:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:852:46: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:853:40: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:916:47: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:918:49: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:920:52: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:934:47: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:936:49: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:938:52: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:956:47: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:958:49: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:960:52: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:296:34: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:330:34: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:360:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:362:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:369:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:383:40: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:406:40: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:44:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:447:53: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:451:33: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:454:61: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:455:64: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:457:54: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:483:17: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:486:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:64:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:80:17: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:80:17: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:80:17: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:85:30: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:86:24: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c:98:39: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:222:29: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:226:37: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:226:37: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:226:37: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:227:37: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:233:43: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:236:44: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:239:51: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:458:41: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:458:41: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:458:41: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:464:39: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:465:30: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:466:39: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:468:24: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:140:26: expected unsigned long long [usertype] *chunk_array_user +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:140:26: got void [noderef] <asn:1> * +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:140:26: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:141:41: expected void const [noderef] <asn:1> *from +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:141:41: got unsigned long long [usertype] *chunk_array_user +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:141:41: warning: incorrect type in argument 2 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:160:27: expected struct drm_amdgpu_cs_chunk [noderef] <asn:1> **chunk_ptr +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:160:27: got void [noderef] <asn:1> * +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:160:27: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1613:21: expected struct drm_amdgpu_fence *fences_user +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1613:21: got void [noderef] <asn:1> * +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1613:21: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1614:36: expected void const [noderef] <asn:1> *from +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1614:36: got struct drm_amdgpu_fence *fences_user +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1614:36: warning: incorrect type in argument 2 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:161:49: expected void const [noderef] <asn:1> *from +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:161:49: got struct drm_amdgpu_cs_chunk [noderef] <asn:1> **chunk_ptr +drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:161:49: warning: incorrect type in argument 2 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1182:25: error: incompatible types in comparison expression (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1183:17: error: incompatible types in comparison expression (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1239:17: error: incompatible types in comparison expression (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:183:29: expected void const volatile [noderef] <asn:1> * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:183:29: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:183:29: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:183:29: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:183:29: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:183:29: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:183:29: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:183:29: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:183:29: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:183:29: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:183:29: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:183:29: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:183:29: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:183:29: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:183:29: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:183:29: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:185:29: expected void const volatile [noderef] <asn:1> * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:185:29: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:185:29: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:185:29: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:185:29: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:185:29: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:185:29: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:185:29: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:185:29: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:185:29: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:185:29: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:272:21: expected void const volatile [noderef] <asn:1> * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:272:21: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:272:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:272:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:272:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:272:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:272:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:272:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:272:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:272:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:272:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:272:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:272:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:272:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:272:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:272:21: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:326:21: expected void const volatile [noderef] <asn:1> * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:326:21: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:326:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:326:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:326:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:326:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:326:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:326:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:326:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:326:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:326:21: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:383:21: expected void const volatile [noderef] <asn:1> * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:383:21: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:383:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:383:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:383:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:383:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:383:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:383:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:383:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:383:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:383:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:383:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:383:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:383:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:383:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:383:21: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:437:21: expected void const volatile [noderef] <asn:1> * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:437:21: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:437:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:437:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:437:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:437:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:437:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:437:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:437:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:437:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:437:21: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:494:21: expected void const volatile [noderef] <asn:1> * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:494:21: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:494:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:494:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:494:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:494:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:494:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:494:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:494:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:494:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:494:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:494:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:494:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:494:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:494:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:494:21: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:548:21: expected void const volatile [noderef] <asn:1> * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:548:21: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:548:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:548:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:548:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:548:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:548:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:548:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:548:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:548:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:548:21: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:645:21: expected void const volatile [noderef] <asn:1> * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:645:21: got unsigned int [usertype] * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:645:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:645:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:645:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:645:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:645:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:645:21: warning: cast removes address space '<asn:1>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:645:21: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:645:21: warning: too many warnings +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1618:65: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1623:55: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1624:50: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1625:50: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1626:56: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1628:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1629:45: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1630:51: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1631:55: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1632:57: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1634:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1635:53: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1637:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1639:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1640:46: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1644:73: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1646:33: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1648:33: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1659:73: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:260:16: error: incompatible types in comparison expression (different type sizes) +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:507:39: warning: cast removes address space '<asn:2>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:527:31: warning: cast removes address space '<asn:2>' of expression +drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:184:13: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:203:18: warning: cast to restricted _
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()
In reply to John Hubbard== Series Details ==
== Series Details ==
Series: mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()
URL : https://patchwork.freedesktop.org/series/77381/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8498 -> Patchwork_17704
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/index.html
Known issues
------------
Here are the changes found in Patchwork_17704 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@execlists:
- fi-cfl-8700k: [PASS][1] -> [INCOMPLETE][2] ([i915#656])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/fi-cfl-8700k/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/fi-cfl-8700k/igt@i915_selftest@[email protected]
* igt@kms_chamelium@dp-crc-fast:
- fi-cml-u2: [PASS][3] -> [FAIL][4] ([i915#262])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/fi-cml-u2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/fi-cml-u2/igt@[email protected]
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656
Participating hosts (52 -> 45)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_8498 -> Patchwork_17704
CI-20190529: 20190529
CI_DRM_8498: 1493c649ae92207a758afa50a639275bd6c80e2e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5659: 66ab5e42811fee3dea8c21ab29e70e323a0650de @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17704: ace503a8f42c4de5395983002282f6d0302543bc @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
ace503a8f42c drm/i915: convert get_user_pages() --> pin_user_pages() d8a6c141995a mm/gup: introduce pin_user_pages_fast_only() 4bab9b886ef9 mm/gup: refactor and de-duplicate gup_fast() code 5dd288837ad8 mm/gup: move __get_user_pages_fast() down a few lines in gup.c
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()
In reply to John Hubbard== Series Details ==
== Series Details ==
Series: mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()
URL : https://patchwork.freedesktop.org/series/77381/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8498_full -> Patchwork_17704_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_17704_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_17704_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_17704_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2] +7 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-tglb7/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-tglb1/igt@[email protected]
- shard-glk: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-glk8/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-glk8/igt@[email protected]
- shard-iclb: [PASS][5] -> [DMESG-WARN][6] +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-iclb6/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-iclb8/igt@[email protected]
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup@gtt:
- shard-iclb: [PASS][7] -> [INCOMPLETE][8] +6 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-iclb4/igt@gem_userptr_blits@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-iclb3/igt@gem_userptr_blits@[email protected]
* igt@gem_userptr_blits@map-fixed-invalidate-gup@gtt:
- shard-kbl: [PASS][9] -> [INCOMPLETE][10] +7 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-kbl1/igt@gem_userptr_blits@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-kbl4/igt@gem_userptr_blits@[email protected]
- shard-apl: [PASS][11] -> [INCOMPLETE][12] +6 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-apl1/igt@gem_userptr_blits@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-apl7/igt@gem_userptr_blits@[email protected]
* igt@gem_userptr_blits@stress-purge:
- shard-skl: [PASS][13] -> [INCOMPLETE][14] +7 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-skl10/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-skl10/igt@[email protected]
* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-kbl: [PASS][15] -> [DMESG-WARN][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-kbl6/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-kbl2/igt@[email protected]
- shard-apl: [PASS][17] -> [DMESG-WARN][18] +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-apl4/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-apl2/igt@[email protected]
* igt@gem_userptr_blits@unsync-unmap-after-close:
- shard-tglb: [PASS][19] -> [DMESG-WARN][20] +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-tglb6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-tglb1/igt@[email protected]
* igt@gem_userptr_blits@userfault:
- shard-snb: [PASS][21] -> [DMESG-WARN][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-snb4/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-snb1/igt@[email protected]
- shard-skl: [PASS][23] -> [DMESG-WARN][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-skl2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-skl6/igt@[email protected]
* igt@runner@aborted:
- shard-kbl: NOTRUN -> ([FAIL][25], [FAIL][26], [FAIL][27], [FAIL][28], [FAIL][29], [FAIL][30], [FAIL][31], [FAIL][32], [FAIL][33], [FAIL][34], [FAIL][35], [FAIL][36], [FAIL][37]) ([i915#1611] / [i915#836])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-kbl1/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-kbl2/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-kbl2/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-kbl3/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-kbl1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-kbl2/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-kbl1/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-kbl6/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-kbl1/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-kbl4/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-kbl3/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-kbl7/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-kbl4/igt@[email protected]
- shard-iclb: NOTRUN -> ([FAIL][38], [FAIL][39], [FAIL][40], [FAIL][41], [FAIL][42], [FAIL][43], [FAIL][44], [FAIL][45], [FAIL][46], [FAIL][47], [FAIL][48], [FAIL][49])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-iclb8/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-iclb7/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-iclb6/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-iclb2/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-iclb4/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-iclb1/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-iclb8/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-iclb5/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-iclb3/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-iclb8/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-iclb7/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-iclb6/igt@[email protected]
- shard-tglb: NOTRUN -> ([FAIL][50], [FAIL][51], [FAIL][52], [FAIL][53], [FAIL][54], [FAIL][55], [FAIL][56], [FAIL][57], [FAIL][58], [FAIL][59], [FAIL][60], [FAIL][61], [FAIL][62])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-tglb1/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-tglb2/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-tglb6/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-tglb7/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-tglb7/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-tglb1/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-tglb6/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-tglb5/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-tglb7/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-tglb3/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-tglb1/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-tglb2/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-tglb6/igt@[email protected]
- shard-snb: NOTRUN -> ([FAIL][63], [FAIL][64], [FAIL][65], [FAIL][66], [FAIL][67], [FAIL][68], [FAIL][69], [FAIL][70], [FAIL][71], [FAIL][72], [FAIL][73], [FAIL][74], [FAIL][75])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-snb2/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-snb1/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-snb2/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-snb6/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-snb4/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-snb6/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-snb5/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-snb5/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-snb6/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-snb5/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-snb1/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-snb1/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-snb4/igt@[email protected]
#### Warnings ####
* igt@runner@aborted:
- shard-apl: [FAIL][76] ([fdo#109271] / [i915#716]) -> ([FAIL][77], [FAIL][78], [FAIL][79], [FAIL][80], [FAIL][81], [FAIL][82], [FAIL][83], [FAIL][84], [FAIL][85], [FAIL][86], [FAIL][87], [FAIL][88]) ([i915#1611] / [i915#836])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-apl1/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-apl7/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-apl7/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-apl3/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-apl2/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-apl8/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-apl7/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-apl7/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-apl2/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-apl8/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-apl6/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-apl4/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-apl6/igt@[email protected]
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* {igt@gem_exec_schedule@pi-distinct-iova@rcs0}:
- shard-iclb: [PASS][89] -> [INCOMPLETE][90] +3 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-iclb5/igt@gem_exec_schedule@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-iclb6/igt@gem_exec_schedule@[email protected]
* {igt@gem_exec_schedule@pi-userfault@bcs0}:
- shard-tglb: [PASS][91] -> [INCOMPLETE][92] +3 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-tglb8/igt@gem_exec_schedule@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-tglb8/igt@gem_exec_schedule@[email protected]
* {igt@gem_exec_schedule@pi-userfault@rcs0}:
- shard-skl: [PASS][93] -> [INCOMPLETE][94] +3 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-skl4/igt@gem_exec_schedule@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-skl5/igt@gem_exec_schedule@[email protected]
- shard-glk: [PASS][95] -> [DMESG-WARN][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-glk8/igt@gem_exec_schedule@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-glk1/igt@gem_exec_schedule@[email protected]
* {igt@gem_userptr_blits@invalid-mmap-offset-unsync@gtt}:
- shard-tglb: [PASS][97] -> [DMESG-WARN][98] +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-tglb3/igt@gem_userptr_blits@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-tglb1/igt@gem_userptr_blits@[email protected]
* {igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy@gtt}:
- shard-kbl: [PASS][99] -> [INCOMPLETE][100] +2 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-kbl1/igt@gem_userptr_blits@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-kbl3/igt@gem_userptr_blits@[email protected]
- shard-apl: [PASS][101] -> [INCOMPLETE][102] +3 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-apl1/igt@gem_userptr_blits@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-apl7/igt@gem_userptr_blits@[email protected]
Known issues
------------
Here are the changes found in Patchwork_17704_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-apl: [PASS][103] -> [INCOMPLETE][104] ([i915#95])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-apl8/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-apl6/igt@[email protected]
- shard-kbl: [PASS][105] -> [DMESG-WARN][106] ([i915#93] / [i915#95])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-kbl4/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-kbl2/igt@[email protected]
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup@gtt:
- shard-glk: [PASS][107] -> [INCOMPLETE][108] ([i915#58] / [k.org#198133]) +8 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-glk7/igt@gem_userptr_blits@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-glk6/igt@gem_userptr_blits@[email protected]
* igt@gem_userptr_blits@stress-purge:
- shard-snb: [PASS][109] -> [INCOMPLETE][110] ([i915#82]) +9 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-snb6/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-snb5/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-64x64-random:
- shard-skl: [PASS][111] -> [FAIL][112] ([i915#54])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-skl6/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-skl3/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-skl: [PASS][113] -> [INCOMPLETE][114] ([i915#300])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-skl5/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-skl9/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: [PASS][115] -> [DMESG-WARN][116] ([i915#180]) +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-apl1/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-apl1/igt@[email protected]
* igt@kms_cursor_legacy@all-pipes-torture-bo:
- shard-iclb: [PASS][117] -> [DMESG-WARN][118] ([i915#128])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-iclb2/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-iclb6/igt@[email protected]
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][119] -> [FAIL][120] ([i915#1188])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-skl5/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-skl9/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][121] -> [FAIL][122] ([fdo#108145] / [i915#265]) +1 similar issue
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-skl3/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-skl1/igt@[email protected]
* igt@kms_psr@psr2_primary_blt:
- shard-iclb: [PASS][123] -> [SKIP][124] ([fdo#109441])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-iclb2/igt@kms_psr@psr2_primary_blt.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-iclb6/igt@kms_psr@psr2_primary_blt.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-skl: [PASS][125] -> [INCOMPLETE][126] ([i915#69])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-skl1/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-skl9/igt@[email protected]
#### Possible fixes ####
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][127] ([i915#180]) -> [PASS][128] +3 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-kbl2/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-kbl3/igt@[email protected]
* {igt@kms_flip@flip-vs-suspend@c-dp1}:
- shard-apl: [DMESG-WARN][129] ([i915#180]) -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-apl4/igt@kms_flip@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-apl4/igt@kms_flip@[email protected]
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][131] ([i915#173]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-iclb1/igt@kms_psr@no_drrs.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-iclb2/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][133] ([fdo#109441]) -> [PASS][134]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-iclb1/igt@kms_psr@psr2_cursor_render.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
#### Warnings ####
* igt@kms_content_protection@atomic:
- shard-apl: [DMESG-FAIL][135] ([fdo#110321]) -> [TIMEOUT][136] ([i915#1319])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-apl7/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-apl7/igt@[email protected]
* igt@kms_content_protection@lic:
- shard-kbl: [FAIL][137] ([fdo#110321]) -> [TIMEOUT][138] ([i915#1319])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8498/shard-kbl3/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/shard-kbl2/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#128]: https://gitlab.freedesktop.org/drm/intel/issues/128
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1611]: https://gitlab.freedesktop.org/drm/intel/issues/1611
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#836]: https://gitlab.freedesktop.org/drm/intel/issues/836
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8498 -> Patchwork_17704
CI-20190529: 20190529
CI_DRM_8498: 1493c649ae92207a758afa50a639275bd6c80e2e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5659: 66ab5e42811fee3dea8c21ab29e70e323a0650de @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17704: ace503a8f42c4de5395983002282f6d0302543bc @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17704/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting John Hubbard (2020-05-19 01:21:20)
Quoted 4 lines
This needs to go through Andrew's -mm tree, due to adding a new
gup.croutine. However, I would really love to have some testing from the drm/i915 folks, because I haven't been able to run-time test that part of it.
CI hit
<4> [185.667750] WARNING: CPU: 0 PID: 1387 at mm/gup.c:2699 internal_get_user_pages_fast+0x63a/0xac0
<4> [185.667752] Modules linked in: vgem snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic i915 mei_hdcp x86_pkg_temp_thermal coretemp snd_hda_intel snd_intel_dspcfg crct10dif_pclmul snd_hda_codec crc32_pclmul snd_hwdep snd_hda_core ghash_clmulni_intel cdc_ether usbnet mii snd_pcm e1000e mei_me ptp pps_core mei intel_lpss_pci prime_numbers
<4> [185.667774] CPU: 0 PID: 1387 Comm: gem_userptr_bli Tainted: G U 5.7.0-rc5-CI-Patchwork_17704+ #1
<4> [185.667777] Hardware name: Intel Corporation Ice Lake Client Platform/IceLake U DDR4 SODIMM PD RVP, BIOS ICLSFWR1.R00.3234.A01.1906141750 06/14/2019
<4> [185.667782] RIP: 0010:internal_get_user_pages_fast+0x63a/0xac0
<4> [185.667785] Code: 24 40 08 48 39 5c 24 38 49 89 df 0f 85 74 fc ff ff 48 83 44 24 50 08 48 39 5c 24 58 49 89 dc 0f 85 e0 fb ff ff e9 14 fe ff ff <0f> 0b b8 ea ff ff ff e9 36 fb ff ff 4c 89 e8 48 21 e8 48 39 e8 0f
<4> [185.667789] RSP: 0018:ffffc90001133c38 EFLAGS: 00010206
<4> [185.667792] RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffff8884999ee800
<4> [185.667795] RDX: 00000000000c0001 RSI: 0000000000000100 RDI: 00007f419e774000
<4> [185.667798] RBP: ffff888453dbf040 R08: 0000000000000000 R09: 0000000000000001
<4> [185.667800] R10: 0000000000000000 R11: 0000000000000000 R12: ffff888453dbf380
<4> [185.667803] R13: ffff8884999ee800 R14: ffff888453dbf3e8 R15: 0000000000000040
<4> [185.667806] FS: 00007f419e875e40(0000) GS:ffff88849fe00000(0000) knlGS:0000000000000000
<4> [185.667808] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
<4> [185.667811] CR2: 00007f419e873000 CR3: 0000000458bd2004 CR4: 0000000000760ef0
<4> [185.667814] PKRU: 55555554
<4> [185.667816] Call Trace:
<4> [185.667912] ? i915_gem_userptr_get_pages+0x1c6/0x290 [i915] <4> [185.667918] ? mark_held_locks+0x49/0x70 <4> [185.667998] ? i915_gem_userptr_get_pages+0x1c6/0x290 [i915] <4> [185.668073] ? i915_gem_userptr_get_pages+0x1c6/0x290 [i915]
and then panicked, across a range of systems.
-Chris
John Hubbard
reviewerQuoted 25 lines · Chris Wilson
Quoting John Hubbard (2020-05-19 01:21:20)
Quoted 4 lines
This needs to go through Andrew's -mm tree, due to adding a new
gup.croutine. However, I would really love to have some testing from the drm/i915 folks, because I haven't been able to run-time test that part of it.CI hit
<4> [185.667750] WARNING: CPU: 0 PID: 1387 at
mm/gup.c:2699internal_get_user_pages_fast+0x63a/0xac0
<4> [185.667752] Modules linked in: vgemsnd_hda_codec_hdmisnd_hda_codec_realteksnd_hda_codec_generici915mei_hdcpx86_pkg_temp_thermalcoretempsnd_hda_intelsnd_intel_dspcfgcrct10dif_pclmulsnd_hda_codeccrc32_pclmulsnd_hwdepsnd_hda_coreghash_clmulni_intelcdc_etherusbnet miisnd_pcme1000emei_meptppps_coremeiintel_lpss_pciprime_numbers
<4> [185.667774] CPU: 0 PID: 1387 Comm:gem_userptr_bliTainted: G U 5.7.0-rc5-CI-Patchwork_17704+ #1
<4> [185.667777] Hardware name: Intel Corporation Ice Lake Client Platform/IceLake U DDR4 SODIMM PD RVP, BIOS ICLSFWR1.R00.3234.A01.1906141750 06/14/2019
<4> [185.667782] RIP: 0010:internal_get_user_pages_fast+0x63a/0xac0
<4> [185.667785] Code: 24 40 08 48 39 5c 24 38 49 89 df 0f 85 74 fc ff ff 48 83 44 24 50 08 48 39 5c 24 58 49 89 dc 0f 85 e0 fb ff ff e9 14 fe ff ff <0f> 0b b8 ea ff ff ff e9 36 fb ff ff 4c 89 e8 48 21 e8 48 39 e8 0f
<4> [185.667789] RSP: 0018:ffffc90001133c38 EFLAGS: 00010206
<4> [185.667792] RAX: 0000000000000000 RBX: 0000000000000000 RCX:ffff8884999ee800
<4> [185.667795] RDX:00000000000c0001RSI: 0000000000000100 RDI:00007f419e774000
<4> [185.667798] RBP:ffff888453dbf040R08: 0000000000000000 R09: 0000000000000001
<4> [185.667800] R10: 0000000000000000 R11: 0000000000000000 R12:ffff888453dbf380
<4> [185.667803] R13:ffff8884999ee800R14:ffff888453dbf3e8R15: 0000000000000040
<4> [185.667806] FS: 00007f419e875e40(0000) GS:ffff88849fe00000(0000) knlGS:0000000000000000
<4> [185.667808] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
<4> [185.667811] CR2:00007f419e873000CR3:0000000458bd2004CR4:0000000000760ef0
<4> [185.667814] PKRU: 55555554
<4> [185.667816] Call Trace:
Quoted 8 lines
<4> [185.667912] ? i915_gem_userptr_get_pages+0x1c6/0x290 [i915] <4> [185.667918] ? mark_held_locks+0x49/0x70 <4> [185.667998] ? i915_gem_userptr_get_pages+0x1c6/0x290 [i915] <4> [185.668073] ? i915_gem_userptr_get_pages+0x1c6/0x290 [i915]and then panicked, across a range of systems.
-Chris
Thanks for this report! I'm looking into it now.
thanks,
Signature · 2 lines
John Hubbard NVIDIA
John Hubbard
reviewerSolved: [PATCH 0/4] mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()
Quoted 10 lines · John Hubbard
Quoted 9 lines · Chris Wilson
Quoting John Hubbard (2020-05-19 01:21:20)
Quoted 4 lines
This needs to go through Andrew's -mm tree, due to adding a new
gup.croutine. However, I would really love to have some testing from the drm/i915 folks, because I haven't been able to run-time test that part of it.CI hit
<4> [185.667750] WARNING: CPU: 0 PID: 1387 at
mm/gup.c:2699internal_get_user_pages_fast+0x63a/0xac0
OK, what happened here is that it's WARN()'ing due to passing in the new FOLL_FAST_ONLY flag, which was not added to the whitelist.
So the fix is easy, and should be applied to the refactoring patch. I'll send out a v2 of the series, which will effectively have this applied:
mm/gup.c +2 -1
@@ -2696,7 +2696,8 @@ static int internal_get_user_pages_fast(unsigned long start, int nr_pages,int nr_pinned =0 , ret =0 ;if (WARN_ON_ONCE (gup_flags & ~(FOLL_WRITE |FOLL_LONGTERM | -FOLL_FORCE |FOLL_PIN |FOLL_GET ))) +FOLL_FORCE |FOLL_PIN |FOLL_GET | +FOLL_FAST_ONLY )))return -EINVAL ; start =untagged_addr (start) &PAGE_MASK ;
Quoted 21 lines
Quoted 21 lines
<4> [185.667752] Modules linked in: vgem
snd_hda_codec_hdmisnd_hda_codec_realteksnd_hda_codec_generici915mei_hdcpx86_pkg_temp_thermalcoretempsnd_hda_intelsnd_intel_dspcfgcrct10dif_pclmulsnd_hda_codeccrc32_pclmulsnd_hwdepsnd_hda_coreghash_clmulni_intelcdc_etherusbnet miisnd_pcme1000emei_meptppps_coremeiintel_lpss_pciprime_numbers
<4> [185.667774] CPU: 0 PID: 1387 Comm:gem_userptr_bliTainted: G U 5.7.0-rc5-CI-Patchwork_17704+ #1
<4> [185.667777] Hardware name: Intel Corporation Ice Lake Client Platform/IceLake U DDR4 SODIMM PD RVP, BIOS ICLSFWR1.R00.3234.A01.1906141750 06/14/2019
<4> [185.667782] RIP: 0010:internal_get_user_pages_fast+0x63a/0xac0
<4> [185.667785] Code: 24 40 08 48 39 5c 24 38 49 89 df 0f 85 74 fc ff ff 48 83 44 24 50 08 48 39 5c 24 58 49 89 dc 0f 85 e0 fb ff ff e9 14 fe ff ff <0f> 0b b8 ea ff ff ff e9 36 fb ff ff 4c 89 e8 48 21 e8 48 39 e8 0f
<4> [185.667789] RSP: 0018:ffffc90001133c38 EFLAGS: 00010206
<4> [185.667792] RAX: 0000000000000000 RBX: 0000000000000000 RCX:ffff8884999ee800
<4> [185.667795] RDX:00000000000c0001RSI: 0000000000000100 RDI:00007f419e774000
<4> [185.667798] RBP:ffff888453dbf040R08: 0000000000000000 R09: 0000000000000001
<4> [185.667800] R10: 0000000000000000 R11: 0000000000000000 R12:ffff888453dbf380
<4> [185.667803] R13:ffff8884999ee800R14:ffff888453dbf3e8R15: 0000000000000040
<4> [185.667806] FS: 00007f419e875e40(0000) GS:ffff88849fe00000(0000) knlGS:0000000000000000
<4> [185.667808] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
<4> [185.667811] CR2:00007f419e873000CR3:0000000458bd2004CR4:0000000000760ef0
<4> [185.667814] PKRU: 55555554
<4> [185.667816] Call Trace:
<4> [185.667912] ?i915_gem_userptr_get_pages+0x1c6/0x290[i915]
<4> [185.667918] ?mark_held_locks+0x49/0x70
<4> [185.667998] ?i915_gem_userptr_get_pages+0x1c6/0x290[i915]
<4> [185.668073] ?i915_gem_userptr_get_pages+0x1c6/0x290[i915]
Quoted 3 lines
Quoted 3 lines
and then panicked, across a range of systems.
-Chris
btw, the panic seems to indicate an additional, pre-existing problem:i915_gem_userptr_get_pages(), in this case at least, is not able to recover from a get_user_pages/pin_user_pages failure.
thanks,
Signature · 2 lines
John Hubbard NVIDIA
Hi John,
Quoted 26 lines · John Hubbard
This needs to go through Andrew's -mm tree, due to adding a new
gup.croutine. However, I would really love to have some testing from the drm/i915 folks, because I haven't been able to run-time test that part of it.Otherwise, though, the series has passed my basic run time testing:
some LTP tests, some xfs and etx4 non-destructive xfstests, and an assortment of other smaller ones: vm selftests,io_uring_register, a few more. But that's only on one particular machine. Also, cross-compile tests for half a dozen arches all pass.Details:
In order to convert the drm/i915 driver from
get_user_pages()topin_user_pages(), aFOLL_PINequivalent of__get_user_pages_fast()was required. That led to refactoring__get_user_pages_fast(), with the following goals:1) As above: provide a pin_user_pages*() routine for drm/i915 to call, in place of
__get_user_pages_fast(),2) Get rid of the
gup.cduplicate code for walking page tables with interrupts disabled. This duplicate code is a minor maintenance problem anyway.
Quoted 6 lines
3) Make it easy for an upcoming patch from Souptick, which aims to convert
__get_user_pages_fast()to use agup_flagsargument, instead of a bool writeable arg. Also, if this series looks good, we can ask Souptick to change the name as well, to whatever the consensus is. My initial recommendation is:get_user_pages_fast_only(), to match the newpin_user_pages_only().
Shall I hold my changes till 5.8-rc1 , when this series will appear upstream ?
Quoted 13 lines
John Hubbard (4):
mm/gup: move__get_user_pages_fast()down a few lines ingup.cmm/gup: refactor and de-duplicategup_fast()code mm/gup: introducepin_user_pages_fast_only()drm/i915: convertget_user_pages()-->pin_user_pages()drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 22 +-- include/linux/mm.h | 3 + mm/gup.c | 150 ++++++++++++-------- 3 files changed, 107 insertions(+), 68 deletions(-)
Quoted 4 lines
base-commit:
642b151f45dd54809ea00ecd3976a56c1ec9b53d--
2.26.2
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
John Hubbard
reviewerOn 2020-05-22 04:40, Souptick Joarder wrote:
...
Quoted 8 lines
Quoted 6 lines
3) Make it easy for an upcoming patch from Souptick, which aims to convert
__get_user_pages_fast()to use agup_flagsargument, instead of a bool writeable arg. Also, if this series looks good, we can ask Souptick to change the name as well, to whatever the consensus is. My initial recommendation is:get_user_pages_fast_only(), to match the newpin_user_pages_only().Shall I hold my changes till 5.8-rc1 , when this series will appear upstream ?
I don't really see any problem with your posting something that is based on the latest linux-next (which has my changes now). Should be fine. And in fact it would be nice to get that done in this round, so that the pin* and get* APIs look the same.
thanks,
Signature · 6 lines
John Hubbard NVIDIA _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel