btrfs: Add a test for leaking root crash at unmount time
PATCH 1/1 btrfs: Add a test for leaking root crash at unmount time
Test if canceled balance could lead to root leakage.
If the kernel has CONFIG_BTRFS_DEBUG compiled, unmount time root leakge check would detect it, and cause NULL pointer dereference as the pages of the leaked root is already freed.
The fix is titled "btrfs: relocation: Fix reloc root leakage and the NULL
pointer reference caused by the leakage".
--- tests/btrfs/212 | 85 +++++++++++++++++++++++++++++++++++++++++++++ tests/btrfs/212.out | 2 ++ tests/btrfs/group | 1 + 3 files changed, 88 insertions(+) create mode 100755 tests/btrfs/212 create mode 100644 tests/btrfs/212.out
tests/btrfs/212 new file +85 -0
@@ -0,0 +1,85 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2020 SUSE Linux Products GmbH. All Rights Reserved. +# +# FS QA Test 212 +# +# Test if unmounting a fs with balance canceled can lead to crash. +# This needs CONFIG_BTRFS_DEBUG compiled, which includes extra unmount time self-test +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* + kill $balance_pid &> /dev/null + kill $cancel_pid &> /dev/null + "$KILLALL_PROG" -q $FSSTRESS_PROG &> /dev/null + $BTRFS_UTIL_PROG balance cancel $SCRATCH_MNT &> /dev/null + wait +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +# Modify as appropriate. +_supported_fs btrfs +_supported_os Linux +_require_scratch +_require_command "$KILLALL_PROG" killall + +_scratch_mkfs >> $seqres.full +_scratch_mount + +runtime=15 + +balance_workload() +{ + trap "wait; exit" SIGTERM + while true; do + $BTRFS_UTIL_PROG balance start -f --full $SCRATCH_MNT &> /dev/null + done +} + +cancel_workload() +{ + trap "wait; exit" SIGTERM + while true; do + $BTRFS_UTIL_PROG balance cancel $SCRATCH_MNT &> /dev/null + sleep 2 + done +} + +$FSSTRESS_PROG -d $SCRATCH_MNT -w -n 100000 >> $seqres.full 2>/dev/null & +balance_workload & +balance_pid=$! + +cancel_workload & +cancel_pid=$! + +sleep $runtime + +kill $balance_pid +kill $cancel_pid +"$KILLALL_PROG" -q $FSSTRESS_PROG &> /dev/null +$BTRFS_UTIL_PROG balance cancel $SCRATCH_MNT &> /dev/null +wait + +echo "Silence is golden" +# success, all done +status=0 +exit
tests/btrfs/212.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 212 +Silence is golden
tests/btrfs/group +1 -0
@@ -214,3 +214,4 @@ 209 auto quick log 210 auto quick qgroup snapshot 211 auto quick log prealloc +212 auto balance dangerous
Signature · 1 line
2.26.2
Quoted 5 lines · Qu Wenruo
Test if canceled balance could lead to root leakage.
If the kernel hasCONFIG_BTRFS_DEBUGcompiled, unmount time root leakge check would detect it, and cause NULL pointer dereference as the pages of the leaked root is already freed.
is -> are
Quoted 19 lines
The fix is titled "btrfs: relocation: Fix reloc root leakage and the NULL
pointer reference caused by the leakage".Signed-off-by Qu Wenruo <[email protected]>--- tests/btrfs/212 | 85 +++++++++++++++++++++++++++++++++++++++++++++ tests/btrfs/212.out | 2 ++ tests/btrfs/group | 1 + 3 files changed, 88 insertions(+) create mode 100755 tests/btrfs/212 create mode 100644 tests/btrfs/212.outtests/btrfs/212 new file +0
-0
tests/btrfs/212 line 8
Quoted 8 lines
tests/btrfs/212 new file +8
-0@@ -0,0 +1,85 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2020 SUSE Linux Products GmbH. All Rights Reserved. +# +# FS QA Test 212 +# +# Test if unmounting a fs with balance canceled can lead to crash. +# This needs CONFIG_BTRFS_DEBUG compiled, which includes extra unmount time self-test
includes -> adds
Quoted 36 lines
tests/btrfs/212 new file +36
-0+# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* + kill $balance_pid &> /dev/null + kill $cancel_pid &> /dev/null + "$KILLALL_PROG" -q $FSSTRESS_PROG &> /dev/null + $BTRFS_UTIL_PROG balance cancel $SCRATCH_MNT &> /dev/null + wait +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +# Modify as appropriate. +_supported_fs btrfs +_supported_os Linux +_require_scratch +_require_command "$KILLALL_PROG" killall +
tests/btrfs/212 line 54
Quoted 10 lines
tests/btrfs/212 new file +10
-0+_scratch_mkfs >> $seqres.full +_scratch_mount + +runtime=15 + +balance_workload() +{ + trap "wait; exit" SIGTERM + while true; do + $BTRFS_UTIL_PROG balance start -f --full $SCRATCH_MNT &> /dev/null
Please use the helper _run_btrfs_balance_start(), it will automatically add --full-balance if the installed btrfs-progs version requires it.
After that you can add:
Quoted 51 lines
tests/btrfs/212 new file +31
-0+ done +} + +cancel_workload() +{ + trap "wait; exit" SIGTERM + while true; do + $BTRFS_UTIL_PROG balance cancel $SCRATCH_MNT &> /dev/null + sleep 2 + done +} + +$FSSTRESS_PROG -d $SCRATCH_MNT -w -n 100000 >> $seqres.full 2>/dev/null & +balance_workload & +balance_pid=$! + +cancel_workload & +cancel_pid=$! + +sleep $runtime + +kill $balance_pid +kill $cancel_pid +"$KILLALL_PROG" -q $FSSTRESS_PROG &> /dev/null +$BTRFS_UTIL_PROG balance cancel $SCRATCH_MNT &> /dev/null +wait + +echo "Silence is golden" +# success, all done +status=0 +exittests/btrfs/212.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 212 +Silence is goldentests/btrfs/group +1
-1@@ -214,3 +214,4 @@ 209 auto quick log 210 auto quick qgroup snapshot 211 auto quick log prealloc +212 auto balance dangerous --2.26.2
Signature · 3 lines
Filipe David Manana, “Whether you think you can, or you think you can't — you're right.”