generic/597: test data integrity for rdonly remount
PATCH v2 1/1 generic/597: test data integrity for rdonly remount
This test checks data integrity when remounting from rw to ro mode.
---v1->v2:
- Add to shutdown greoup.
- Change case number to 597
tests/generic/597 | 54 +++++++++++++++++++++++++++++++++++++++++++ tests/generic/597.out | 2 ++ tests/generic/group | 1 + 3 files changed, 57 insertions(+) create mode 100755 tests/generic/597 create mode 100644 tests/generic/597.out
tests/generic/597 new file +54 -0
@@ -0,0 +1,54 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2020 Chengguang Xu <[email protected]>. +# All Rights Reserved. +# +# FS QA Test 597 +# +# Test data integrity for ro remount. +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=0 +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here +_supported_fs generic +_supported_os Linux +_require_fssum +_require_scratch +_require_scratch_shutdown + +_scratch_mkfs &>/dev/null +_scratch_mount + +localdir=$SCRATCH_MNT/dir +mkdir $localdir +sync + +# fssum used for comparing checksum of test file(data & metedata), +# exclude checking about atime, block structure, open error. +$FSSUM_PROG -ugomAcdES -f -w $tmp.fssum $localdir +_scratch_remount ro +_scratch_shutdown +_scratch_cycle_mount +$FSSUM_PROG -r $tmp.fssum $localdir + +exit
tests/generic/597.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 597 +OK
tests/generic/group +1 -0
@@ -599,3 +599,4 @@ 594 auto quick quota 595 auto quick encrypt 596 auto quick +597 auto quick remount shutdown
Signature · 1 line
2.20.1
Quoted 50 lines · Chengguang Xu
This test checks data integrity when remounting from rw to ro mode.
Signed-off-by Chengguang Xu <[email protected]>---
v1->v2:
- Add to shutdown greoup.
- Change case number to 597tests/generic/597 | 54 +++++++++++++++++++++++++++++++++++++++++++ tests/generic/597.out | 2 ++ tests/generic/group | 1 + 3 files changed, 57 insertions(+) create mode 100755 tests/generic/597 create mode 100644 tests/generic/597.outtests/generic/597 new file +27
-0@@ -0,0 +1,54 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2020 Chengguang Xu <[email protected]>. +# All Rights Reserved. +# +# FS QA Test 597 +# +# Test data integrity for ro remount. +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=0 +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter
tests/generic/597 line 37
Quoted 10 lines
tests/generic/597 new file +10
-0+ +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here +_supported_fs generic +_supported_os Linux +_require_fssum +_require_scratch +_require_scratch_shutdown
Couldn't the test be using dm's flakey instead of shutdown? As shutdown is not implemented by all filesystems (btrfs for example), it would allow more coverage.
Thanks.
Quoted 38 lines
tests/generic/597 new file +17
-0+ +_scratch_mkfs &>/dev/null +_scratch_mount + +localdir=$SCRATCH_MNT/dir +mkdir $localdir +sync + +# fssum used for comparing checksum of test file(data & metedata), +# exclude checking about atime, block structure, open error. +$FSSUM_PROG -ugomAcdES -f -w $tmp.fssum $localdir +_scratch_remount ro +_scratch_shutdown +_scratch_cycle_mount +$FSSUM_PROG -r $tmp.fssum $localdir + +exittests/generic/597.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 597 +OKtests/generic/group +1
-1@@ -599,3 +599,4 @@ 594 auto quick quota 595 auto quick encrypt 596 auto quick +597 auto quick remount shutdown --2.20.1
Signature · 3 lines
Filipe David Manana, “Whether you think you can, or you think you can't — you're right.”
Quoted 57 lines · Filipe Manana
Quoted 56 lines · Chengguang Xu
This test checks data integrity when remounting from rw to ro mode.
Signed-off-by Chengguang Xu <[email protected]>---
v1->v2:
- Add to shutdown greoup.
- Change case number to 597tests/generic/597 | 54 +++++++++++++++++++++++++++++++++++++++++++ tests/generic/597.out | 2 ++ tests/generic/group | 1 + 3 files changed, 57 insertions(+)create mode 100755 tests/generic/597
create mode 100644 tests/generic/597.outtests/generic/597 new file +33
-0@@ -0,0 +1,54 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2020 Chengguang Xu <[email protected]>. +# All Rights Reserved. +# +# FS QA Test 597 +# +# Test data integrity for ro remount. +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=0 +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here +_supported_fs generic
Quoted 9 lines
tests/generic/597 line 37
Quoted 4 lines
tests/generic/597 new file +4
-0+_supported_os Linux +_require_fssum +_require_scratch +_require_scratch_shutdownCouldn't the test be using dm's flakey instead of shutdown? As shutdown is not implemented by all filesystems (btrfs for example), it would allow more coverage.
Thanks for the suggestion, I tried with dmflakey but unfortunately it could not work on overlayfs, a possible solution is that move current test case to overlay specific directory and create new test case with dmflakey for generic purpose.
Test results with dmflakey on xfs, btrfs and overlayfs.
[root@hades xfstests-dev]# ./check generic/597
FSTYP -- xfs (non-debug) PLATFORM -- Linux/x86_64 hades 5.6.0-rc3+ #31 SMP Fri May 22 11:27:07 CST 2020 MKFS_OPTIONS -- -f -bsize=4096 /dev/nvme0n1p8
MOUNT_OPTIONS -- /dev/nvme0n1p8 /mnt/scratch
generic/597 1s ... 0s
Ran: generic/597
Passed all 1 tests
[root@hades xfstests-dev]# ./check generic/597
FSTYP -- btrfs PLATFORM -- Linux/x86_64 hades 5.6.0-rc3+ #31 SMP Fri May 22 11:27:07 CST 2020 MKFS_OPTIONS -- /dev/nvme0n1p8
MOUNT_OPTIONS -- /dev/nvme0n1p8 /mnt/scratch
generic/597 0s ... 0s
Ran: generic/597
Passed all 1 tests
[root@hades xfstests-dev]# ./check -overlay generic/597
FSTYP -- overlay PLATFORM -- Linux/x86_64 hades 5.6.0-rc3+ #31 SMP Fri May 22 11:27:07 CST 2020 MKFS_OPTIONS -- /mnt/scratch
MOUNT_OPTIONS -- /mnt/scratch /mnt/scratch/ovl-mnt
generic/597 0s ... [not run] require /mnt/scratch to be valid block disk
Ran: generic/597
Not run: generic/597
Passed all 1 tests
Thanks,
cgxu
Quoted 69 lines · cgxu
Quoted 57 lines · Filipe Manana
Quoted 56 lines · Chengguang Xu
This test checks data integrity when remounting from rw to ro mode.
Signed-off-by Chengguang Xu <[email protected]>---
v1->v2:
- Add to shutdown greoup.
- Change case number to 597tests/generic/597 | 54 +++++++++++++++++++++++++++++++++++++++++++ tests/generic/597.out | 2 ++ tests/generic/group | 1 + 3 files changed, 57 insertions(+)create mode 100755 tests/generic/597
create mode 100644 tests/generic/597.outtests/generic/597 new file +33
-0@@ -0,0 +1,54 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2020 Chengguang Xu <[email protected]>. +# All Rights Reserved. +# +# FS QA Test 597 +# +# Test data integrity for ro remount. +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=0 +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here +_supported_fs genericQuoted 9 lines
tests/generic/597 line 37
Quoted 4 lines
tests/generic/597 new file +4
-0+_supported_os Linux +_require_fssum +_require_scratch +_require_scratch_shutdownCouldn't the test be using dm's flakey instead of shutdown? As shutdown is not implemented by all filesystems (btrfs for example), it would allow more coverage.
Quoted 5 lines
Thanks for the suggestion, I tried with dmflakey but unfortunately it could not work on overlayfs, a possible solution is that move current test case to overlay specific directory and create new test case with dmflakey for generic purpose.
Or you can create an abstraction for shutdown/dmflakey, because this test doesn't care which one you use:
_require_scratch_drop_init_scratch_drop_mount_scratch_drop_scratch_drop_and_remount_cleanup_scratch_drop
But IMO, this could also be done after merging test to increase test coverage.
Thanks,
Amir.