tests/kms_flip: Don't use igt_fixture in an exit handler
PATCH 1/1 tests/kms_flip: Don't use igt_fixture in an exit handler
kms_flip's exit handler was wrapped in an igt_fixture some 7 years ago because "it can fail". That's not a problem anymore, as igt_fail() will explicitly handle failing in an exit handler.
Rather, using igt_fixture in an exit handler is harmful because on a subtest failure, we don't always keep track of the currently running context (whether we're inside a subtest anymore) and we forcefully assert correct nesting of IGT magic control blocks now.
We already know the state is cleanable because we only install the handler on a successful init. Unconditional cleanup in an exit handler is the correct thing to do in general.
--- tests/kms_flip.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
tests/kms_flip.c +2 -4
@@ -1536,10 +1536,8 @@ static void get_timestamp_format(void)static void kms_flip_exit_handler (int sig) { - igt_fixture { -if (last_connector) -kmstest_set_connector_dpms (drm_fd, last_connector,DRM_MODE_DPMS_ON ); - } +if (last_connector) +kmstest_set_connector_dpms (drm_fd, last_connector,DRM_MODE_DPMS_ON ); }static void test_nonblocking_read (int in)
Signature · 6 lines
2.20.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip: Don't use igt_fixture in an exit handler
== Series Details ==
== Series Details ==
Series: tests/kms_flip: Don't use igt_fixture in an exit handler
URL : https://patchwork.freedesktop.org/series/77405/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8501 -> IGTPW_4584
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/index.html
Known issues
------------
Here are the changes found in IGTPW_4584 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@read_all_entries:
- fi-bsw-nick: [PASS][1] -> [INCOMPLETE][2] ([i915#1250] / [i915#1436])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/fi-bsw-nick/igt@debugfs_test@read_all_entries.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/fi-bsw-nick/igt@debugfs_test@read_all_entries.html
#### Possible fixes ####
* igt@i915_selftest@live@execlists:
- fi-tgl-y: [INCOMPLETE][3] ([i915#1803]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/fi-tgl-y/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/fi-tgl-y/igt@i915_selftest@[email protected]
[i915#1250]: https://gitlab.freedesktop.org/drm/intel/issues/1250
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1803]: https://gitlab.freedesktop.org/drm/intel/issues/1803
Participating hosts (50 -> 42)
------------------------------
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-hsw-4770 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5659 -> IGTPW_4584
CI-20190529: 20190529
CI_DRM_8501: c6bfff03c22fb90dcf1ddacb745667467ab5ab73 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4584: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/index.html
IGT_5659: 66ab5e42811fee3dea8c21ab29e70e323a0650de @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoting Petri Latvala (2020-05-19 10:48:21)
Quoted 9 lines
kms_flip's exit handler was wrapped in an
igt_fixturesome 7 years ago because "it can fail". That's not a problem anymore, asigt_fail()will explicitly handle failing in an exit handler.Rather, using
igt_fixturein an exit handler is harmful because on a subtest failure, we don't always keep track of the currently running context (whether we're inside a subtest anymore) and we forcefully assert correct nesting of IGT magic control blocks now.
Quoted 5 lines
We already know the state is cleanable because we only install the handler on a successful init. Unconditional cleanup in an exit handler is the correct thing to do in general.
Signed-off-by Petri Latvala <[email protected]>
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_flip: Don't use igt_fixture in an exit handler
In reply to Petri Latvala== Series Details ==
== Series Details ==
Series: tests/kms_flip: Don't use igt_fixture in an exit handler
URL : https://patchwork.freedesktop.org/series/77405/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8501_full -> IGTPW_4584_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/index.html
Known issues
------------
Here are the changes found in IGTPW_4584_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gen9_exec_parse@allowed-all:
- shard-apl: [PASS][1] -> [DMESG-WARN][2] ([i915#1436] / [i915#716])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-apl3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-apl6/igt@[email protected]
* igt@kms_atomic_transition@plane-toggle-modeset-transition:
- shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([i915#165] / [i915#78])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-kbl2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-kbl2/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen:
- shard-kbl: [PASS][5] -> [FAIL][6] ([i915#54] / [i915#93] / [i915#95]) +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-kbl6/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-kbl1/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy:
- shard-kbl: [PASS][7] -> [FAIL][8] ([i915#1566] / [i915#93] / [i915#95])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-kbl3/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-kbl1/igt@[email protected]
* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [PASS][9] -> [SKIP][10] ([i915#433])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-tglb2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-tglb8/igt@[email protected]
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([i915#180]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-kbl1/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-kbl6/igt@[email protected]
* igt@kms_mmap_write_crc@main:
- shard-kbl: [PASS][13] -> [FAIL][14] ([i915#93] / [i915#95])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-kbl2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-kbl1/igt@[email protected]
* igt@kms_plane_cursor@pipe-a-viewport-size-64:
- shard-kbl: [PASS][15] -> [FAIL][16] ([i915#1559] / [i915#93] / [i915#95])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-kbl6/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-kbl6/igt@[email protected]
- shard-apl: [PASS][17] -> [FAIL][18] ([i915#1559] / [i915#95])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-apl7/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-apl1/igt@[email protected]
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441]) +3 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-iclb1/igt@kms_psr@psr2_no_drrs.html
#### Possible fixes ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-tglb: [SKIP][21] ([i915#1904]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-tglb8/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-tglb7/igt@[email protected]
* igt@kms_color@pipe-c-degamma:
- shard-apl: [FAIL][23] ([i915#71]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-apl6/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-apl8/igt@[email protected]
- shard-glk: [FAIL][25] ([i915#71]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-glk7/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-glk6/igt@[email protected]
- shard-kbl: [FAIL][27] ([i915#71]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-kbl6/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-kbl4/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen:
- shard-kbl: [FAIL][29] ([i915#54] / [i915#93] / [i915#95]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-kbl6/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-kbl7/igt@[email protected]
* igt@kms_fbcon_fbt@psr-suspend:
- shard-tglb: [FAIL][31] ([i915#1121]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-tglb5/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-tglb2/igt@[email protected]
* {igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2}:
- shard-glk: [FAIL][33] ([i915#79]) -> [PASS][34] +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-glk9/igt@kms_flip@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-glk2/igt@kms_flip@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [DMESG-WARN][35] ([i915#180]) -> [PASS][36] +5 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-kbl6/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-kbl4/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [DMESG-WARN][37] ([i915#180]) -> [PASS][38] +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-apl1/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-apl1/igt@[email protected]
* igt@kms_plane_cursor@pipe-a-overlay-size-64:
- shard-apl: [FAIL][39] ([i915#1559] / [i915#95]) -> [PASS][40] +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-apl4/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-apl6/igt@[email protected]
- shard-kbl: [FAIL][41] ([i915#1559] / [i915#93] / [i915#95]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-kbl4/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-kbl7/igt@[email protected]
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][43] ([fdo#109642] / [fdo#111068]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-iclb1/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-iclb2/igt@[email protected]
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [SKIP][45] ([fdo#109441]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-iclb1/igt@kms_psr@psr2_primary_mmap_gtt.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
* {igt@perf@polling-parameterized}:
- shard-tglb: [FAIL][47] ([i915#1542]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-tglb7/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-tglb2/igt@[email protected]
#### Warnings ####
* igt@kms_content_protection@atomic:
- shard-apl: [TIMEOUT][49] ([i915#1319]) -> [FAIL][50] ([fdo#110321] / [fdo#110336] / [i915#95])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8501/shard-apl3/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/shard-apl4/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#1121]: https://gitlab.freedesktop.org/drm/intel/issues/1121
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1559]: https://gitlab.freedesktop.org/drm/intel/issues/1559
[i915#1566]: https://gitlab.freedesktop.org/drm/intel/issues/1566
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1904]: https://gitlab.freedesktop.org/drm/intel/issues/1904
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#71]: https://gitlab.freedesktop.org/drm/intel/issues/71
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#78]: https://gitlab.freedesktop.org/drm/intel/issues/78
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 8)
------------------------------
Missing (3): pig-skl-6260u pig-glk-j5005 pig-icl-1065g7
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5659 -> IGTPW_4584
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_8501: c6bfff03c22fb90dcf1ddacb745667467ab5ab73 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4584: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/index.html
IGT_5659: 66ab5e42811fee3dea8c21ab29e70e323a0650de @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4584/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev