efi_loader: Remove unnecessary debug
PATCH 1/1 efi_loader: Remove unnecessary debug
Remove unnecessary debug() from efi_set_variable_common(). native_name is NULL, so there is no meaning to print it.
--- lib/efi_loader/efi_variable.c | 2 -- 1 file changed, 2 deletions(-)
lib/efi_loader/efi_variable.c +0 -2
@@ -883,8 +883,6 @@ static efi_status_t efi_set_variable_common(u16 *variable_name,u32 attr;efi_status_t ret =EFI_SUCCESS ; -debug ("%s: set '%s'\n" , __func__, native_name); -if (!variable_name || !*variable_name || !vendor || ((attributes &EFI_VARIABLE_RUNTIME_ACCESS ) && !(attributes &EFI_VARIABLE_BOOTSERVICE_ACCESS ))) {
Signature · 1 line
2.17.1
PATCH 1/1 efi_loader: Remove unnecessary debug
Quoted 4 lines · Pragnesh Patel
Remove unnecessary
debug()fromefi_set_variable_common().native_nameis NULL, so there is no meaning to print it.Signed-off-by Pragnesh Patel <[email protected]>
Quoted 18 lines
--- lib/efi_loader/efi_variable.c | 2 -- 1 file changed, 2 deletions(-)lib/efi_loader/efi_variable.c +0
-2@@ -883,8 +883,6 @@ static efi_status_t efi_set_variable_common(u16 *variable_name,u32 attr;efi_status_t ret =EFI_SUCCESS ; -debug ("%s: set '%s'\n" , __func__, native_name); -if (!variable_name || !*variable_name || !vendor || ((attributes &EFI_VARIABLE_RUNTIME_ACCESS ) && !(attributes &EFI_VARIABLE_BOOTSERVICE_ACCESS ))) {
AKASHI Takahiro
NAKPATCH 1/1 efi_loader: Remove unnecessary debug
Quoted 7 lines · Heinrich Schuchardt
Quoted 4 lines · Pragnesh Patel
Remove unnecessary
debug()fromefi_set_variable_common().native_nameis NULL, so there is no meaning to print it.Signed-off-by Pragnesh Patel <[email protected]>Reviewed-by Heinrich Schuchardt <[email protected]>
Nak
Quoted 11 lines
Quoted 11 lines
lib/efi_loader/efi_variable.c | 2 -- 1 file changed, 2 deletions(-)lib/efi_loader/efi_variable.c +0
-0@@ -883,8 +883,6 @@ static efi_status_t efi_set_variable_common(u16 *variable_name,u32 attr;efi_status_t ret =EFI_SUCCESS ;
Quoted 1 line
lib/efi_loader/efi_variable.c static efi_status_t efi_set_variable_common(u16 *variable_name, · line 886
Quoted 1 line
lib/efi_loader/efi_variable.c +0
-1-debug ("%s: set '%s'\n" , __func__, native_name);
Instead,
debug("%s: set '%ls'\n", __func__, variable_name);It would be helpful for tracing activities.
This function can be used outside of this file, particularly, to handle READ_ONLY variables there.
-Takahiro Akashi
Quoted 6 lines
Quoted 5 lines
lib/efi_loader/efi_variable.c +0
-1-if (!variable_name || !*variable_name || !vendor || ((attributes &EFI_VARIABLE_RUNTIME_ACCESS ) && !(attributes &EFI_VARIABLE_BOOTSERVICE_ACCESS ))) {