Skip to contentSkip to conversation

cryptodev: fix SHA-1 digest enum comment

PATCH Superseded Adam Dybkowski 1 participant 2 messages May 19, 2020

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v2 cover cryptodev: fix SHA-1 digest enum comment

This patch fixes improper SHA-1 digest size in the enum comment and also adds the note about HMAC-SHA-1-96.

v2:
* add info about HMAC-SHA-1-96

Adam Dybkowski (1):
cryptodev: fix SHA-1 digest enum comment

 lib/librte_cryptodev/rte_crypto_sym.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/1 cryptodev: fix SHA-1 digest enum comment

This patch fixes improper SHA-1 digest size in the enum comment and also adds the note about HMAC-SHA-1-96.

Fixes 1bd407fac80b ("cryptodev: extract symmetric operations")
---
 lib/librte_cryptodev/rte_crypto_sym.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
lib/librte_cryptodev/rte_crypto_sym.h +3 -2
index d9585ecd6..db5c5f5b8 100644
@@ -269,9 +269,10 @@ enum rte_crypto_auth_algorithm {
 	/**< HMAC using MD5 algorithm */
 
 	RTE_CRYPTO_AUTH_SHA1,
-	/**< 128 bit SHA algorithm. */
+	/**< 160 bit SHA algorithm. */
 	RTE_CRYPTO_AUTH_SHA1_HMAC,
-	/**< HMAC using 128 bit SHA algorithm. */
+	/**< HMAC using 160 bit SHA algorithm.
+	HMAC-SHA-1-96 can be generated by setting digest_size to 12. */
 	RTE_CRYPTO_AUTH_SHA224,
 	/**< 224 bit SHA algorithm. */
 	RTE_CRYPTO_AUTH_SHA224_HMAC,
Signature · 1 line
2.17.1