Skip to contentSkip to conversation

Remove CROSS_COMPILE default from arch/*/config.mk

PATCH New Tom Rini 3 participants 4 messages May 19, 2020 – Jul 5, 2020

Subsystems (7)
x86 PowerPC SuperH m68k architecture +3 more subsystems
lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 Remove CROSS_COMPILE default from arch/*/config.mk

In order to support the compiler providing information used within Kconfig itself we cannot have the compiler be determined by arch/*/config.mk as we will not be able to evaluate that yet. Given that most documentation tells people to specify CROSS_COMPILE, remove these references.

Cc Huan Wang <[email protected]>
Cc Angelo Dureghello <[email protected]>
Cc Michal Simek <[email protected]>
Cc Rick Chen <[email protected]>
Cc Thomas Chou <[email protected]>
Cc Wolfgang Denk <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Nobuhiro Iwamatsu <[email protected]>
Cc Simon Glass <[email protected]>
Cc Bin Meng <[email protected]>
Cc Max Filippov <[email protected]>
---
 arch/m68k/config.mk       | 4 ----
 arch/microblaze/config.mk | 4 ----
 arch/nds32/config.mk      | 4 ----
 arch/nios2/config.mk      | 4 ----
 arch/powerpc/config.mk    | 4 ----
 arch/sh/config.mk         | 4 ----
 arch/x86/cpu/config.mk    | 2 --
 arch/xtensa/config.mk     | 1 -
 8 files changed, 27 deletions(-)
arch/m68k/config.mk +0 -4
index 88b1a409f260..ed592334af2e 100644
@@ -3,10 +3,6 @@
 # (C) Copyright 2000-2002
 # Wolfgang Denk, DENX Software Engineering, wd at denx.de.
 
-ifeq ($(CROSS_COMPILE),)
-CROSS_COMPILE := m68k-elf-
-endif
-
 CONFIG_STANDALONE_LOAD_ADDR ?= 0x20000
 
 PLATFORM_CPPFLAGS += -D__M68K__
arch/microblaze/config.mk +0 -4
index 3c5866a29528..96c39b1278b1 100644
@@ -6,10 +6,6 @@
 # (C) Copyright 2004 Atmark Techno, Inc.
 # Yasushi SHOJI <[email protected]>
 
-ifeq ($(CROSS_COMPILE),)
-CROSS_COMPILE := mb-
-endif
-
 CONFIG_STANDALONE_LOAD_ADDR ?= 0x80F00000
 
 PLATFORM_CPPFLAGS += -ffixed-r31 -D__microblaze__
arch/nds32/config.mk +0 -4
index a1c3371ddcfd..c82dd69c6c30 100644
@@ -8,10 +8,6 @@
 # Macpaul Lin, Andes Technology Corporation <[email protected]>
 #
 
-ifeq ($(CROSS_COMPILE),)
-CROSS_COMPILE := nds32le-linux-
-endif
-
 CONFIG_STANDALONE_LOAD_ADDR = 0x300000
 LDFLAGS_STANDALONE	+= -T $(srctree)/examples/standalone/nds32.lds
 
arch/nios2/config.mk +0 -4
index c63d170eaee6..44260b1431cb 100644
@@ -4,10 +4,6 @@
 # Psyent Corporation <www.psyent.com>
 # Scott McNutt <[email protected]>
 
-ifeq ($(CROSS_COMPILE),)
-CROSS_COMPILE := nios2-elf-
-endif
-
 CONFIG_STANDALONE_LOAD_ADDR ?= 0x02000000
 
 PLATFORM_CPPFLAGS += -D__NIOS2__
arch/powerpc/config.mk +0 -4
index 88e2c58cb44a..307ca65745c8 100644
@@ -3,10 +3,6 @@
 # (C) Copyright 2000-2010
 # Wolfgang Denk, DENX Software Engineering, wd at denx.de.
 
-ifeq ($(CROSS_COMPILE),)
-CROSS_COMPILE := ppc_8xx-
-endif
-
 CONFIG_STANDALONE_LOAD_ADDR ?= 0x40000
 LDFLAGS_FINAL += --gc-sections
 LDFLAGS_FINAL += --bss-plt
arch/sh/config.mk +0 -4
index 6ef44638abd0..4cdde807245f 100644
@@ -3,10 +3,6 @@
 # (C) Copyright 2000-2002
 # Wolfgang Denk, DENX Software Engineering, wd at denx.de.
 
-ifeq ($(CROSS_COMPILE),)
-CROSS_COMPILE := sh4-linux-
-endif
-
 CONFIG_STANDALONE_LOAD_ADDR ?= 0x8C000000
 ifeq ($(CPU),sh2)
 LDFLAGS_STANDALONE += -EB
arch/x86/cpu/config.mk +0 -2
index 8f9814c0ae7d..d3033b416034 100644
@@ -3,8 +3,6 @@
 # (C) Copyright 2002
 # Daniel Engstr?m, Omicron Ceti AB, daniel at omicron.se.
 
-CROSS_COMPILE ?= i386-linux-
-
 # DO NOT MODIFY THE FOLLOWING UNLESS YOU REALLY KNOW WHAT YOU ARE DOING!
 LDPPFLAGS += -DRESET_SEG_START=$(CONFIG_RESET_SEG_START)
 LDPPFLAGS += -DRESET_VEC_LOC=$(CONFIG_RESET_VEC_LOC)
arch/xtensa/config.mk +0 -1
index ec3710786290..b0809999e403 100644
@@ -3,7 +3,6 @@
 # (C) Copyright 2007 - 2013 Tensilica, Inc.
 # (C) Copyright 2014 - 2016 Cadence Design Systems Inc.
 
-CROSS_COMPILE ?= xtensa-linux-
 PLATFORM_CPPFLAGS += -D__XTENSA__ -mlongcalls -mforce-no-pic \
 		     -ffunction-sections -fdata-sections
 
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 Remove CROSS_COMPILE default from arch/*/config.mk

Quoted 19 lines · Tom Rini

In order to support the compiler providing information used within Kconfig itself we cannot have the compiler be determined by arch/*/config.mk as we will not be able to evaluate that yet. Given that most documentation tells people to specify CROSS_COMPILE, remove these references.

Cc Huan Wang <[email protected]>
Cc Angelo Dureghello <[email protected]>
Cc Michal Simek <[email protected]>
Cc Rick Chen <[email protected]>
Cc Thomas Chou <[email protected]>
Cc Wolfgang Denk <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Nobuhiro Iwamatsu <[email protected]>
Cc Simon Glass <[email protected]>
Cc Bin Meng <[email protected]>
Cc Max Filippov <[email protected]>
Quoted 10 lines
---
 arch/m68k/config.mk       | 4 ----
 arch/microblaze/config.mk | 4 ----
 arch/nds32/config.mk      | 4 ----
 arch/nios2/config.mk      | 4 ----
 arch/powerpc/config.mk    | 4 ----
 arch/sh/config.mk         | 4 ----
 arch/x86/cpu/config.mk    | 2 --
 arch/xtensa/config.mk     | 1 -
 8 files changed, 27 deletions(-)
maintainer
#2 lore raw

PATCH 1/1 Remove CROSS_COMPILE default from arch/*/config.mk

In reply to Tom Rini
Quoted 18 lines · Tom Rini

In order to support the compiler providing information used within Kconfig itself we cannot have the compiler be determined by arch/*/config.mk as we will not be able to evaluate that yet. Given that most documentation tells people to specify CROSS_COMPILE, remove these references.

Cc Huan Wang <[email protected]>
Cc Angelo Dureghello <[email protected]>
Cc Michal Simek <[email protected]>
Cc Rick Chen <[email protected]>
Cc Thomas Chou <[email protected]>
Cc Wolfgang Denk <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Nobuhiro Iwamatsu <[email protected]>
Cc Simon Glass <[email protected]>
Cc Bin Meng <[email protected]>
Cc Max Filippov <[email protected]>
Quoted 3 lines
---
 arch/m68k/config.mk       | 4 ----
 arch/microblaze/config.mk | 4 ----

none is really using it anyway.

Thanks,
Michal

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200520/07d0b475/attachment.sig>

author
#3 lore raw

PATCH 1/1 Remove CROSS_COMPILE default from arch/*/config.mk

In reply to Tom Rini
Quoted 6 lines · Tom Rini

In order to support the compiler providing information used within Kconfig itself we cannot have the compiler be determined by arch/*/config.mk as we will not be able to evaluate that yet. Given that most documentation tells people to specify CROSS_COMPILE, remove these references.

Quoted 14 lines
Cc Huan Wang <[email protected]>
Cc Angelo Dureghello <[email protected]>
Cc Michal Simek <[email protected]>
Cc Rick Chen <[email protected]>
Cc Thomas Chou <[email protected]>
Cc Wolfgang Denk <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Nobuhiro Iwamatsu <[email protected]>
Cc Simon Glass <[email protected]>
Cc Bin Meng <[email protected]>
Cc Max Filippov <[email protected]>

Applied to u-boot/next, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200705/dc702e40/attachment.sig>