Skip to contentSkip to conversation

trusted-firmware-a: re-enable generation of packages

PATCH In review Denys Dmytriyenko 3 participants 5 messages May 19, 2020 – May 21, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 trusted-firmware-a: re-enable generation of packages

From: Denys Dmytriyenko <[email protected]>

There is no need to inherit nopackages. Even when the output binaries are being consumed from deploy or sysroot, and the main binary package is not meant to be installed in the rootfs, package generation is still useful for SDK use cases and as a way to distribute sources (e.g. src.rpm/SRPM) in Distros.

---
 meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc +4 -1
index c9c5710..fe9a4e0 100644
@@ -5,7 +5,7 @@ PROVIDES = "virtual/trusted-firmware-a"
 
 PACKAGE_ARCH = "${MACHINE_ARCH}"
 
-inherit deploy nopackages
+inherit deploy
 
 COMPATIBLE_MACHINE ?= "invalid"
 
@@ -158,7 +158,10 @@ do_install() {
     done
 }
 
+FILES_${PN} = "/firmware"
 SYSROOT_DIRS += "/firmware"
+# Skip QA check for relocations in .text of elf binaries
+INSANE_SKIP_${PN} = "textrel"
 
 do_deploy() {
     cp -rf ${D}/firmware/* ${DEPLOYDIR}/
Signature · 1 line
2.7.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Denys Dmytriyenko via lists.yoctoproject.org
Sent: 19 May 2020 07:35
To: [email protected]
Cc: Denys Dmytriyenko <[email protected]>
Subject: [meta-arm] [PATCH] trusted-firmware-a: re-enable generation of packages

Quoted 8 lines

From: Denys Dmytriyenko <[email protected]>

There is no need to inherit nopackages. Even when the output binaries are being consumed from deploy or sysroot, and the main binary package is not meant to be installed in the rootfs, package generation is still useful for SDK use cases and as a way to distribute sources (e.g. src.rpm/SRPM) in Distros.

Quoted 31 lines
---
 meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc +4 -2
index c9c5710..fe9a4e0 100644
@@ -5,7 +5,7 @@ PROVIDES = "virtual/trusted-firmware-a"
 
 PACKAGE_ARCH = "${MACHINE_ARCH}"
 
-inherit deploy nopackages
+inherit deploy
 
 COMPATIBLE_MACHINE ?= "invalid"
 
@@ -158,7 +158,10 @@ do_install() {
     done
 }
 
+FILES_${PN} = "/firmware"
 SYSROOT_DIRS += "/firmware"
+# Skip QA check for relocations in .text of elf binaries
+INSANE_SKIP_${PN} = "textrel"
 
 do_deploy() {
     cp -rf ${D}/firmware/* ${DEPLOYDIR}/
--

2.7.4

#2 lore raw
Quoted 11 lines · Diego Sueiro
Quoted 11 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Denys Dmytriyenko via lists.yoctoproject.org
Sent: 19 May 2020 07:35
To: [email protected]
Cc: Denys Dmytriyenko <[email protected]>
Subject: [meta-arm] [PATCH] trusted-firmware-a: re-enable generation of packages

From: Denys Dmytriyenko <[email protected]>

Quoted 8 lines
Quoted 6 lines

There is no need to inherit nopackages. Even when the output binaries are being consumed from deploy or sysroot, and the main binary package is not meant to be installed in the rootfs, package generation is still useful for SDK use cases and as a way to distribute sources (e.g. src.rpm/SRPM) in Distros.

Pulled into the master branch.

Thanks,
Jon

Quoted 35 lines
Quoted 32 lines
---
 meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc +4 -2
index c9c5710..fe9a4e0 100644
@@ -5,7 +5,7 @@ PROVIDES = "virtual/trusted-firmware-a"
 
 PACKAGE_ARCH = "${MACHINE_ARCH}"
 
-inherit deploy nopackages
+inherit deploy
 
 COMPATIBLE_MACHINE ?= "invalid"
 
@@ -158,7 +158,10 @@ do_install() {
     done
 }
 
+FILES_${PN} = "/firmware"
 SYSROOT_DIRS += "/firmware"
+# Skip QA check for relocations in .text of elf binaries
+INSANE_SKIP_${PN} = "textrel"
 
 do_deploy() {
     cp -rf ${D}/firmware/* ${DEPLOYDIR}/
--

2.7.4

#3 lore raw
Quoted 17 lines · Jon Mason
Quoted 16 lines · Diego Sueiro
Quoted 16 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Denys Dmytriyenko via lists.yoctoproject.org
Sent: 19 May 2020 07:35
To: [email protected]
Cc: Denys Dmytriyenko <[email protected]>
Subject: [meta-arm] [PATCH] trusted-firmware-a: re-enable generation of packages

From: Denys Dmytriyenko <[email protected]>

There is no need to inherit nopackages. Even when the output binaries are being consumed from deploy or sysroot, and the main binary package is not meant to be installed in the rootfs, package generation is still useful for SDK use cases and as a way to distribute sources (e.g. src.rpm/SRPM) in Distros.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Pulled into the master branch.

Can this be backported to dunfell, please?
Unfortunately, I missed this earlier, but it's required for out whole product, which is beyond just rootfs and there is no easy way to un-inherit nopackages from bbappend... Thanks.

Quoted 41 lines

Thanks,
Jon

Quoted 35 lines
Quoted 32 lines
---
 meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc +4 -2
index c9c5710..fe9a4e0 100644
@@ -5,7 +5,7 @@ PROVIDES = "virtual/trusted-firmware-a"
 
 PACKAGE_ARCH = "${MACHINE_ARCH}"
 
-inherit deploy nopackages
+inherit deploy
 
 COMPATIBLE_MACHINE ?= "invalid"
 
@@ -158,7 +158,10 @@ do_install() {
     done
 }
 
+FILES_${PN} = "/firmware"
 SYSROOT_DIRS += "/firmware"
+# Skip QA check for relocations in .text of elf binaries
+INSANE_SKIP_${PN} = "textrel"
 
 do_deploy() {
     cp -rf ${D}/firmware/* ${DEPLOYDIR}/
--

2.7.4

#4 lore raw
Quoted 20 lines · Denys Dmytriyenko
Quoted 19 lines · Jon Mason
Quoted 18 lines · Diego Sueiro
Quoted 17 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Denys Dmytriyenko via lists.yoctoproject.org
Sent: 19 May 2020 07:35
To: [email protected]
Cc: Denys Dmytriyenko <[email protected]>
Subject: [meta-arm] [PATCH] trusted-firmware-a: re-enable generation of packages

From: Denys Dmytriyenko <[email protected]>

There is no need to inherit nopackages. Even when the output binaries are being consumed from deploy or sysroot, and the main binary package is not meant to be installed in the rootfs, package generation is still useful for SDK use cases and as a way to distribute sources (e.g. src.rpm/SRPM) in Distros.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Pulled into the master branch.

Can this be backported to dunfell, please?
Unfortunately, I missed this earlier, but it's required for out whole product, which is beyond just rootfs and there is no easy way to un-inherit nopackages from bbappend... Thanks.

Done.

Thanks,
Jon

Quoted 44 lines
Quoted 43 lines

Thanks,
Jon

Quoted 35 lines
Quoted 32 lines
---
 meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc +4 -2
index c9c5710..fe9a4e0 100644
@@ -5,7 +5,7 @@ PROVIDES = "virtual/trusted-firmware-a"
 
 PACKAGE_ARCH = "${MACHINE_ARCH}"
 
-inherit deploy nopackages
+inherit deploy
 
 COMPATIBLE_MACHINE ?= "invalid"
 
@@ -158,7 +158,10 @@ do_install() {
     done
 }
 
+FILES_${PN} = "/firmware"
 SYSROOT_DIRS += "/firmware"
+# Skip QA check for relocations in .text of elf binaries
+INSANE_SKIP_${PN} = "textrel"
 
 do_deploy() {
     cp -rf ${D}/firmware/* ${DEPLOYDIR}/
--

2.7.4