Skip to contentSkip to conversation

usb: musb: return -ESHUTDOWN in urb when three-strikes error happened

PATCH Superseded Bin Liu 2 participants 17 messages May 13, 2020 – May 20, 2020

Subsystems (2)
lore
Share & tools
lore

Bin Liu

author maintainer
#0 lore raw

PATCH 1/1 usb: musb: return -ESHUTDOWN in urb when three-strikes error happened

When a USB device attached to a hub got disconnected, MUSB controller generates RXCSR_RX_ERROR interrupt for the 3-strikes-out error.

Currently the MUSB host driver returns -EPROTO in current URB, then the USB device driver could immediately resubmit the URB which causes MUSB generate RXCSR_RX_ERROR interrupt again. This circle causes interrupt storm then the hub never got a chance to report the USB device detach.

To fix the interrupt storm, change the URB return code to -ESHUTDOWN for MUSB_RXCSR_H_ERROR interrupt, so that the USB device driver will not immediately resubmit the URB.

---
 drivers/usb/musb/musb_host.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/musb/musb_host.c +2 -2
index 8736f4251a22..e41d910dcad1 100644
@@ -1774,9 +1774,9 @@ void musb_host_rx(struct musb *musb, u8 epnum)
 		status = -EPIPE;
 
 	} else if (rx_csr & MUSB_RXCSR_H_ERROR) {
-		musb_dbg(musb, "end %d RX proto error", epnum);
+		dev_err(musb->controller, "ep%d RX three-strikes error", epnum);
 
-		status = -EPROTO;
+		status = -ESHUTDOWN;
 		musb_writeb(epio, MUSB_RXINTERVAL, 0);
 
 		rx_csr &= ~MUSB_RXCSR_H_ERROR;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 8 lines · Bin Liu

When a USB device attached to a hub got disconnected, MUSB controller generates RXCSR_RX_ERROR interrupt for the 3-strikes-out error.

Currently the MUSB host driver returns -EPROTO in current URB, then the USB device driver could immediately resubmit the URB which causes MUSB generate RXCSR_RX_ERROR interrupt again. This circle causes interrupt storm then the hub never got a chance to report the USB device detach.

Quoted 5 lines

To fix the interrupt storm, change the URB return code to -ESHUTDOWN for MUSB_RXCSR_H_ERROR interrupt, so that the USB device driver will not immediately resubmit the URB.

Strictly speaking, this is not the right thing to do. It goes against the API described in error-codes.rst. A better approach would be to fix the drivers that immediately resubmit an URB after getting a -EPROTO error. After all, that is the wrong thing to do no matter what sort of host controller the device is attached to.

Alan Stern

author maintainer
#2 lore raw
Quoted 9 lines · Alan Stern
Quoted 8 lines · Bin Liu

When a USB device attached to a hub got disconnected, MUSB controller generates RXCSR_RX_ERROR interrupt for the 3-strikes-out error.

Currently the MUSB host driver returns -EPROTO in current URB, then the USB device driver could immediately resubmit the URB which causes MUSB generate RXCSR_RX_ERROR interrupt again. This circle causes interrupt storm then the hub never got a chance to report the USB device detach.

Quoted 8 lines
Quoted 5 lines

To fix the interrupt storm, change the URB return code to -ESHUTDOWN for MUSB_RXCSR_H_ERROR interrupt, so that the USB device driver will not immediately resubmit the URB.

Strictly speaking, this is not the right thing to do. It goes against the API described in error-codes.rst. A better approach would be to fix

error-codes.rst says:

-ESHUTDOWN The device or host controller has been
disabled due to some problem that could not be worked around, such as a physical disconnect.

So -ESHUTDOWN is applicable in this case - the device is disconnected behind a hub.

Quoted 1 line

the drivers that immediately resubmit an URB after getting a -EPROTO

This has been discussed before [1]. And John indicated there are many device drivers do not delay when resubmitting after getting -EPROTO [2], and it is quite bit of work to fix it in all device drivers [3]. So better to solve the issue in HCD.

Quoted 2 lines

error. After all, that is the wrong thing to do no matter what sort of host controller the device is attached to.

[1] https://www.spinics.net/lists/linux-usb/msg175292.html
[2] https://www.spinics.net/lists/linux-usb/msg176327.html
[3] https://www.spinics.net/lists/linux-usb/msg176375.html

-Bin.

#3 lore raw
Quoted 21 lines · Bin Liu
Quoted 9 lines · Alan Stern
Quoted 8 lines · Bin Liu

When a USB device attached to a hub got disconnected, MUSB controller generates RXCSR_RX_ERROR interrupt for the 3-strikes-out error.

Currently the MUSB host driver returns -EPROTO in current URB, then the USB device driver could immediately resubmit the URB which causes MUSB generate RXCSR_RX_ERROR interrupt again. This circle causes interrupt storm then the hub never got a chance to report the USB device detach.

Quoted 8 lines
Quoted 5 lines

To fix the interrupt storm, change the URB return code to -ESHUTDOWN for MUSB_RXCSR_H_ERROR interrupt, so that the USB device driver will not immediately resubmit the URB.

Strictly speaking, this is not the right thing to do. It goes against the API described in error-codes.rst. A better approach would be to fix

error-codes.rst says:

Quoted 7 lines

-ESHUTDOWN The device or host controller has been
disabled due to some problem that could not be worked around, such as a physical disconnect.

So -ESHUTDOWN is applicable in this case - the device is disconnected behind a hub.

Yes, but you don't _know_ that the device was disconnected. All you know is that there was a 3-strikes error. Other problems can cause such errors (noise, for example).

Alan Stern

author maintainer
#4 lore raw
Quoted 27 lines · Alan Stern
Quoted 26 lines · Bin Liu
Quoted 9 lines · Alan Stern
Quoted 8 lines · Bin Liu

When a USB device attached to a hub got disconnected, MUSB controller generates RXCSR_RX_ERROR interrupt for the 3-strikes-out error.

Currently the MUSB host driver returns -EPROTO in current URB, then the USB device driver could immediately resubmit the URB which causes MUSB generate RXCSR_RX_ERROR interrupt again. This circle causes interrupt storm then the hub never got a chance to report the USB device detach.

Quoted 8 lines
Quoted 5 lines

To fix the interrupt storm, change the URB return code to -ESHUTDOWN for MUSB_RXCSR_H_ERROR interrupt, so that the USB device driver will not immediately resubmit the URB.

Strictly speaking, this is not the right thing to do. It goes against the API described in error-codes.rst. A better approach would be to fix

error-codes.rst says:

-ESHUTDOWN The device or host controller has been
disabled due to some problem that could not be worked around, such as a physical disconnect.

Quoted 6 lines
Quoted 2 lines

So -ESHUTDOWN is applicable in this case - the device is disconnected behind a hub.

Yes, but you don't _know_ that the device was disconnected. All you know is that there was a 3-strikes error. Other problems can cause such errors (noise, for example).

Yes, I know this. But we don't have a solution then. I cannot add resubmit delay in those ~500 device drivers.

-Bin.

author maintainer
#5 lore raw
Quoted 31 lines · Bin Liu
Quoted 30 lines · Alan Stern
Quoted 28 lines · Bin Liu
Quoted 9 lines · Alan Stern
Quoted 8 lines · Bin Liu

When a USB device attached to a hub got disconnected, MUSB controller generates RXCSR_RX_ERROR interrupt for the 3-strikes-out error.

Currently the MUSB host driver returns -EPROTO in current URB, then the USB device driver could immediately resubmit the URB which causes MUSB generate RXCSR_RX_ERROR interrupt again. This circle causes interrupt storm then the hub never got a chance to report the USB device detach.

Quoted 8 lines
Quoted 5 lines

To fix the interrupt storm, change the URB return code to -ESHUTDOWN for MUSB_RXCSR_H_ERROR interrupt, so that the USB device driver will not immediately resubmit the URB.

Strictly speaking, this is not the right thing to do. It goes against the API described in error-codes.rst. A better approach would be to fix

error-codes.rst says:

-ESHUTDOWN The device or host controller has been
disabled due to some problem that could not be worked around, such as a physical disconnect.

So -ESHUTDOWN is applicable in this case - the device is disconnected behind a hub.

Quoted 6 lines
Quoted 3 lines

Yes, but you don't _know_ that the device was disconnected. All you know is that there was a 3-strikes error. Other problems can cause such errors (noise, for example).

Yes, I know this. But we don't have a solution then. I cannot add resubmit delay in those ~500 device drivers.

By the way I don't think noise could last long enough to cause 3-strikes error. A shortest USB packet is about 3-bytes long, a noise should be just a glitch, it won't last at least 3-bytes long to supress the bus and 3 times on the exact timing when the host expecting a response packet. I cannot think of any other reason which can cause the 3-strikes error other than the device is off the bus.

-Bin.

#6 lore raw
Quoted 39 lines · Bin Liu
Quoted 31 lines · Bin Liu
Quoted 30 lines · Alan Stern
Quoted 28 lines · Bin Liu
Quoted 9 lines · Alan Stern
Quoted 8 lines · Bin Liu

When a USB device attached to a hub got disconnected, MUSB controller generates RXCSR_RX_ERROR interrupt for the 3-strikes-out error.

Currently the MUSB host driver returns -EPROTO in current URB, then the USB device driver could immediately resubmit the URB which causes MUSB generate RXCSR_RX_ERROR interrupt again. This circle causes interrupt storm then the hub never got a chance to report the USB device detach.

Quoted 8 lines
Quoted 5 lines

To fix the interrupt storm, change the URB return code to -ESHUTDOWN for MUSB_RXCSR_H_ERROR interrupt, so that the USB device driver will not immediately resubmit the URB.

Strictly speaking, this is not the right thing to do. It goes against the API described in error-codes.rst. A better approach would be to fix

error-codes.rst says:

-ESHUTDOWN The device or host controller has been
disabled due to some problem that could not be worked around, such as a physical disconnect.

So -ESHUTDOWN is applicable in this case - the device is disconnected behind a hub.

Quoted 6 lines
Quoted 3 lines

Yes, but you don't _know_ that the device was disconnected. All you know is that there was a 3-strikes error. Other problems can cause such errors (noise, for example).

Yes, I know this. But we don't have a solution then. I cannot add resubmit delay in those ~500 device drivers.

Quoted 6 lines

By the way I don't think noise could last long enough to cause 3-strikes error. A shortest USB packet is about 3-bytes long, a noise should be just a glitch, it won't last at least 3-bytes long to supress the bus and 3 times on the exact timing when the host expecting a response packet. I cannot think of any other reason which can cause the 3-strikes error other than the device is off the bus.

Heh. I heard from somebody (many years ago) about a setup where one of his USB devices stopped working whenever he turned on the fluorescent lights.

Yes, I agree that noise is pretty uncommon, and the vast majority of 3-strikes errors are caused by disconnection or device firmware bugs. That's why I didn't NAK this patch.

Still, it's worth pointing out that this change abuses the API (perhaps mentioning it in a comment). And it still would be preferable to fix the drivers in question, impractical though that may be. (I have a hard time believing there are really 500 of them getting this wrong...)

Alan Stern

author maintainer
#7 lore raw
Quoted 47 lines · Alan Stern
Quoted 39 lines · Bin Liu
Quoted 31 lines · Bin Liu
Quoted 30 lines · Alan Stern
Quoted 28 lines · Bin Liu
Quoted 9 lines · Alan Stern
Quoted 8 lines · Bin Liu

When a USB device attached to a hub got disconnected, MUSB controller generates RXCSR_RX_ERROR interrupt for the 3-strikes-out error.

Currently the MUSB host driver returns -EPROTO in current URB, then the USB device driver could immediately resubmit the URB which causes MUSB generate RXCSR_RX_ERROR interrupt again. This circle causes interrupt storm then the hub never got a chance to report the USB device detach.

Quoted 8 lines
Quoted 5 lines

To fix the interrupt storm, change the URB return code to -ESHUTDOWN for MUSB_RXCSR_H_ERROR interrupt, so that the USB device driver will not immediately resubmit the URB.

Strictly speaking, this is not the right thing to do. It goes against the API described in error-codes.rst. A better approach would be to fix

error-codes.rst says:

-ESHUTDOWN The device or host controller has been
disabled due to some problem that could not be worked around, such as a physical disconnect.

So -ESHUTDOWN is applicable in this case - the device is disconnected behind a hub.

Quoted 6 lines
Quoted 3 lines

Yes, but you don't _know_ that the device was disconnected. All you know is that there was a 3-strikes error. Other problems can cause such errors (noise, for example).

Yes, I know this. But we don't have a solution then. I cannot add resubmit delay in those ~500 device drivers.

Quoted 6 lines

By the way I don't think noise could last long enough to cause 3-strikes error. A shortest USB packet is about 3-bytes long, a noise should be just a glitch, it won't last at least 3-bytes long to supress the bus and 3 times on the exact timing when the host expecting a response packet. I cannot think of any other reason which can cause the 3-strikes error other than the device is off the bus.

Quoted 3 lines

Heh. I heard from somebody (many years ago) about a setup where one of his USB devices stopped working whenever he turned on the fluorescent lights.

This could happen, noise comming in from the power supply, cheap power supply and poor board design.

Quoted 2 lines

Yes, I agree that noise is pretty uncommon, and the vast majority of 3-strikes errors are caused by disconnection or device firmware bugs.

I wasn't mean noise is uncommon, it is just it won't cause 3-strikes error because the glitch is very short. I have seen many cases that noise causing issues on MUSB due to poor board design especially on those USB modem or WIFI projects.

Quoted 1 line

That's why I didn't NAK this patch.

Thanks.

Quoted 2 lines

Still, it's worth pointing out that this change abuses the API (perhaps mentioning it in a comment). And it still would be preferable to fix

Okay, I will add those notes in comment in v2.

Quoted 2 lines

the drivers in question, impractical though that may be. (I have a hard time believing there are really 500 of them getting this wrong...)

I am not sure about it either, but yeah it is not practical to fix the issue in device drivers. So far I have seen 3 reports of this issue:

1. with FTDI usb-serial adapter, the issue is in the usb serial generic driver;

2. with a modem, the issue is in usb wwan driver as I fixed in the patch I sent yesterday;

2. another modem, before I was able to locate the offending device driver, the guy who reported the issue disappeared, and not responding me.

-Bin.

#8 lore raw
Quoted 5 lines · Bin Liu
Quoted 2 lines

Still, it's worth pointing out that this change abuses the API (perhaps mentioning it in a comment). And it still would be preferable to fix

Okay, I will add those notes in comment in v2.

Quoted 8 lines
Quoted 2 lines

the drivers in question, impractical though that may be. (I have a hard time believing there are really 500 of them getting this wrong...)

I am not sure about it either, but yeah it is not practical to fix the issue in device drivers. So far I have seen 3 reports of this issue:

1. with FTDI usb-serial adapter, the issue is in the usb serial generic driver;

It shouldn't be hard to fix this. We don't even need a delayed retry; the driver can simply treat -EPROTO as an unrecoverable error, just like -ESHUTDOWN.

Alan Stern

Quoted 8 lines

2. with a modem, the issue is in usb wwan driver as I fixed in the patch I sent yesterday;

2. another modem, before I was able to locate the offending device driver, the guy who reported the issue disappeared, and not responding me.

-Bin.

author maintainer
#9 lore raw
Quoted 13 lines · Alan Stern
Quoted 11 lines · Bin Liu
Quoted 2 lines

Still, it's worth pointing out that this change abuses the API (perhaps mentioning it in a comment). And it still would be preferable to fix

Okay, I will add those notes in comment in v2.

Quoted 2 lines

the drivers in question, impractical though that may be. (I have a hard time believing there are really 500 of them getting this wrong...)

I am not sure about it either, but yeah it is not practical to fix the issue in device drivers. So far I have seen 3 reports of this issue:

Quoted 6 lines
Quoted 2 lines

1. with FTDI usb-serial adapter, the issue is in the usb serial generic driver;

It shouldn't be hard to fix this. We don't even need a delayed retry; the driver can simply treat -EPROTO as an unrecoverable error, just like -ESHUTDOWN.

This is just an example showing that it is not practical to fix the problem in device drivers.

BTY, I just briefly searched the drivers/ folder, there are only three drivers handle -EPROTO specifically in rx callback and bail out. So seems most drivers do not care about -EPROTO.

-Bin.

#10 lore raw
Quoted 21 lines · Bin Liu
Quoted 13 lines · Alan Stern
Quoted 11 lines · Bin Liu
Quoted 2 lines

Still, it's worth pointing out that this change abuses the API (perhaps mentioning it in a comment). And it still would be preferable to fix

Okay, I will add those notes in comment in v2.

Quoted 2 lines

the drivers in question, impractical though that may be. (I have a hard time believing there are really 500 of them getting this wrong...)

I am not sure about it either, but yeah it is not practical to fix the issue in device drivers. So far I have seen 3 reports of this issue:

Quoted 6 lines
Quoted 2 lines

1. with FTDI usb-serial adapter, the issue is in the usb serial generic driver;

It shouldn't be hard to fix this. We don't even need a delayed retry; the driver can simply treat -EPROTO as an unrecoverable error, just like -ESHUTDOWN.

Quoted 6 lines

This is just an example showing that it is not practical to fix the problem in device drivers.

BTY, I just briefly searched the drivers/ folder, there are only three drivers handle -EPROTO specifically in rx callback and bail out. So seems most drivers do not care about -EPROTO.

Then do you think we should change the API?

Right now it's a little too complicated. There's no real reason for EPROTO, EILSEQ, and ETIME to be different codes. And now you seem to be suggesting that we should fold them all into ESHUTDOWN.

Alan Stern

author maintainer
#11 lore raw
Quoted 29 lines · Alan Stern
Quoted 21 lines · Bin Liu
Quoted 13 lines · Alan Stern
Quoted 11 lines · Bin Liu
Quoted 2 lines

Still, it's worth pointing out that this change abuses the API (perhaps mentioning it in a comment). And it still would be preferable to fix

Okay, I will add those notes in comment in v2.

Quoted 2 lines

the drivers in question, impractical though that may be. (I have a hard time believing there are really 500 of them getting this wrong...)

I am not sure about it either, but yeah it is not practical to fix the issue in device drivers. So far I have seen 3 reports of this issue:

Quoted 6 lines
Quoted 2 lines

1. with FTDI usb-serial adapter, the issue is in the usb serial generic driver;

It shouldn't be hard to fix this. We don't even need a delayed retry; the driver can simply treat -EPROTO as an unrecoverable error, just like -ESHUTDOWN.

Quoted 6 lines

This is just an example showing that it is not practical to fix the problem in device drivers.

BTY, I just briefly searched the drivers/ folder, there are only three drivers handle -EPROTO specifically in rx callback and bail out. So seems most drivers do not care about -EPROTO.

Quoted 5 lines

Then do you think we should change the API?

Right now it's a little too complicated. There's no real reason for EPROTO, EILSEQ, and ETIME to be different codes. And now you seem to be suggesting that we should fold them all into ESHUTDOWN.

I haven't studied all the USB error code enough to suggest this. I am only changing to ESHUTDOWN in musb driver because I know this 3-strikes error should only be caused by USB device disabled, which is the definition of ESHUTDOWN in error-code.rst.

-Bin.

#12 lore raw
Quoted 10 lines
Quoted 5 lines

Then do you think we should change the API?

Right now it's a little too complicated. There's no real reason for EPROTO, EILSEQ, and ETIME to be different codes. And now you seem to be suggesting that we should fold them all into ESHUTDOWN.

I haven't studied all the USB error code enough to suggest this. I am only changing to ESHUTDOWN in musb driver because I know this 3-strikes error should only be caused by USB device disabled, which is the definition of ESHUTDOWN in error-code.rst.

You should spend a little time studying the error-codes document. EPROTO, EILSEQ, and ETIME describe different kinds of errors that all fall into the 3-strikes category.

Alan Stern

author maintainer
#13 lore raw
Quoted 6 lines · Alan Stern
Quoted 6 lines
Quoted 5 lines

Then do you think we should change the API?

Right now it's a little too complicated. There's no real reason for EPROTO, EILSEQ, and ETIME to be different codes. And now you seem to be suggesting that we should fold them all into ESHUTDOWN.

Quoted 8 lines
Quoted 4 lines

I haven't studied all the USB error code enough to suggest this. I am only changing to ESHUTDOWN in musb driver because I know this 3-strikes error should only be caused by USB device disabled, which is the definition of ESHUTDOWN in error-code.rst.

You should spend a little time studying the error-codes document. EPROTO, EILSEQ, and ETIME describe different kinds of errors that all fall into the 3-strikes category.

But not all device drivers, except the 3 I found, treat EPROTO as fatal, and I cannot fix it in all the device drivers. The only thing I can do at this moment is changing the MUSB HCD driver to return ESHUTDOWN which still follows the document, kind of.

-Bin.

#14 lore raw
Quoted 12 lines · Bin Liu
Quoted 11 lines · Alan Stern
Quoted 10 lines
Quoted 5 lines

Then do you think we should change the API?

Right now it's a little too complicated. There's no real reason for EPROTO, EILSEQ, and ETIME to be different codes. And now you seem to be suggesting that we should fold them all into ESHUTDOWN.

I haven't studied all the USB error code enough to suggest this. I am only changing to ESHUTDOWN in musb driver because I know this 3-strikes error should only be caused by USB device disabled, which is the definition of ESHUTDOWN in error-code.rst.

Quoted 8 lines
Quoted 3 lines

You should spend a little time studying the error-codes document. EPROTO, EILSEQ, and ETIME describe different kinds of errors that all fall into the 3-strikes category.

But not all device drivers, except the 3 I found, treat EPROTO as fatal, and I cannot fix it in all the device drivers. The only thing I can do at this moment is changing the MUSB HCD driver to return ESHUTDOWN which still follows the document, kind of.

Think long-term. Yes, for now you're focused on changing the MUSB HCD. But what should happen in the future?

At some point we all need to stop reacting and start making some deliberate plans. This issue is bigger than one patch or one driver.

Alan Stern

author maintainer
#15 lore raw
Quoted 22 lines · Alan Stern
Quoted 12 lines · Bin Liu
Quoted 11 lines · Alan Stern
Quoted 10 lines
Quoted 5 lines

Then do you think we should change the API?

Right now it's a little too complicated. There's no real reason for EPROTO, EILSEQ, and ETIME to be different codes. And now you seem to be suggesting that we should fold them all into ESHUTDOWN.

I haven't studied all the USB error code enough to suggest this. I am only changing to ESHUTDOWN in musb driver because I know this 3-strikes error should only be caused by USB device disabled, which is the definition of ESHUTDOWN in error-code.rst.

Quoted 8 lines
Quoted 3 lines

You should spend a little time studying the error-codes document. EPROTO, EILSEQ, and ETIME describe different kinds of errors that all fall into the 3-strikes category.

But not all device drivers, except the 3 I found, treat EPROTO as fatal, and I cannot fix it in all the device drivers. The only thing I can do at this moment is changing the MUSB HCD driver to return ESHUTDOWN which still follows the document, kind of.

Quoted 5 lines

Think long-term. Yes, for now you're focused on changing the MUSB HCD. But what should happen in the future?

At some point we all need to stop reacting and start making some deliberate plans. This issue is bigger than one patch or one driver.

Yes, the issue big, not all device drivers treat the urb error status properly. As the case #3 I mentioned earlier, even MUSB HCD returns ESHUTDOWN, the interrupt storm still happens. Unfortunately before I located the offending device driver, the remote setup is gone...

I agree with you, we probably should simply the number of the error code based on the real usecases and the handlings in device drivers.

-Bin.

author maintainer
#16 lore raw

PATCH v2 1/1 usb: musb: return -ESHUTDOWN in urb when three-strikes error happened

In reply to Alan Stern

When a USB device attached to a hub got disconnected, MUSB controller generates RXCSR_RX_ERROR interrupt for the 3-strikes-out error.

Currently the MUSB host driver returns -EPROTO in current URB, then the USB device driver could immediately resubmit the URB which causes MUSB generate RXCSR_RX_ERROR interrupt again. This circle causes interrupt storm then the hub never got a chance to report the USB device detach.

To fix the interrupt storm, change the URB return code to -ESHUTDOWN for MUSB_RXCSR_H_ERROR interrupt, so that the USB device driver will not immediately resubmit the URB.

---
v2: added inline comments

 drivers/usb/musb/musb_host.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/usb/musb/musb_host.c +8 -2
index 8736f4251a22..8b7d22a0c0fb 100644
@@ -1774,9 +1774,15 @@ void musb_host_rx(struct musb *musb, u8 epnum)
 		status = -EPIPE;
 
 	} else if (rx_csr & MUSB_RXCSR_H_ERROR) {
-		musb_dbg(musb, "end %d RX proto error", epnum);
+		dev_err(musb->controller, "ep%d RX three-strikes error", epnum);
 
-		status = -EPROTO;
+		/*
+		 * The three-strikes error could only happen when the USB
+		 * device is not accessible, for example detached or powered
+		 * off. So return the fatal error -ESHUTDOWN so hopefully the
+		 * USB device drivers won't immediately resubmit the same URB.
+		 */
+		status = -ESHUTDOWN;
 		musb_writeb(epio, MUSB_RXINTERVAL, 0);
 
 		rx_csr &= ~MUSB_RXCSR_H_ERROR;
Signature · 1 line
2.17.1