Skip to contentSkip to conversation

tests/i915_fb_tiling: Check if device supports tiling

PATCH In review Ashutosh Dixit 3 participants 6 messages May 19, 2020 – May 20, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 tests/i915_fb_tiling: Check if device supports tiling

From: Vanshidhar Konda <[email protected]>

Skip this test if the platform does not support setting tiling for frame buffer object.

---
 tests/i915/i915_fb_tiling.c | 2 ++
 1 file changed, 2 insertions(+)
tests/i915/i915_fb_tiling.c +2 -0
index 7d5c3f1fa..02b3f4c4b 100644
@@ -32,6 +32,8 @@ igt_simple_main
 	struct igt_fb fb;
 	int ret;
 
+	igt_require(gem_available_fences(drm_fd) > 0);
+
 	igt_create_fb(drm_fd, 512, 512, DRM_FORMAT_XRGB8888,
 		      LOCAL_I915_FORMAT_MOD_X_TILED, &fb);
 
Signature · 6 lines
2.26.2.593.gb994622632

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

PATCH 2/2 tests/kms_addfb_basic: Skip tiling subtests on device without fences

From: Vanshidhar Konda <[email protected]>

Skip subtests that are testing interoperability of FB modifiers and hardware tiling if the device does not support HW tiling.

---
 tests/kms_addfb_basic.c | 4 ++++
 1 file changed, 4 insertions(+)
tests/kms_addfb_basic.c +4 -0
index 666e7165e..1f637a61b 100644
@@ -132,6 +132,7 @@ static void invalid_tests(int fd)
 
 	igt_subtest("clobberred-modifier") {
 		igt_require_intel(fd);
+		igt_require(gem_available_fences(fd) > 0);
 		f.flags = 0;
 		f.modifier[0] = 0;
 		gem_set_tiling(fd, gem_bo, I915_TILING_X, 512*4);
@@ -304,6 +305,7 @@ static void tiling_tests(int fd)
 	igt_subtest_group {
 		igt_fixture {
 			igt_require_intel(fd);
+			igt_require(gem_available_fences(fd) > 0);
 			tiled_x_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
 				DRM_FORMAT_XRGB8888, LOCAL_I915_FORMAT_MOD_X_TILED,
 				1024*4, NULL, NULL, NULL);
@@ -450,6 +452,7 @@ static void size_tests(int fd)
 
 	igt_subtest("bo-too-small-due-to-tiling") {
 		igt_require_intel(fd);
+		igt_require(gem_available_fences(fd) > 0);
 		gem_set_tiling(fd, gem_bo_small, I915_TILING_X, 1024*4);
 		igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
 			   errno == EINVAL);
@@ -502,6 +505,7 @@ static void addfb25_tests(int fd)
 	igt_subtest_group {
 		igt_fixture {
 			igt_require_intel(fd);
+			igt_require(gem_available_fences(fd) > 0);
 			gem_set_tiling(fd, gem_bo, I915_TILING_X, 1024*4);
 			igt_require_fb_modifiers(fd);
 		}
Signature · 6 lines
2.26.2.593.gb994622632

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#2 lore raw

Re: [igt-dev] [PATCH i-g-t 2/2] tests/kms_addfb_basic: Skip tiling subtests on device without fences

Quoting Ashutosh Dixit (2020-05-19 20:13:46)

Quoted 4 lines

From: Vanshidhar Konda <[email protected]>

Skip subtests that are testing interoperability of FB modifiers and hardware tiling if the device does not support HW tiling.

The display engine still supports HW tiling. Here you are just checking the interactions with set-tiling, which is still in doubt. -Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#3 lore raw
In reply to Ashutosh Dixit

Quoting Ashutosh Dixit (2020-05-19 20:13:45)

Quoted 4 lines

From: Vanshidhar Konda <[email protected]>

Skip this test if the platform does not support setting tiling for frame buffer object.

This skips if there are no fences, but the frame buffer may still be tiled, and preferentially will be. You are not describing the intent of the test, nor how this change impacts it, very well.

Quoted 13 lines
---
 tests/i915/i915_fb_tiling.c | 2 ++
 1 file changed, 2 insertions(+)
tests/i915/i915_fb_tiling.c +0 -0
index 7d5c3f1fa..02b3f4c4b 100644

tests/i915/i915_fb_tiling.c igt_simple_main · line 38

Quoted 7 lines
tests/i915/i915_fb_tiling.c +2 -0
@@ -32,6 +32,8 @@ igt_simple_main
        struct igt_fb fb;
        int ret;
 
+       igt_require(gem_available_fences(drm_fd) > 0);
+
        igt_create_fb(drm_fd, 512, 512, DRM_FORMAT_XRGB8888,
                      LOCAL_I915_FORMAT_MOD_X_TILED, &fb);

A better patch would be to require instead of assert in the first check, since that is the essence of what the test entails.
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#4 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/i915_fb_tiling: Check if device supports tiling

In reply to Ashutosh Dixit
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,1/2] tests/i915_fb_tiling: Check if device supports tiling
URL : https://patchwork.freedesktop.org/series/77434/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8506 -> IGTPW_4594
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/index.html

Known issues
------------

Here are the changes found in IGTPW_4594 that come from known issues:

### IGT changes ###

#### Possible fixes ####

* igt@i915_selftest@live@execlists:
- fi-kbl-8809g: [INCOMPLETE][1] ([i915#1874]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/fi-kbl-8809g/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/fi-kbl-8809g/igt@i915_selftest@[email protected]

[i915#1874]: https://gitlab.freedesktop.org/drm/intel/issues/1874

Participating hosts (49 -> 42)
------------------------------

Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-hsw-4770 fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5661 -> IGTPW_4594

CI-20190529: 20190529
CI_DRM_8506: d6a73e9084ff6adfabbad014bc294d254484f304 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4594: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/index.html
IGT_5661: a772a7c7a761c6125bc0af5284ad603478107737 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#5 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] tests/i915_fb_tiling: Check if device supports tiling

In reply to Ashutosh Dixit
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,1/2] tests/i915_fb_tiling: Check if device supports tiling
URL : https://patchwork.freedesktop.org/series/77434/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_8506_full -> IGTPW_4594_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_4594_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_4594_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_4594_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_panel_fitting@atomic-fastset:
- shard-iclb: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-iclb6/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-iclb1/igt@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* {igt@kms_flip@flip-vs-suspend-interruptible@c-edp1}:
- shard-iclb: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-iclb5/igt@kms_flip@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-iclb3/igt@kms_flip@[email protected]

Known issues
------------

Here are the changes found in IGTPW_4594_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_softpin@noreloc-s3:
- shard-kbl: [PASS][5] -> [DMESG-WARN][6] ([i915#180])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-kbl6/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-kbl1/igt@[email protected]

* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-tglb: [PASS][7] -> [SKIP][8] ([i915#1904])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-tglb2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-tglb1/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen:
- shard-kbl: [PASS][9] -> [FAIL][10] ([i915#54] / [i915#93] / [i915#95])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-kbl1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-kbl6/igt@[email protected]

* igt@kms_cursor_legacy@all-pipes-torture-move:
- shard-iclb: [PASS][11] -> [DMESG-WARN][12] ([i915#128])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-iclb6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-iclb1/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-pwrite-untiled:
- shard-kbl: [PASS][13] -> [FAIL][14] ([i915#177] / [i915#52] / [i915#54] / [i915#93] / [i915#95])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-kbl7/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-kbl4/igt@[email protected]
- shard-apl: [PASS][15] -> [FAIL][16] ([i915#52] / [i915#54] / [i915#95])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-apl4/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-apl7/igt@[email protected]

* igt@kms_flip_tiling@flip-changes-tiling-y:
- shard-apl: [PASS][17] -> [FAIL][18] ([i915#95]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-apl4/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-apl1/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-apl: [PASS][19] -> [DMESG-WARN][20] ([i915#180]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-apl6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-apl6/igt@[email protected]

* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#109441]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-iclb8/igt@kms_psr@psr2_primary_page_flip.html

#### Possible fixes ####

* igt@gen9_exec_parse@allowed-all:
- shard-apl: [DMESG-WARN][23] ([i915#1436] / [i915#716]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-apl6/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-apl7/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen:
- shard-kbl: [FAIL][25] ([i915#54] / [i915#93] / [i915#95]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-kbl1/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-kbl6/igt@[email protected]

* {igt@kms_flip@flip-vs-suspend-interruptible@c-dp1}:
- shard-apl: [DMESG-WARN][27] ([i915#180]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-apl4/igt@kms_flip@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-apl4/igt@kms_flip@[email protected]

* {igt@kms_flip@flip-vs-suspend@a-dp1}:
- shard-kbl: [DMESG-WARN][29] ([i915#180]) -> [PASS][30] +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-kbl1/igt@kms_flip@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-kbl2/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-cpu:
- shard-snb: [SKIP][31] ([fdo#109271]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-snb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-cpu.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-snb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-cpu.html

* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [SKIP][33] ([fdo#109441]) -> [PASS][34] +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-iclb8/igt@kms_psr@psr2_primary_mmap_gtt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html

* igt@kms_setmode@basic:
- shard-kbl: [FAIL][35] ([i915#31]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-kbl6/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-kbl6/igt@[email protected]

* {igt@prime_vgem@sync@rcs0}:
- shard-iclb: [INCOMPLETE][37] ([i915#409]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-iclb8/igt@prime_vgem@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-iclb8/igt@prime_vgem@[email protected]

#### Warnings ####

* igt@kms_content_protection@legacy:
- shard-apl: [TIMEOUT][39] ([i915#1319]) -> [FAIL][40] ([fdo#110321] / [fdo#110336])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-apl3/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-apl1/igt@[email protected]

* igt@kms_content_protection@lic:
- shard-apl: [FAIL][41] ([fdo#110321]) -> [TIMEOUT][42] ([i915#1319])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-apl6/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-apl7/igt@[email protected]

* igt@kms_content_protection@srm:
- shard-apl: [TIMEOUT][43] ([i915#1319]) -> [FAIL][44] ([fdo#110321])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-apl8/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-apl3/igt@[email protected]

* igt@kms_content_protection@uevent:
- shard-kbl: [FAIL][45] ([i915#357]) -> [FAIL][46] ([i915#357] / [i915#93] / [i915#95])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-kbl6/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-kbl3/igt@[email protected]
- shard-apl: [FAIL][47] ([i915#357]) -> [FAIL][48] ([i915#357] / [i915#95])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-apl3/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-apl7/igt@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [FAIL][49] ([i915#1121] / [i915#95]) -> [DMESG-FAIL][50] ([i915#180] / [i915#95])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-apl6/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-apl1/igt@[email protected]
- shard-kbl: [DMESG-FAIL][51] ([i915#180] / [i915#95]) -> [FAIL][52] ([i915#1121] / [i915#93] / [i915#95])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-kbl1/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-kbl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-kbl: [FAIL][53] ([fdo#108145] / [i915#265] / [i915#93] / [i915#95]) -> [FAIL][54] ([fdo#108145] / [i915#265])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-kbl6/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-kbl4/igt@[email protected]
- shard-apl: [FAIL][55] ([fdo#108145] / [i915#265] / [i915#95]) -> [FAIL][56] ([fdo#108145] / [i915#265])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-apl4/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/shard-apl7/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
[i915#1121]: https://gitlab.freedesktop.org/drm/intel/issues/1121
[i915#128]: https://gitlab.freedesktop.org/drm/intel/issues/128
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#177]: https://gitlab.freedesktop.org/drm/intel/issues/177
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1904]: https://gitlab.freedesktop.org/drm/intel/issues/1904
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#357]: https://gitlab.freedesktop.org/drm/intel/issues/357
[i915#409]: https://gitlab.freedesktop.org/drm/intel/issues/409
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95

Participating hosts (11 -> 8)
------------------------------

Missing (3): pig-skl-6260u pig-glk-j5005 pig-icl-1065g7

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5661 -> IGTPW_4594
* Piglit: piglit_4509 -> None

CI-20190529: 20190529
CI_DRM_8506: d6a73e9084ff6adfabbad014bc294d254484f304 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4594: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/index.html
IGT_5661: a772a7c7a761c6125bc0af5284ad603478107737 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4594/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev