Skip to contentSkip to conversation

net: unexport skb_gro_receive()

PATCH In review Eric Dumazet 2 participants 4 messages May 19, 2020 – May 20, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: unexport skb_gro_receive()

skb_gro_receive() used to be used by SCTP, it is no longer the case.

skb_gro_receive_list() is in the same category : never used from modules.

---
 net/core/skbuff.c | 2 --
 1 file changed, 2 deletions(-)
net/core/skbuff.c +0 -2
index 7e29590482ce509ea1d3b2306f4796f697b76d4f..4dd13e9b92d61e44ec4cda95fa64f72dcc5f6a71 100644
@@ -3727,7 +3727,6 @@ int skb_gro_receive_list(struct sk_buff *p, struct sk_buff *skb)
 
 	return 0;
 }
-EXPORT_SYMBOL_GPL(skb_gro_receive_list);
 
 /**
  *	skb_segment - Perform protocol segmentation on skb.
@@ -4191,7 +4190,6 @@ int skb_gro_receive(struct sk_buff *p, struct sk_buff *skb)
 	NAPI_GRO_CB(skb)->same_flow = 1;
 	return 0;
 }
-EXPORT_SYMBOL_GPL(skb_gro_receive);
 
 #ifdef CONFIG_SKB_EXTENSIONS
 #define SKB_EXT_ALIGN_VALUE	8
Signature · 1 line
2.26.2.761.g0e0b3e54be-goog
maintainer
#1 lore raw

From: Eric Dumazet <[email protected]>
Date: Tue, 19 May 2020 15:50:12 -0700

Quoted 5 lines

skb_gro_receive() used to be used by SCTP, it is no longer the case.

skb_gro_receive_list() is in the same category : never used from modules.

Maybe this is net-next material instead?

#2 lore raw
Quoted 11 lines · David Miller

From: Eric Dumazet <[email protected]>
Date: Tue, 19 May 2020 15:50:12 -0700

Quoted 5 lines

skb_gro_receive() used to be used by SCTP, it is no longer the case.

skb_gro_receive_list() is in the same category : never used from modules.

Maybe this is net-next material instead?

Sure thing !

maintainer
#3 lore raw

From: Eric Dumazet <[email protected]>
Date: Tue, 19 May 2020 15:53:51 -0700

Quoted 7 lines · David Miller
Quoted 6 lines

From: Eric Dumazet <[email protected]>
Date: Tue, 19 May 2020 15:50:12 -0700

Quoted 2 lines

skb_gro_receive() used to be used by SCTP, it is no longer the case.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

skb_gro_receive_list() is in the same category : never used from modules.

Maybe this is net-next material instead?

Sure thing !

Great, applied :)