imx: add i.MX8M Nano EVK board support
v2 cover imx: add i.MX8M Nano EVK board support
This series adds support for the NXP i.MX8M Nano EVK board.
Since the i.MX8M Nano CPU was added for the Nitrogen8MNano board, which has a type of memory (LPDDR4) different from the NXP reference board (DDR4), the first half of the series introduce the DDR training selection for the whole i.MX8 M SoC family.
The second half of the series adds support for i.MX8M Nano EVK Board with kernel/ U-Boot based on 4.19.35_1.1.0, which is the current preferred version for all NXP reference boards.
Stephane Viau (5):
package/freescale-imx: Add option for DDR FW need package/freescale-imx/firmware-imx: add choice for DDR training
binaries
board/freescale/common/imx: use generic ddr_fw.bin name board/freescale/common/imx: add support for i.MX8M Nano configs/freescale_imx8mnevk: new defconfig
.gitlab-ci.yml | 1 + DEVELOPERS | 4 ++ .../common/imx/imx8-bootloader-prepare.sh | 6 +- board/freescale/common/imx/post-image.sh | 2 + board/freescale/imx8mnevk/readme.txt | 74 ++++++++++++++++++++++ configs/freescale_imx8mnevk_defconfig | 43 +++++++++++++ package/freescale-imx/Config.in | 7 ++ package/freescale-imx/firmware-imx/Config.in | 24 +++++++ package/freescale-imx/firmware-imx/firmware-imx.mk | 29 ++++++++- 9 files changed, 186 insertions(+), 4 deletions(-) create mode 100644 board/freescale/imx8mnevk/readme.txt create mode 100644 configs/freescale_imx8mnevk_defconfig
Signature · 1 line
2.7.4
PATCH v2 1/5 package/freescale-imx: Add option for DDR FW need
Only some i.MX8 need a DDR training firmware (8M, 8MM, 8MN). Some other i.MX8 (QuadMax, QuadXPlus) rely on system controller for that task.
---
v2:
- introduce BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW to extend the DDR firmware selection to the whole i.MX 8M family (suggested by Gary)
--- package/freescale-imx/Config.in | 7 +++++++ 1 file changed, 7 insertions(+)
package/freescale-imx/Config.in +7 -0
@@ -96,6 +96,13 @@ config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN || \ BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X +config BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW + bool + default y if \ + BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M || \ + BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM || \ + BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN + source "package/freescale-imx/imx-alsa-plugins/Config.in" source "package/freescale-imx/imx-codec/Config.in" source "package/freescale-imx/imx-kobs/Config.in"
Signature · 1 line
2.7.4
PATCH v2 1/5 package/freescale-imx: Add option for DDR FW need
Hi Stephane,
Quoted 20 lines · Stephane Viau
Only some i.MX8 need a DDR training firmware (8M, 8MM, 8MN). Some other i.MX8 (QuadMax, QuadXPlus) rely on system controller for that task.
Suggested-by Julien Olivain <[email protected]>Signed-off-by Stephane Viau <[email protected]>---
v2:
- introduceBR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FWto extend the DDR firmware selection to the whole i.MX 8M family (suggested by Gary)Signed-off-by Stephane Viau <[email protected]>--- package/freescale-imx/Config.in | 7 +++++++ 1 file changed, 7 insertions(+)package/freescale-imx/Config.in +0
-0
package/freescale-imx/Config.in config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU · line 104
Quoted 9 lines
package/freescale-imx/Config.in +6
-0@@ -96,6 +96,13 @@ config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN || \ BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X +config BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW + bool + default y if \ + BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M || \ + BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM || \ + BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN
I'm not against this approach but if I recall correctly Thomas is not a fan of those. Clearly it's useful and we'll soon add one more SoC to that macro (IMX8MP).
As Yann mentioned on IRC:
"Usually, when we introduce such option, it does not 'default y' based on some other options. Instead, the other options 'select' it."
Let's try to use that approach this time, although I know the rest of the file is doing it wrong :-/ (my bad)
But I'll answer to next patch as well, I don't think this is necessary to have that variable as it might be confusing for firmware-imx.
Regards,
Gary
PATCH v2 1/5 package/freescale-imx: Add option for DDR FW need
Quoted 2 lines
Hi Stephane,
Hi Gary,
Quoted 34 lines
Quoted 20 lines
Only some i.MX8 need a DDR training firmware (8M, 8MM, 8MN). Some other i.MX8 (QuadMax, QuadXPlus) rely on system controller for that task.
Suggested-by Julien Olivain <[email protected]>Signed-off-by Stephane Viau <[email protected]>---
v2:
- introduceBR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FWto extend the DDR firmware selection to the whole i.MX 8M family (suggested by Gary)Signed-off-by Stephane Viau <[email protected]>--- package/freescale-imx/Config.in | 7 +++++++ 1 file changed, 7 insertions(+)package/freescale-imx/Config.in +0
-0package/freescale-imx/Config.in config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU · line 104
Quoted 9 lines
package/freescale-imx/Config.in +6
-0@@ -96,6 +96,13 @@ config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN || \ BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X +config BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW + bool + default y if \ + BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M || \ + BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM || \ + BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MNI'm not against this approach but if I recall correctly Thomas is not a fan of those. Clearly it's useful and we'll soon add one more SoC to that macro (IMX8MP).
Quoted 7 lines
As Yann mentioned on IRC:
"Usually, when we introduce such option, it does not 'default y' based on some other options. Instead, the other options 'select' it."Let's try to use that approach this time, although I know the rest of the file is doing it wrong :-/ (my bad)
Makes sense, actually. I like this better too.
Quoted 2 lines
But I'll answer to next patch as well, I don't think this is necessary to have that variable as it might be confusing for firmware-imx.
Please see my comment in the next patch.
BR,
Stephane.
Quoted 3 lines
Regards,
Gary
PATCH v2 2/5 package/freescale-imx/firmware-imx: add choice for DDR training binaries
In reply to Stephane ViauSeveral i.MX8 (e.g.: 8M, 8MM, 8MN) support many DDR types (LPDDR4, DDR4, etc.), for which the DDR training is performed in the bootloader. Some boards have LPDDR4 (e.g.: nitrogen8mn) and some others have the DDR4 (e.g.: NXP's reference board EVK). This patch allows the selection of either of the binaries used to train the DDR.
---
v2:
- use BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW to extend the DDR firmware selection for 8M, 8MM and 8MN (suggested by Gary)
--- package/freescale-imx/firmware-imx/Config.in | 24 ++++++++++++++++++ package/freescale-imx/firmware-imx/firmware-imx.mk | 29 +++++++++++++++++++++- 2 files changed, 52 insertions(+), 1 deletion(-)
package/freescale-imx/firmware-imx/Config.in +24 -0
@@ -8,3 +8,27 @@ config BR2_PACKAGE_FIRMWARE_IMX This library is provided by Freescale as-is and doesn't have an upstream. + +if BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW + +choice + bool "DDR training binaries" + default BR2_PACKAGE_FIRMWARE_DDRFW_LPDDR4 + help + Choose the DDR training binaries to be used depending on the + kind of memory that is available on the target board (DDR4, + LPDDR4, etc...). + +config BR2_PACKAGE_FIRMWARE_DDRFW_LPDDR4 + bool "lpddr4" + help + Use LPDDR4 binaries (i.e.: lpddr4_pmu_train_*.bin) + +config BR2_PACKAGE_FIRMWARE_DDRFW_DDR4 + bool "DDR4" + help + Use DDR4 binaries (i.e.: ddr4_*_201810.bin). + +endchoice # DDR training FW + +endif
package/freescale-imx/firmware-imx/firmware-imx.mk +28 -1
@@ -18,7 +18,7 @@ define FIRMWARE_IMX_EXTRACT_CMDS $(call FREESCALE_IMX_EXTRACT_HELPER,$(FIRMWARE_IMX_DL_DIR)/$(FIRMWARE_IMX_SOURCE)) endef -ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M)$(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM)$(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN),y) +ifeq ($(BR2_PACKAGE_FIRMWARE_DDRFW_LPDDR4),y) FIRMWARE_IMX_INSTALL_IMAGES = YES FIRMWARE_IMX_DDRFW_DIR = $(@D)/firmware/ddr/synopsys define FIRMWARE_IMX_PREPARE_LPDDR4_FW
@@ -42,9 +42,36 @@ define FIRMWARE_IMX_INSTALL_IMAGES_CMDS cat $(FIRMWARE_IMX_DDRFW_DIR)/lpddr4_pmu_train_1d_fw.bin \ $(FIRMWARE_IMX_DDRFW_DIR)/lpddr4_pmu_train_2d_fw.bin > \ $(BINARIES_DIR)/lpddr4_pmu_train_fw.bin + ln -sf $(BINARIES_DIR)/lpddr4_pmu_train_fw.bin $(BINARIES_DIR)/ddr_fw.bin cp $(@D)/firmware/hdmi/cadence/signed_hdmi_imx8m.bin \ $(BINARIES_DIR)/signed_hdmi_imx8m.bin endef +else ifeq ($(BR2_PACKAGE_FIRMWARE_DDRFW_DDR4),y) +FIRMWARE_IMX_INSTALL_IMAGES = YES +FIRMWARE_IMX_DDRFW_DIR = $(@D)/firmware/ddr/synopsys +define FIRMWARE_IMX_PREPARE_DDR4_FW + $(TARGET_OBJCOPY) -I binary -O binary --pad-to 0x8000 --gap-fill=0x0 \ + $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_imem_$(1)_201810.bin \ + $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_imem_$(1)_201810_pad.bin + $(TARGET_OBJCOPY) -I binary -O binary --pad-to 0x4000 --gap-fill=0x0 \ + $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_dmem_$(1)_201810.bin \ + $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_dmem_$(1)_201810_pad.bin + cat $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_imem_$(1)_201810_pad.bin \ + $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_dmem_$(1)_201810_pad.bin > \ + $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_$(1)_201810_fw.bin +endef + +define FIRMWARE_IMX_INSTALL_IMAGES_CMDS + # Create padded versions of ddr4_* and generate ddr4_fw.bin. + # ddr4_fw.bin is needed when generating imx8-boot-sd.bin + # which is done in post-image script. + $(call FIRMWARE_IMX_PREPARE_DDR4_FW,1d) + $(call FIRMWARE_IMX_PREPARE_DDR4_FW,2d) + cat $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_1d_201810_fw.bin \ + $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_2d_201810_fw.bin > \ + $(BINARIES_DIR)/ddr4_201810_fw.bin + ln -sf $(BINARIES_DIR)/ddr4_201810_fw.bin $(BINARIES_DIR)/ddr_fw.bin +endef else ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X),y) define FIRMWARE_IMX_INSTALL_TARGET_CMDS $(INSTALL) -D -m 0644 $(@D)/firmware/vpu/vpu_fw_imx8_dec.bin \
Signature · 1 line
2.7.4
PATCH v2 2/5 package/freescale-imx/firmware-imx: add choice for DDR training binaries
Hi Stephane,
Quoted 25 lines · Stephane Viau
Several i.MX8 (e.g.: 8M, 8MM, 8MN) support many DDR types (LPDDR4, DDR4, etc.), for which the DDR training is performed in the bootloader. Some boards have LPDDR4 (e.g.: nitrogen8mn) and some others have the DDR4 (e.g.: NXP's reference board EVK). This patch allows the selection of either of the binaries used to train the DDR.
Signed-off-by Stephane Viau <[email protected]>Reviewed-by Maeva Manuel <[email protected]>Reviewed-by Julien Olivain <[email protected]>---
v2:
- useBR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FWto extend the DDR firmware selection for 8M, 8MM and 8MN (suggested by Gary)Signed-off-by Stephane Viau <[email protected]>--- package/freescale-imx/firmware-imx/Config.in | 24 ++++++++++++++++++ package/freescale-imx/firmware-imx/firmware-imx.mk | 29 +++++++++++++++++++++- 2 files changed, 52 insertions(+), 1 deletion(-)package/freescale-imx/firmware-imx/Config.in +0
-0
package/freescale-imx/firmware-imx/Config.in config BR2_PACKAGE_FIRMWARE_IMX · line 12
Quoted 5 lines
package/freescale-imx/firmware-imx/Config.in +2
-0@@ -8,3 +8,27 @@ config BR2_PACKAGE_FIRMWARE_IMX This library is provided by Freescale as-is and doesn't have an upstream. + +if BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW
Here is the only place where the previous variable is used, not sure it brings a lot of value.
Quoted 35 lines
package/freescale-imx/firmware-imx/Config.in +21
-0+choice + bool "DDR training binaries" + default BR2_PACKAGE_FIRMWARE_DDRFW_LPDDR4 + help + Choose the DDR training binaries to be used depending on the + kind of memory that is available on the target board (DDR4, + LPDDR4, etc...). + +config BR2_PACKAGE_FIRMWARE_DDRFW_LPDDR4 + bool "lpddr4" + help + Use LPDDR4 binaries (i.e.: lpddr4_pmu_train_*.bin) + +config BR2_PACKAGE_FIRMWARE_DDRFW_DDR4 + bool "DDR4" + help + Use DDR4 binaries (i.e.: ddr4_*_201810.bin). + +endchoice # DDR training FW + +endifpackage/freescale-imx/firmware-imx/firmware-imx.mk +1
-1@@ -18,7 +18,7 @@ define FIRMWARE_IMX_EXTRACT_CMDS $(call FREESCALE_IMX_EXTRACT_HELPER,$(FIRMWARE_IMX_DL_DIR)/$(FIRMWARE_IMX_SOURCE)) endef -ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M)$(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM)$(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN),y) +ifeq ($(BR2_PACKAGE_FIRMWARE_DDRFW_LPDDR4),y) FIRMWARE_IMX_INSTALL_IMAGES = YES FIRMWARE_IMX_DDRFW_DIR = $(@D)/firmware/ddr/synopsys define FIRMWARE_IMX_PREPARE_LPDDR4_FW
package/freescale-imx/firmware-imx/firmware-imx.mk define FIRMWARE_IMX_INSTALL_IMAGES_CMDS · line 47
Quoted 6 lines
package/freescale-imx/firmware-imx/firmware-imx.mk +1
-0@@ -42,9 +42,36 @@ define FIRMWARE_IMX_INSTALL_IMAGES_CMDS cat $(FIRMWARE_IMX_DDRFW_DIR)/lpddr4_pmu_train_1d_fw.bin \ $(FIRMWARE_IMX_DDRFW_DIR)/lpddr4_pmu_train_2d_fw.bin > \ $(BINARIES_DIR)/lpddr4_pmu_train_fw.bin + ln -sf $(BINARIES_DIR)/lpddr4_pmu_train_fw.bin $(BINARIES_DIR)/ddr_fw.bin cp $(@D)/firmware/hdmi/cadence/signed_hdmi_imx8m.bin \ $(BINARIES_DIR)/signed_hdmi_imx8m.bin
And here is why I'm worried the name of the previous variable might be misleading. You don't only copy the DDR FW training under that BR2_PACKAGE_FIRMWARE_DDRFW_LPDDR4 macro, you also copy the HDMI FW. Note that the DP FW should be added as well.
The way I see it, it'd be best to have a common FIRMWARE_IMX_INSTALL_IMAGES_CMDS for all i.MX8M platforms (hence not necessarily using a macro for it).
Then this CMD could have FIRMWARE_IMX_PREPARE_DDR_FW which would be different depending on the choice made before (DDR4 vs. LPDDR4) and then also something like FIRMWARE_IMX_PREPARE_HDMI_FW which would only be populated for IMX8M and empty for the others.
Does it make sense?
Quoted 17 lines
package/freescale-imx/firmware-imx/firmware-imx.mk +16
-0endef +else ifeq ($(BR2_PACKAGE_FIRMWARE_DDRFW_DDR4),y) +FIRMWARE_IMX_INSTALL_IMAGES = YES +FIRMWARE_IMX_DDRFW_DIR = $(@D)/firmware/ddr/synopsys +define FIRMWARE_IMX_PREPARE_DDR4_FW + $(TARGET_OBJCOPY) -I binary -O binary --pad-to 0x8000 --gap-fill=0x0 \ + $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_imem_$(1)_201810.bin \ + $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_imem_$(1)_201810_pad.bin + $(TARGET_OBJCOPY) -I binary -O binary --pad-to 0x4000 --gap-fill=0x0 \ + $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_dmem_$(1)_201810.bin \ + $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_dmem_$(1)_201810_pad.bin + cat $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_imem_$(1)_201810_pad.bin \ + $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_dmem_$(1)_201810_pad.bin > \ + $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_$(1)_201810_fw.bin +endef + +define FIRMWARE_IMX_INSTALL_IMAGES_CMDS
package/freescale-imx/firmware-imx/firmware-imx.mk define FIRMWARE_IMX_INSTALL_IMAGES_CMDS · line 74
Quoted 10 lines
package/freescale-imx/firmware-imx/firmware-imx.mk +10
-0+ # Create padded versions of ddr4_* and generate ddr4_fw.bin. + # ddr4_fw.bin is needed when generating imx8-boot-sd.bin + # which is done in post-image script. + $(call FIRMWARE_IMX_PREPARE_DDR4_FW,1d) + $(call FIRMWARE_IMX_PREPARE_DDR4_FW,2d) + cat $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_1d_201810_fw.bin \ + $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_2d_201810_fw.bin > \ + $(BINARIES_DIR)/ddr4_201810_fw.bin + ln -sf $(BINARIES_DIR)/ddr4_201810_fw.bin $(BINARIES_DIR)/ddr_fw.bin +endef
The approach above would also fix this case:
- What about i.MX8MQ with DDR4? HDMI FW is missing from this code.
Let me know if you have any questions.
Regards,
Gary
PATCH v2 2/5 package/freescale-imx/firmware-imx: add choice for DDR training binaries
Quoted 2 lines
Hi Stephane,
Hi Gary,
Quoted 26 lines
Quoted 26 lines
Several i.MX8 (e.g.: 8M, 8MM, 8MN) support many DDR types (LPDDR4, DDR4, etc.), for which the DDR training is performed in the bootloader. Some boards have LPDDR4 (e.g.: nitrogen8mn) and some others have the DDR4 (e.g.: NXP's reference board EVK). This patch allows the selection of either of the binaries used to train the DDR.
Signed-off-by Stephane Viau <[email protected]>Reviewed-by Maeva Manuel <[email protected]>Reviewed-by Julien Olivain <[email protected]>---
v2:
- useBR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FWto extend the DDR firmware selection for 8M, 8MM and 8MN (suggested by Gary)Signed-off-by Stephane Viau <[email protected]>--- package/freescale-imx/firmware-imx/Config.in | 24 ++++++++++++++++++ package/freescale-imx/firmware-imx/firmware-imx.mk | 29 +++++++++++++++++++++- 2 files changed, 52 insertions(+), 1 deletion(-)package/freescale-imx/firmware-imx/Config.in +0
-0@@ -8,3 +8,27 @@ config BR2_PACKAGE_FIRMWARE_IMX
Quoted 7 lines
package/freescale-imx/firmware-imx/Config.in config BR2_PACKAGE_FIRMWARE_IMX · line 12
Quoted 4 lines
package/freescale-imx/firmware-imx/Config.in +2
-0This library is provided by Freescale as-is and doesn't have an upstream. + +if BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FWHere is the only place where the previous variable is used, not sure it brings a lot of value.
I believe BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW is still required here in order to avoid seeing the below DDR FW options when they are not required (e.g. i.MX 8 family). We want this choice to pop up only for i.MX 8M SoCs.
Quoted 56 lines
Quoted 36 lines
package/freescale-imx/firmware-imx/Config.in +21
-0+choice + bool "DDR training binaries" + default BR2_PACKAGE_FIRMWARE_DDRFW_LPDDR4 + help + Choose the DDR training binaries to be used depending on the + kind of memory that is available on the target board (DDR4, + LPDDR4, etc...). + +config BR2_PACKAGE_FIRMWARE_DDRFW_LPDDR4 + bool "lpddr4" + help + Use LPDDR4 binaries (i.e.: lpddr4_pmu_train_*.bin) + +config BR2_PACKAGE_FIRMWARE_DDRFW_DDR4 + bool "DDR4" + help + Use DDR4 binaries (i.e.: ddr4_*_201810.bin). + +endchoice # DDR training FW + +endifpackage/freescale-imx/firmware-imx/firmware-imx.mk +1
-1@@ -18,7 +18,7 @@ define FIRMWARE_IMX_EXTRACT_CMDS $(call FREESCALE_IMX_EXTRACT_HELPER,$(FIRMWARE_IMX_DL_DIR)/$(FIRMWARE_IMX_SOURCE)) endef -ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M)$(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM)$(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN),y) +ifeq ($(BR2_PACKAGE_FIRMWARE_DDRFW_LPDDR4),y) FIRMWARE_IMX_INSTALL_IMAGES = YES FIRMWARE_IMX_DDRFW_DIR = $(@D)/firmware/ddr/synopsys define FIRMWARE_IMX_PREPARE_LPDDR4_FWpackage/freescale-imx/firmware-imx/firmware-imx.mk define FIRMWARE_IMX_INSTALL_IMAGES_CMDS · line 47
Quoted 6 lines
package/freescale-imx/firmware-imx/firmware-imx.mk +1
-0@@ -42,9 +42,36 @@ define FIRMWARE_IMX_INSTALL_IMAGES_CMDS cat $(FIRMWARE_IMX_DDRFW_DIR)/lpddr4_pmu_train_1d_fw.bin \ $(FIRMWARE_IMX_DDRFW_DIR)/lpddr4_pmu_train_2d_fw.bin > \ $(BINARIES_DIR)/lpddr4_pmu_train_fw.bin + ln -sf $(BINARIES_DIR)/lpddr4_pmu_train_fw.bin $(BINARIES_DIR)/ddr_fw.bin cp $(@D)/firmware/hdmi/cadence/signed_hdmi_imx8m.bin \ $(BINARIES_DIR)/signed_hdmi_imx8m.binAnd here is why I'm worried the name of the previous variable might be misleading. You don't only copy the DDR FW training under that
BR2_PACKAGE_FIRMWARE_DDRFW_LPDDR4macro, you also copy the HDMI FW. Note that the DP FW should be added as well.The way I see it, it'd be best to have a common
FIRMWARE_IMX_INSTALL_IMAGES_CMDSfor all i.MX8M platforms (hence not necessarily using a macro for it).
Then this CMD could haveFIRMWARE_IMX_PREPARE_DDR_FWwhich would be different depending on the choice made before (DDR4 vs. LPDDR4) and then also something likeFIRMWARE_IMX_PREPARE_HDMI_FWwhich would only be populated for IMX8M and empty for the others.
Quoted 1 line
Does it make sense?
Agreed. please check the v3 patch series:
https://patchwork.ozlabs.org/project/buildroot/list/?series=179135
Regards,
Stephane.
Quoted 36 lines
Quoted 18 lines
package/freescale-imx/firmware-imx/firmware-imx.mk +16
-0endef +else ifeq ($(BR2_PACKAGE_FIRMWARE_DDRFW_DDR4),y) +FIRMWARE_IMX_INSTALL_IMAGES = YES +FIRMWARE_IMX_DDRFW_DIR = $(@D)/firmware/ddr/synopsys +define FIRMWARE_IMX_PREPARE_DDR4_FW + $(TARGET_OBJCOPY) -I binary -O binary --pad-to 0x8000 --gap-fill=0x0 \ + $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_imem_$(1)_201810.bin \ + $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_imem_$(1)_201810_pad.bin + $(TARGET_OBJCOPY) -I binary -O binary --pad-to 0x4000 --gap-fill=0x0 \ + $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_dmem_$(1)_201810.bin \ + $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_dmem_$(1)_201810_pad.bin + cat $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_imem_$(1)_201810_pad.bin \ + $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_dmem_$(1)_201810_pad.bin > \ + $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_$(1)_201810_fw.bin +endef + +define FIRMWARE_IMX_INSTALL_IMAGES_CMDSpackage/freescale-imx/firmware-imx/firmware-imx.mk define FIRMWARE_IMX_INSTALL_IMAGES_CMDS · line 74
Quoted 10 lines
package/freescale-imx/firmware-imx/firmware-imx.mk +10
-0+ # Create padded versions of ddr4_* and generate ddr4_fw.bin. + # ddr4_fw.bin is needed when generating imx8-boot-sd.bin + # which is done in post-image script. + $(call FIRMWARE_IMX_PREPARE_DDR4_FW,1d) + $(call FIRMWARE_IMX_PREPARE_DDR4_FW,2d) + cat $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_1d_201810_fw.bin \ + $(FIRMWARE_IMX_DDRFW_DIR)/ddr4_2d_201810_fw.bin > \ + $(BINARIES_DIR)/ddr4_201810_fw.bin + ln -sf $(BINARIES_DIR)/ddr4_201810_fw.bin $(BINARIES_DIR)/ddr_fw.bin +endefThe approach above would also fix this case:
- What about i.MX8MQ with DDR4? HDMI FW is missing from this code.Let me know if you have any questions.
Regards,
Gary
PATCH v2 3/5 board/freescale/common/imx: use generic ddr_fw.bin name
In reply to Stephane ViauFor some SoCs (i.e.: i.MX8M Nano for now), the DDR training firmware in the boot image depends on the type of memory installed on a board (LPDDR4, DDR4, etc...). The previous patch makes this firmware name agnostic of the DDR type and uses ddr_fw.bin as a generic name. This patch makes imx8-bootloader-prepare.sh use this generic name, independently of the kind board DDR type.
---
v2:
- generic ddr_fw.bin name is now used also for 8M and 8MM, along with 8MN (suggested by Gary)
--- board/freescale/common/imx/imx8-bootloader-prepare.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
board/freescale/common/imx/imx8-bootloader-prepare.sh +3 -3
@@ -9,21 +9,21 @@ main () fi if grep -Eq "^BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M=y$" ${BR2_CONFIG}; then - cat ${BINARIES_DIR}/u-boot-spl.bin ${BINARIES_DIR}/lpddr4_pmu_train_fw.bin > ${BINARIES_DIR}/u-boot-spl-ddr.bin + cat ${BINARIES_DIR}/u-boot-spl.bin ${BINARIES_DIR}/ddr_fw.bin > ${BINARIES_DIR}/u-boot-spl-ddr.bin BL31=${BINARIES_DIR}/bl31.bin BL33=${BINARIES_DIR}/u-boot-nodtb.bin ATF_LOAD_ADDR=0x00910000 ${HOST_DIR}/bin/mkimage_fit_atf.sh ${UBOOT_DTB} > ${BINARIES_DIR}/u-boot.its ${HOST_DIR}/bin/mkimage -E -p 0x3000 -f ${BINARIES_DIR}/u-boot.its ${BINARIES_DIR}/u-boot.itb rm -f ${BINARIES_DIR}/u-boot.its ${HOST_DIR}/bin/mkimage_imx8 -fit -signed_hdmi ${BINARIES_DIR}/signed_hdmi_imx8m.bin -loader ${BINARIES_DIR}/u-boot-spl-ddr.bin 0x7E1000 -second_loader ${BINARIES_DIR}/u-boot.itb 0x40200000 0x60000 -out ${BINARIES_DIR}/imx8-boot-sd.bin elif grep -Eq "^BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM=y$" ${BR2_CONFIG}; then - cat ${BINARIES_DIR}/u-boot-spl.bin ${BINARIES_DIR}/lpddr4_pmu_train_fw.bin > ${BINARIES_DIR}/u-boot-spl-ddr.bin + cat ${BINARIES_DIR}/u-boot-spl.bin ${BINARIES_DIR}/ddr_fw.bin > ${BINARIES_DIR}/u-boot-spl-ddr.bin BL31=${BINARIES_DIR}/bl31.bin BL33=${BINARIES_DIR}/u-boot-nodtb.bin ATF_LOAD_ADDR=0x00920000 ${HOST_DIR}/bin/mkimage_fit_atf.sh ${UBOOT_DTB} > ${BINARIES_DIR}/u-boot.its ${HOST_DIR}/bin/mkimage -E -p 0x3000 -f ${BINARIES_DIR}/u-boot.its ${BINARIES_DIR}/u-boot.itb rm -f ${BINARIES_DIR}/u-boot.its ${HOST_DIR}/bin/mkimage_imx8 -fit -loader ${BINARIES_DIR}/u-boot-spl-ddr.bin 0x7E1000 -second_loader ${BINARIES_DIR}/u-boot.itb 0x40200000 0x60000 -out ${BINARIES_DIR}/imx8-boot-sd.bin elif grep -Eq "^BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN=y$" ${BR2_CONFIG}; then - cat ${BINARIES_DIR}/u-boot-spl.bin ${BINARIES_DIR}/lpddr4_pmu_train_fw.bin > ${BINARIES_DIR}/u-boot-spl-ddr.bin + cat ${BINARIES_DIR}/u-boot-spl.bin ${BINARIES_DIR}/ddr_fw.bin > ${BINARIES_DIR}/u-boot-spl-ddr.bin BL31=${BINARIES_DIR}/bl31.bin BL33=${BINARIES_DIR}/u-boot-nodtb.bin ATF_LOAD_ADDR=0x00960000 ${HOST_DIR}/bin/mkimage_fit_atf.sh ${UBOOT_DTB} > ${BINARIES_DIR}/u-boot.its ${HOST_DIR}/bin/mkimage -E -p 0x3000 -f ${BINARIES_DIR}/u-boot.its ${BINARIES_DIR}/u-boot.itb rm -f ${BINARIES_DIR}/u-boot.its
Signature · 1 line
2.7.4
PATCH v2 4/5 board/freescale/common/imx: add support for i.MX8M Nano
In reply to Stephane Viau--- board/freescale/common/imx/post-image.sh | 2 ++ 1 file changed, 2 insertions(+)
board/freescale/common/imx/post-image.sh +2 -0
@@ -38,6 +38,8 @@ genimage_type() echo "genimage.cfg.template_imx8" elif grep -Eq "^BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM=y$" ${BR2_CONFIG}; then echo "genimage.cfg.template_imx8" + elif grep -Eq "^BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN=y$" ${BR2_CONFIG}; then + echo "genimage.cfg.template_imx8" elif grep -Eq "^BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X=y$" ${BR2_CONFIG}; then echo "genimage.cfg.template_imx8" elif grep -Eq "^BR2_LINUX_KERNEL_INSTALL_TARGET=y$" ${BR2_CONFIG}; then
Signature · 1 line
2.7.4
PATCH v2 5/5 configs/freescale_imx8mnevk: new defconfig
In reply to Stephane ViauThis patch adds support for the i.MX8M Nano EVK Board [1].
The final boot image is created from uboot and firmware binaries in post image script board/freescale/common/imx/imx8-bootloader-prepare.sh
Note that this config is based on 4.19.35_1.1.0 ; hence, the kernel configuration needs host-openssl to build.
---
v2:
- reword commit title about uboot.imx generation: sentence removed (Gary)
- replace link which was confusing because mentioning LPD4 when DDR4 EVK is actually available (suggested by Gary)
--- .gitlab-ci.yml | 1 + DEVELOPERS | 4 ++ board/freescale/imx8mnevk/readme.txt | 74 +++++++++++++++++++++++++++++++++++ configs/freescale_imx8mnevk_defconfig | 43 ++++++++++++++++++++ 4 files changed, 122 insertions(+) create mode 100644 board/freescale/imx8mnevk/readme.txt create mode 100644 configs/freescale_imx8mnevk_defconfig
.gitlab-ci.yml +1 -0
@@ -190,6 +190,7 @@ freescale_imx8mmevk_defconfig: { extends: .defconfig } freescale_imx8mqevk_defconfig: { extends: .defconfig } freescale_imx8qmmek_defconfig: { extends: .defconfig } freescale_imx8qxpmek_defconfig: { extends: .defconfig } +freescale_imx8mnevk_defconfig: { extends: .defconfig } freescale_p1025twr_defconfig: { extends: .defconfig } freescale_t1040d4rdb_defconfig: { extends: .defconfig } freescale_t2080_qds_rdb_defconfig: { extends: .defconfig }
DEVELOPERS +4 -0
@@ -2402,6 +2402,10 @@ F: package/mtdev2tuio/ N: Stephan Hoffmann <[email protected]> F: package/libhttpserver/ +N: Stephane Viau <[email protected]> +F: board/freescale/imx8mnevk/ +F: configs/freescale_imx8mnevk_defconfig + N: Steve Calfee <[email protected]> F: package/python-pymysql/ F: package/python-pyratemp/
board/freescale/imx8mnevk/readme.txt new file +74 -0
74 lines not on this page · raw message
configs/freescale_imx8mnevk_defconfig new file +43 -0
43 lines not on this page · raw message
Signature · 1 line
2.7.4
v2 cover imx: add i.MX8M Nano EVK board support
In reply to Stephane ViauHello,
Quoted 10 lines · On Wed, 29 Apr 2020 11:12:20 +0200 Stephane Viau <[email protected]>…
This series adds support for the NXP i.MX8M Nano EVK board.
Since the i.MX8M Nano CPU was added for the Nitrogen8MNano board, which has a type of memory (LPDDR4) different from the NXP reference board (DDR4), the first half of the series introduce the DDR training selection for the whole i.MX8 M SoC family.
The second half of the series adds support for i.MX8M Nano EVK Board with
kernel/U-Boot based on 4.19.35_1.1.0, which is the current preferred version for all NXP reference boards.
Thanks for this new iteration. It was in our patchwork patch tracking system, and it just disappeared. Has anyone removed these patches? You Stephane? Someone else?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
v2 cover imx: add i.MX8M Nano EVK board support
Quoted 14 lines
Hello,
Quoted 7 lines · On Wed, 29 Apr 2020 11:12:20 +0200 Stephane Viau <[email protected]>…
This series adds support for the NXP i.MX8M Nano EVK board.
Since the i.MX8M Nano CPU was added for the Nitrogen8MNano board, which has a type of memory (LPDDR4) different from the NXP reference board (DDR4), the first half of the series introduce the DDR training selection for the whole i.MX8 M SoC family.
Quoted 7 lines
Quoted 3 lines
The second half of the series adds support for i.MX8M Nano EVK Board with
kernel/U-Boot based on 4.19.35_1.1.0, which is the current preferred version for all NXP reference boards.Thanks for this new iteration. It was in our patchwork patch tracking system, and it just disappeared. Has anyone removed these patches? You Stephane? Someone else?
Hi Thomas,
Yeah, sorry about that. It should be back now ; can you please check?
Regards,
Stephane.
Quoted 9 lines
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
v2 cover imx: add i.MX8M Nano EVK board support
Quoted 5 lines · On Wed, 29 Apr 2020 20:36:31 +0000 "Stephane Viau (OSS)"…
Quoted 3 lines
Thanks for this new iteration. It was in our patchwork patch tracking system, and it just disappeared. Has anyone removed these patches? You Stephane? Someone else?
Yeah, sorry about that. It should be back now ; can you please check?
Confirmed, thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com