Skip to contentSkip to conversation

GCOV: profile by modules

RFC PATCH Superseded [email protected] 2 participants 5 messages May 20, 2020

Subsystems (2)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

RFC PATCH v2 1/1 GCOV: profile by modules

From: Cixi Geng <[email protected]>

---
Replace symbol GCOV_PROFILE_MODULES with GCOV_PROFILE_PREREQS
---
The CONFIG_GCOV_PROFILE_ALL will compile kernel by profiling entire kernel which will lead to kernel run slower.Use GCOV_PROFILE_PREREQS to control part of the kernel modules to open gcov.

Only add SERIAL_GCOV for an example.

---
 drivers/tty/serial/Kconfig  |  6 ++++++
 drivers/tty/serial/Makefile |  1 +
 kernel/gcov/Kconfig         | 14 ++++++++++++++
 3 files changed, 21 insertions(+)
drivers/tty/serial/Kconfig +6 -0
index adf9e80e7dc9..964df1a2989c 100644
@@ -1566,3 +1566,9 @@ endmenu
 
 config SERIAL_MCTRL_GPIO
 	tristate
+
+config SERIAL_GCOV
+       bool "open gcov for serial"
+       depends on GCOV_PROFILE_PREREQS
+       help
+         Say Y here to enable gcov in serial.
drivers/tty/serial/Makefile +1 -0
index d056ee6cca33..7be1202286d2 100644
@@ -2,6 +2,7 @@
 #
 # Makefile for the kernel serial device drivers.
 #
+GCOV_PROFILE := $(CONFIG_SERIAL_GCOV)
 
 obj-$(CONFIG_SERIAL_CORE) += serial_core.o
 
kernel/gcov/Kconfig +14 -0
index 3941a9c48f83..91cc8f3c7c43 100644
@@ -51,6 +51,20 @@ config GCOV_PROFILE_ALL
 	larger and run slower. Also be sure to exclude files from profiling
 	which are not linked to the kernel image to prevent linker errors.
 
+config GCOV_PROFILE_PREREQS
+	bool "Profile Kernel subsytem"
+	depends on !COMPILE_TEST
+	depends on GCOV_KERNEL
+	default n
+	help
+	This options activates profiling for the specified kernel modules.
+
+	If unsure, say N.
+
+	When some modules need Gcov data, enable this config, then configure
+	with gcov on the corresponding modules configs.The directories or files
+	of these modules will be added profiling flags after kernel compile.
+
 choice
 	prompt "Specify GCOV format"
 	depends on GCOV_KERNEL
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 5 lines · On Wed, May 20, 2020 at 04:38:21PM +0800, [email protected] wrote:

From: Cixi Geng <[email protected]>

---
Replace symbol GCOV_PROFILE_MODULES with GCOV_PROFILE_PREREQS
---

That can't go in the body of a changelog, as it will be cut off. Try applying this patch with 'git am' and see what happens :(

maintainer
#2 lore raw
In reply to [email protected]
Quoted 23 lines · On Wed, May 20, 2020 at 04:38:21PM +0800, [email protected] wrote:

From: Cixi Geng <[email protected]>

---
Replace symbol GCOV_PROFILE_MODULES with GCOV_PROFILE_PREREQS
---
The CONFIG_GCOV_PROFILE_ALL will compile kernel by profiling entire kernel which will lead to kernel run slower.Use GCOV_PROFILE_PREREQS to control part of the kernel modules to open gcov.

Only add SERIAL_GCOV for an example.

---
 drivers/tty/serial/Kconfig  |  6 ++++++
 drivers/tty/serial/Makefile |  1 +
 kernel/gcov/Kconfig         | 14 ++++++++++++++
 3 files changed, 21 insertions(+)
drivers/tty/serial/Kconfig +0 -0
index adf9e80e7dc9..964df1a2989c 100644

drivers/tty/serial/Kconfig endmenu · line 1571

Quoted 6 lines
drivers/tty/serial/Kconfig +3 -0
@@ -1566,3 +1566,9 @@ endmenu
 
 config SERIAL_MCTRL_GPIO
 	tristate
+
+config SERIAL_GCOV
+       bool "open gcov for serial"

What do you mean by "open"? And Kconfig entries are usually Upper Case" :)

drivers/tty/serial/Kconfig endmenu · line 1574

Quoted 3 lines
drivers/tty/serial/Kconfig +3 -0
+       depends on GCOV_PROFILE_PREREQS
+       help
+         Say Y here to enable gcov in serial.

I think we need more text here.

Quoted 17 lines
drivers/tty/serial/Makefile +1 -0
index d056ee6cca33..7be1202286d2 100644
@@ -2,6 +2,7 @@
 #
 # Makefile for the kernel serial device drivers.
 #
+GCOV_PROFILE := $(CONFIG_SERIAL_GCOV)
 
 obj-$(CONFIG_SERIAL_CORE) += serial_core.o
 
kernel/gcov/Kconfig +0 -0
index 3941a9c48f83..91cc8f3c7c43 100644

kernel/gcov/Kconfig config GCOV_PROFILE_ALL · line 58

Quoted 8 lines
kernel/gcov/Kconfig +5 -0
@@ -51,6 +51,20 @@ config GCOV_PROFILE_ALL
 	larger and run slower. Also be sure to exclude files from profiling
 	which are not linked to the kernel image to prevent linker errors.
 
+config GCOV_PROFILE_PREREQS
+	bool "Profile Kernel subsytem"
+	depends on !COMPILE_TEST
+	depends on GCOV_KERNEL
+	default n

default is always 'n', no need to list that

kernel/gcov/Kconfig config GCOV_PROFILE_ALL · line 65

Quoted 7 lines
kernel/gcov/Kconfig +7 -0
+	help
+	This options activates profiling for the specified kernel modules.
+
+	If unsure, say N.
+
+	When some modules need Gcov data, enable this config, then configure
+	with gcov on the corresponding modules configs.The directories or files

'. '?

kernel/gcov/Kconfig config GCOV_PROFILE_ALL · line 66

Quoted 1 line
kernel/gcov/Kconfig +1 -0
+	of these modules will be added profiling flags after kernel compile.

The lines under "help" need to be indented more, right?

thanks,

greg k-h

author
#3 lore raw

Thank you for guidances, I will fix error and upload new patch

Quoted 86 lines · Greg KH <[email protected]> 于2020年5月20日周三 下午4:51写道:
Quoted 23 lines · On Wed, May 20, 2020 at 04:38:21PM +0800, [email protected] wrote:

From: Cixi Geng <[email protected]>

---
Replace symbol GCOV_PROFILE_MODULES with GCOV_PROFILE_PREREQS
---
The CONFIG_GCOV_PROFILE_ALL will compile kernel by profiling entire kernel which will lead to kernel run slower.Use GCOV_PROFILE_PREREQS to control part of the kernel modules to open gcov.

Only add SERIAL_GCOV for an example.

---
 drivers/tty/serial/Kconfig  |  6 ++++++
 drivers/tty/serial/Makefile |  1 +
 kernel/gcov/Kconfig         | 14 ++++++++++++++
 3 files changed, 21 insertions(+)
drivers/tty/serial/Kconfig +0 -0
index adf9e80e7dc9..964df1a2989c 100644

drivers/tty/serial/Kconfig endmenu · line 1571

Quoted 6 lines
drivers/tty/serial/Kconfig +3 -0
@@ -1566,3 +1566,9 @@ endmenu
 
 config SERIAL_MCTRL_GPIO
      tristate
+
+config SERIAL_GCOV
+       bool "open gcov for serial"

What do you mean by "open"? And Kconfig entries are usually Upper Case" :)

drivers/tty/serial/Kconfig endmenu · line 1574

Quoted 3 lines
drivers/tty/serial/Kconfig +3 -0
+       depends on GCOV_PROFILE_PREREQS
+       help
+         Say Y here to enable gcov in serial.

I think we need more text here.

Quoted 17 lines
drivers/tty/serial/Makefile +1 -0
index d056ee6cca33..7be1202286d2 100644
@@ -2,6 +2,7 @@
 #
 # Makefile for the kernel serial device drivers.
 #
+GCOV_PROFILE := $(CONFIG_SERIAL_GCOV)
 
 obj-$(CONFIG_SERIAL_CORE) += serial_core.o
 
kernel/gcov/Kconfig +0 -0
index 3941a9c48f83..91cc8f3c7c43 100644

kernel/gcov/Kconfig config GCOV_PROFILE_ALL · line 58

Quoted 8 lines
kernel/gcov/Kconfig +5 -0
@@ -51,6 +51,20 @@ config GCOV_PROFILE_ALL
      larger and run slower. Also be sure to exclude files from profiling
      which are not linked to the kernel image to prevent linker errors.
 
+config GCOV_PROFILE_PREREQS
+     bool "Profile Kernel subsytem"
+     depends on !COMPILE_TEST
+     depends on GCOV_KERNEL
+     default n

default is always 'n', no need to list that

kernel/gcov/Kconfig config GCOV_PROFILE_ALL · line 65

Quoted 7 lines
kernel/gcov/Kconfig +7 -0
+     help
+     This options activates profiling for the specified kernel modules.
+
+     If unsure, say N.
+
+     When some modules need Gcov data, enable this config, then configure
+     with gcov on the corresponding modules configs.The directories or files

'. '?

kernel/gcov/Kconfig config GCOV_PROFILE_ALL · line 66

Quoted 1 line
kernel/gcov/Kconfig +1 -0
+     of these modules will be added profiling flags after kernel compile.

The lines under "help" need to be indented more, right?

thanks,

greg k-h

author
#4 lore raw
Quoted 10 lines

drivers/tty/serial/Kconfig endmenu · line 1571

Quoted 2 lines
drivers/tty/serial/Kconfig +2 -0
+config SERIAL_GCOV
+       bool "open gcov for serial"

What do you mean by "open"? And Kconfig entries are usually Upper Case" :)

drivers/tty/serial/Kconfig endmenu · line 1574

Quoted 3 lines
drivers/tty/serial/Kconfig +3 -0
+       depends on GCOV_PROFILE_PREREQS
+       help
+         Say Y here to enable gcov in serial.

I think we need more text here.

Maybe I should use "Enable" instead of "open" for express more clearly. and I will add more description of SERIAL_GCOV

Quoted 90 lines · Cixi Geng <[email protected]> 于2020年5月20日周三 下午5:04写道:

Thank you for guidances, I will fix error and upload new patch

Quoted 86 lines · Greg KH <[email protected]> 于2020年5月20日周三 下午4:51写道:
Quoted 23 lines · On Wed, May 20, 2020 at 04:38:21PM +0800, [email protected] wrote:

From: Cixi Geng <[email protected]>

---
Replace symbol GCOV_PROFILE_MODULES with GCOV_PROFILE_PREREQS
---
The CONFIG_GCOV_PROFILE_ALL will compile kernel by profiling entire kernel which will lead to kernel run slower.Use GCOV_PROFILE_PREREQS to control part of the kernel modules to open gcov.

Only add SERIAL_GCOV for an example.

---
 drivers/tty/serial/Kconfig  |  6 ++++++
 drivers/tty/serial/Makefile |  1 +
 kernel/gcov/Kconfig         | 14 ++++++++++++++
 3 files changed, 21 insertions(+)
drivers/tty/serial/Kconfig +0 -0
index adf9e80e7dc9..964df1a2989c 100644

drivers/tty/serial/Kconfig endmenu · line 1571

Quoted 6 lines
drivers/tty/serial/Kconfig +3 -0
@@ -1566,3 +1566,9 @@ endmenu
 
 config SERIAL_MCTRL_GPIO
      tristate
+
+config SERIAL_GCOV
+       bool "open gcov for serial"

What do you mean by "open"? And Kconfig entries are usually Upper Case" :)

drivers/tty/serial/Kconfig endmenu · line 1574

Quoted 3 lines
drivers/tty/serial/Kconfig +3 -0
+       depends on GCOV_PROFILE_PREREQS
+       help
+         Say Y here to enable gcov in serial.

I think we need more text here.

Quoted 17 lines
drivers/tty/serial/Makefile +1 -0
index d056ee6cca33..7be1202286d2 100644
@@ -2,6 +2,7 @@
 #
 # Makefile for the kernel serial device drivers.
 #
+GCOV_PROFILE := $(CONFIG_SERIAL_GCOV)
 
 obj-$(CONFIG_SERIAL_CORE) += serial_core.o
 
kernel/gcov/Kconfig +0 -0
index 3941a9c48f83..91cc8f3c7c43 100644

kernel/gcov/Kconfig config GCOV_PROFILE_ALL · line 58

Quoted 8 lines
kernel/gcov/Kconfig +5 -0
@@ -51,6 +51,20 @@ config GCOV_PROFILE_ALL
      larger and run slower. Also be sure to exclude files from profiling
      which are not linked to the kernel image to prevent linker errors.
 
+config GCOV_PROFILE_PREREQS
+     bool "Profile Kernel subsytem"
+     depends on !COMPILE_TEST
+     depends on GCOV_KERNEL
+     default n

default is always 'n', no need to list that

kernel/gcov/Kconfig config GCOV_PROFILE_ALL · line 65

Quoted 7 lines
kernel/gcov/Kconfig +7 -0
+     help
+     This options activates profiling for the specified kernel modules.
+
+     If unsure, say N.
+
+     When some modules need Gcov data, enable this config, then configure
+     with gcov on the corresponding modules configs.The directories or files

'. '?

kernel/gcov/Kconfig config GCOV_PROFILE_ALL · line 66

Quoted 1 line
kernel/gcov/Kconfig +1 -0
+     of these modules will be added profiling flags after kernel compile.

The lines under "help" need to be indented more, right?

thanks,

greg k-h